Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp3864380rdb; Thu, 14 Sep 2023 05:16:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEJHja8FDTFvl+RH3tePrumwGkD6VcCW2bSzlUiQgmJ+XUlzix9QhIToJwWcgUsPRNYZQKx X-Received: by 2002:a17:903:1cb:b0:1c2:c60:8387 with SMTP id e11-20020a17090301cb00b001c20c608387mr5801157plh.0.1694693819246; Thu, 14 Sep 2023 05:16:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694693819; cv=none; d=google.com; s=arc-20160816; b=uBusE8EZyEN38pxl0Cb9M+Ok/kXAufjftd0kTa1v/6YF0e6Pya/b3D/RIf8XUT6k7/ 9Y8SVcQeWeaTdSKvnoufN52A4FoY5bqk0XrwOc9PNOaQogxDNj0/lLPC9ZYfhe8o+YHg PiO7h3cDh1ISoLjwDwG22dIZtyLLJSI4FrT1R9OBLJzKNhMsaXpPYMvYSd4OsEHLgQQ6 ty4FwCSR5Pa6c+GknT6ZagJ7OED/i9kkS/xAtrYfxlXFKK+Mmb/PMbRcu24lJF98BW5/ 4Pz64SPLkrHW6KTqRxS3xO0PR3hPCdtdCuEhcdENwLOoReJIfV72Wn4jsu8SXoo1HfsS Otgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=+Ln9AYYR12krk4RrRHWYO/LjdYMxN479/wAy3HLaC4E=; fh=8PHgZ2T1RcwLKjgHGl0uxvKADiK/aYrh/AY72pv6KYA=; b=BxO+IjWS55n2AI5/cfF1niFTFRriklPEtT/Fypje8MPuGIT0Ar48uUFf7vaeXakC4b zP3ilQRLtq8LfwMrmMcAwHZ2e6t7+PN3FIbdIw+Wv3NMvKK1EWYMigFX48drLtILhQnk 2dHVqe6TqSFYjvw21DWQMl8o1LkRpCu04ZCty8ky25IrlMM5pRfrYx4z6LUndpJWpJct AEJsWWJLvB4bvYY8bANJ0/3pJ5RUrYrkW1BYNqb7HDCd99UVo6XIZsFcoyj2vMoBsKE1 LtE5dU9qHDtdF53mTluj35ACLB25sItcRzFGJUdSdw99nvanJaZaHXRYZzQEluyTS+NY ZCjg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LKoFw1Zs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id c17-20020a170903235100b001bf559a7bc6si1655941plh.465.2023.09.14.05.16.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Sep 2023 05:16:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LKoFw1Zs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id E62DE8325D16; Wed, 13 Sep 2023 23:38:11 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235541AbjINGiL (ORCPT + 99 others); Thu, 14 Sep 2023 02:38:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232856AbjINGiK (ORCPT ); Thu, 14 Sep 2023 02:38:10 -0400 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C588CCD for ; Wed, 13 Sep 2023 23:38:06 -0700 (PDT) Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-401b393ddd2so6546365e9.0 for ; Wed, 13 Sep 2023 23:38:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694673485; x=1695278285; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+Ln9AYYR12krk4RrRHWYO/LjdYMxN479/wAy3HLaC4E=; b=LKoFw1ZsEPVitQv/QBGJj+3Q062VKdL9KZvfQemkrsVQHpEU14qFK90vwnsJV0MDkz paFiqeA4HZr3NnCgszcnkSYCsIttRfC7GQ3raFunY1nhUvt5RnY/rqeIogUUGvrK4b4T JoKP/RQKHfgL/4FrSvoIk+aXBAVDEdBxdpfmwT++WphT707ZjY2ZRT0dJo85EY4DTafo W3EGgvS6R7LIWOTPmYazqGeo6gU2TkhuRBVId+jDnDT1sdDeqWDZGTN+hdgNCVZwfrOf vQbubjLGLh/bv/dqnV0l63hunl5+g+sofejyIS8N37WtKaoBGXkG9lEnKqWUmUeJa3i2 kW6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694673485; x=1695278285; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+Ln9AYYR12krk4RrRHWYO/LjdYMxN479/wAy3HLaC4E=; b=Zd2Q1xZUVIW8RUZVSn/OmCDLxnPXV+S8xJs9GeoT2mLs3UUB+KFNKWmrNM0puDCmaz 6gEMePObYka6bFmBdKcJnigOlYS+9NPuYwrteRyBOXuD8SEms1A3Jjg7UyJXdVFxVRps TowuJI4jTS8wYZbxabypeg+JGifUsdg7Eczw+Cdj/thUZa1fOS9d8Dys9tSuMsETVMCi Fo/BTBa3WQywleuIzexUtW8GpAqWA15E2bbZppfZnJT+KnPY3OEqk8g8T/EWMHgIQuKH jAWNhOcPFSukHzmH607zE4E8ovMPBGvrpsBpXQACCuCYoATIfW+1dpGkZ9cBiyuSwArb RPGw== X-Gm-Message-State: AOJu0YwGMdAsVgMBFlpz+ClFZ1b5UN65Q/Zdh4VsfT6zeCnCuLMfoV6g umDMQN/vEOytwxVbMkhMgH67/q/CrLN/J6/sBuY= X-Received: by 2002:a5d:58fc:0:b0:317:6ef1:7939 with SMTP id f28-20020a5d58fc000000b003176ef17939mr4011730wrd.23.1694673484942; Wed, 13 Sep 2023 23:38:04 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id k3-20020a056000004300b0031fba0a746bsm851192wrx.9.2023.09.13.23.38.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 23:38:04 -0700 (PDT) Date: Thu, 14 Sep 2023 09:38:01 +0300 From: Dan Carpenter To: Umang Jain Cc: linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren , Greg Kroah-Hartman , Florian Fainelli , Adrien Thierry , Dan Carpenter , Dave Stevenson , Kieran Bingham , Laurent Pinchart , Phil Elwell Subject: Re: [RFC PATCH v2 3/4] staging: vc04: Convert vchiq_log_info() to use dynamic debug Message-ID: <7ea529c2-3da6-47df-9b09-28d4ab36c4ef@kadam.mountain> References: <20230913185528.770634-1-umang.jain@ideasonboard.com> <20230913185528.770634-4-umang.jain@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230913185528.770634-4-umang.jain@ideasonboard.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 13 Sep 2023 23:38:12 -0700 (PDT) Please rename vchiq_log_info() to vchiq_log_dbg() or something. When I see "info", I think it's a KERN_INFO level. This is all debug stuff and it's done correctly but the name is misleading so it looks wrong. regards, dan carpenter