Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp3867764rdb; Thu, 14 Sep 2023 05:23:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEaQQtam0g8KihAfzaag8HrvcPBQKz6T9cBmO4zbaEBKEX5iaH4fatMnXNlGWOalA0XmB9U X-Received: by 2002:a05:6358:c1d:b0:139:b1c8:a28a with SMTP id f29-20020a0563580c1d00b00139b1c8a28amr5464613rwj.0.1694694181025; Thu, 14 Sep 2023 05:23:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694694180; cv=none; d=google.com; s=arc-20160816; b=UedCV+olOU5X086Cp6sf/Vt85RTYHOktQSndM4LHT1WuHCa5teynxP6X1BHExlUu1j r6jZp3QGtWQJ3V/VTVqZcmKbJiSynrzbQd+F8bXMJ+MnpUe62dM4fgBfpsj/y0YIkQMv XTIsplH2hhN2/6ceiGpA5dVaLgcchJQIoj0krCzF6mR0w32OZsYikwwRZcVpMmklbly3 Cmd+JI0EDPwFQj9ZEzKhuChiwR/EyW/9AHGxOVYHvilI1uZ0sY8y2E0B0wV5bEM+OcmW 38FD4GOCLr/LAMr6KEQP8Fxl+JYrWZKQRrjSkpD/+51LAaxZpLYODcwJyPGcd09z5f9q +ZrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from; bh=sUZdVQEerJxyi90UdNDFCrEbeNx6ud/B3bpuYJ6jaZY=; fh=P7aMOavv5eITLbs4EbgEWTcg3lFlouhqiiKim+4jvYU=; b=FG0U0znvYuWnQvl/uKCEd5jadW6ae3cTsnH0Is0w106w95WFkmiwtJHtREeU4Bb+Id 5UGs7o/vMnirWb4UGr+LZwQRJvQO5xeO51pN/M0EFQ6KpKkR4CqzIn6c8o+TrvX5ZGAT 16++W6hHrYqt7qWVL0FLggPJTFtRu+UPDSwPjyjb58sP0lVRX2s6athLkUAhghFfJlYd 29xEW4EMVhsBElTrO2MZDvY1e6mo5dvMchkBCLzG2OiUq7pe4drCvb+LZMr4Xpk6Pl17 v/FZ02kYSRjl7Un6+kxOW5nen3uPX6QLI0rqtpU6rZ+ORcv39eBPVWmO0WMv0Mh5KH57 wgnQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id r135-20020a632b8d000000b00563ef545828si1446322pgr.8.2023.09.14.05.23.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Sep 2023 05:23:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 87FFF8186518; Thu, 14 Sep 2023 05:22:32 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238426AbjINMWb convert rfc822-to-8bit (ORCPT + 99 others); Thu, 14 Sep 2023 08:22:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234522AbjINMWb (ORCPT ); Thu, 14 Sep 2023 08:22:31 -0400 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 70FCD1FC0; Thu, 14 Sep 2023 05:22:26 -0700 (PDT) X-SpamFilter-By: ArmorX SpamTrap 5.78 with qID 38ECLd5A21169338, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36506.realtek.com.tw[172.21.6.27]) by rtits2.realtek.com.tw (8.15.2/2.92/5.92) with ESMTPS id 38ECLd5A21169338 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 14 Sep 2023 20:21:41 +0800 Received: from RTEXMBS06.realtek.com.tw (172.21.6.99) by RTEXH36506.realtek.com.tw (172.21.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Thu, 14 Sep 2023 20:21:40 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXMBS06.realtek.com.tw (172.21.6.99) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 14 Sep 2023 20:21:39 +0800 Received: from RTEXMBS04.realtek.com.tw ([fe80::7445:d92b:d0b3:f79c]) by RTEXMBS04.realtek.com.tw ([fe80::7445:d92b:d0b3:f79c%5]) with mapi id 15.01.2375.007; Thu, 14 Sep 2023 20:21:39 +0800 From: Justin Lai To: Andrew Lunn CC: "kuba@kernel.org" , "davem@davemloft.net" , "edumazet@google.com" , "pabeni@redhat.com" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" Subject: RE: [PATCH net-next v7 02/13] net:ethernet:realtek:rtase: Implement the .ndo_open function Thread-Topic: [PATCH net-next v7 02/13] net:ethernet:realtek:rtase: Implement the .ndo_open function Thread-Index: AQHZ5Voer1zs1eayP0a8NW2oYFXOS7AYxCOAgAF8KOA= Date: Thu, 14 Sep 2023 12:21:39 +0000 Message-ID: <226589a878f64b5eae3b7ca55936e926@realtek.com> References: <20230912091830.338164-1-justinlai0215@realtek.com> <20230912091830.338164-3-justinlai0215@realtek.com> In-Reply-To: Accept-Language: zh-TW, en-US Content-Language: zh-TW x-originating-ip: [172.21.210.185] x-kse-serverinfo: RTEXMBS06.realtek.com.tw, 9 x-kse-antispam-interceptor-info: fallback x-kse-antivirus-interceptor-info: fallback Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-KSE-AntiSpam-Interceptor-Info: fallback Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 14 Sep 2023 05:22:32 -0700 (PDT) X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email > On Tue, Sep 12, 2023 at 05:18:19PM +0800, Justin Lai wrote: > > Implement the .ndo_open function to set default hardware settings and > > initialize the descriptor ring and interrupts. Among them, when > > requesting irq, because the first group of interrupts needs to process > > more events, the overall structure will be different from other groups > > of interrupts, so it needs to be processed separately. > > Please take a look at the page pool code. > > Andrew Hi, Andrew Do you want us to use Page Pool API in this driver?