Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Date:   Thu, 14 Sep 2023 15:05:22 +0200
From:   Maxime Ripard <mripard@kernel.org>
To:     Javier Martinez Canillas <javierm@redhat.com>
Cc:     linux-kernel@vger.kernel.org,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Daniel Vetter <daniel@ffwll.ch>,
        David Airlie <airlied@gmail.com>,
        dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v4] drm/ssd130x: Store the HW buffer in the
 driver-private CRTC state
Message-ID: <4norb2kxq4uxs3imi3qjxhyxpvnyf5cpl4sg7yyf3ydrykqhfl@cb3w4wstak7r>
References: <20230913052938.1114651-1-javierm@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="dov6lznkfrfwqaip"
Content-Disposition: inline
In-Reply-To: <20230913052938.1114651-1-javierm@redhat.com>
Precedence: bulk


--dov6lznkfrfwqaip
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi,

On Wed, Sep 13, 2023 at 07:29:25AM +0200, Javier Martinez Canillas wrote:
>  static const struct drm_crtc_helper_funcs ssd130x_crtc_helper_funcs = {
>  	.mode_valid = ssd130x_crtc_helper_mode_valid,
> -	.atomic_check = drm_crtc_helper_atomic_check,
> +	.atomic_check = ssd130x_crtc_helper_atomic_check,
>  };

Sorry I didn't catch that sooner, but there's no reason to call that
function a helper.

With that fixed (and feel free to fix while applying)

Acked-by: Maxime Ripard <mripard@kernel.org>

Maxime

--dov6lznkfrfwqaip
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZQMFEgAKCRDj7w1vZxhR
xXIhAP9OFI6JCdZluvIUtxdFCWKErbu4NsjR8lWb+91ICcT0mQEAmOI1mtSwaYXY
8foP5Le4d57nb7aRnPbzxWptxjeoOgI=
=wLxW
-----END PGP SIGNATURE-----

--dov6lznkfrfwqaip--