Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Thu, 14 Sep 2023 15:24:40 +0200
From:   Maxime Ripard <mripard@kernel.org>
To:     Daniel Vetter <daniel@ffwll.ch>
Cc:     Brendan Higgins <brendan.higgins@linux.dev>,
        David Gow <davidgow@google.com>,
        David Airlie <airlied@gmail.com>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        =?utf-8?B?TWHDrXJh?= Canal <mairacanal@riseup.net>,
        linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/tests: Flag slow tests as such
Message-ID: <wnqxfgo7tljhecw2cajoeb3aga3szfen6eohowjrepfqwakka5@pm6a7iaii7fy>
References: <20230911-kms-slow-tests-v1-0-d3800a69a1a1@kernel.org>
 <20230911-kms-slow-tests-v1-2-d3800a69a1a1@kernel.org>
 <ZQAU7Juw5WM1LAAM@phenom.ffwll.local>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="s2sns2gwxynnnns6"
Content-Disposition: inline
In-Reply-To: <ZQAU7Juw5WM1LAAM@phenom.ffwll.local>
Precedence: bulk


--s2sns2gwxynnnns6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Sima,

(For some reason, it looks like your mailer sets up the headers to reply
to every recipient but you)

On Tue, Sep 12, 2023 at 09:36:12AM +0200, Daniel Vetter wrote:
> On Mon, Sep 11, 2023 at 11:51:06AM +0200, Maxime Ripard wrote:
> > Kunit recently gained a speed attribute that allows to filter out slow
> > tests. A slow test is defined in the documentation as a test taking more
> > than a second to execute.
> >=20
> > Let's flag the few tests that are doing so on my machine when running:
> >=20
> > ./tools/testing/kunit/kunit.py run --kunitconfig=3Ddrivers/gpu/drm/test=
s \
> > 	--cross_compile aarch64-linux-gnu- --arch arm64
> >=20
> > Suggested-by: David Gow <davidgow@google.com>
> > Signed-off-by: Maxime Ripard <mripard@kernel.org>
>=20
> Ugh ... not a fan.
>=20
> igt has a really bad habit of making disastrously combinatorial tests with
> impossible runtimes, and then just filtering these out so it's still fast.
>=20
> Maybe some stress tests for overall system make sense like this, but
> absolutely not for unit tests.

I agree, I didn't want to reduce testing though.

> And I did spot check some of these, they're just combinatorial
> explosions with large repetition counts and some fun stuff like going
> through prime numbers because surely that's a good idea.
>=20
> Imo delete them all, and if that causes a real gap in coverage, ask
> the authors to write some actual good unit tests for these corner
> cases.

Ack, I will send a patch doing so.

Thanks!
Maxime

--s2sns2gwxynnnns6
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZQMJmAAKCRDj7w1vZxhR
xWU7AQCec2+TjFtEJCwvBH+eX+OLCselkl5YoaquXV57CrLH8gEApqmPauoZqE05
5F2myjAiz2vFlA78a+oQ1h6+efFs6Qc=
=Lwvb
-----END PGP SIGNATURE-----

--s2sns2gwxynnnns6--