Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <bdc71fcc-2d72-a958-bb52-84f3fabb49cb@amlogic.com>
Date:   Thu, 14 Sep 2023 16:24:18 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH 1/3] dt-bindings: pinctrl: Add compatibles for Amlogic T7
 SoCs
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        linus.walleij@linaro.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        neil.armstrong@linaro.org, khilman@baylibre.com,
        jbrunet@baylibre.com, martin.blumenstingl@googlemail.com,
        brgl@bgdev.pl, andy@kernel.org
Cc:     linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20230914054525.1180595-1-huqiang.qin@amlogic.com>
 <20230914054525.1180595-2-huqiang.qin@amlogic.com>
 <45637012-0972-fc7b-1276-163da363b962@linaro.org>
 <cde944c4-acfe-b3fb-32b8-072740475e35@amlogic.com>
 <ff4f2b93-7e22-8b15-aaad-b7d6f8b5517d@linaro.org>
Content-Language: en-US
From:   Huqiang Qin <huqiang.qin@amlogic.com>
In-Reply-To: <ff4f2b93-7e22-8b15-aaad-b7d6f8b5517d@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RzZaNzJUMUtkY3BKL3cyaDIyTENKbmVETVdoaithRzg5UnA3T2ROckhYZGRS?=
 =?utf-8?B?NFQzd3Iwd3FTSXd0NkUwN2RzNHlFekwwNEVGMWt3VVhhMmYyMnlHekJQeEhu?=
 =?utf-8?B?emJkODA3QnFiMTYrU0EvVVZMM0JVbFZqaFVsYjJ0MWI4OEd3blBxU1dEaWNW?=
 =?utf-8?B?WTRObVBiM0VvMDVNYlFEOEJacGVjazRGVS9oMnJkcnlmZlhsOFhkbmxzNGxm?=
 =?utf-8?B?cGtYYkxXUE5uVU9GRHhyVG1OdytWcFN1bFJROTNTZFE5dGdGcGVzWFZ2czNS?=
 =?utf-8?B?ZzhNamRIS2tLNGc1U3QrZTdrOXEzdzVyQVRKRTRmaFNjS2NWSW9IWmhCOG03?=
 =?utf-8?B?M1VTSlhsVFhwbUV6WFNBZEQwbFV0Z0R5SHhBR3lLNitGVDZncEZRcnJ2amNE?=
 =?utf-8?B?QVV2MzRXOHdFOVJOMklwQTc2MzBsTFF3U3ZaSUxJZzV5TXl5MVE1RFZ5Q0NY?=
 =?utf-8?B?SmViOXV1K3c1cXU3NzJmcjRpaDZoWG5rWUpkY01tQkJRSUE2MkwvbTlQT0U1?=
 =?utf-8?B?dGUzbGFYcmZialRnbitWL2xENDYxeTIrVnhaWmNvcVhwYndoT2VQc3hNTDBT?=
 =?utf-8?B?UHVvbU9wWFdBclQvYmNWb0tkWktESEdsSTdWR0lEVmdtcm1FUmo1WnBQZldp?=
 =?utf-8?B?ZjY3Ri9tZExLcU9jZ0xKWDJIS256VWdqMEVMa2FaTjFEMHVIVWJMdzc3cEhq?=
 =?utf-8?B?SlJpSHRibDl0aVdSU0FncFkrWGQyRkQveFV1VC8yZVMvNnpIVTNLRktWWEo4?=
 =?utf-8?B?dklGV3VHazlvOTNtR2haUlJHNlNoTm51Z3A2cFdCaE82S0t5QWJOS0FKclF0?=
 =?utf-8?B?SmRrekZMVklmaWFnUTIyc2J5dnAvNkhMV2VkMHFmZkN4dWFDSFJTbGFBcSs3?=
 =?utf-8?B?dWl3eHA2UEV0SER6Yy9XNE5iYnU2QlNRVmxpMkJmbWNIWk1IRXp0MEJrM2Nx?=
 =?utf-8?B?SDVIODJMNUJCWXh3WTVFeDdFZWJtcWYxSU94UWViYXJIeVRWMG9PL0RjSTV2?=
 =?utf-8?B?dG1pQUk2T2pBWWlOU2NsbGp2M1VjV0xubklUWldlTFlaTERoM1daYWltUWtK?=
 =?utf-8?B?akJKU2wwSzJFRGxuSWF1WmxzMGtUTXYrT2hCRVpOSlp1NU8wTUcycEFocW9R?=
 =?utf-8?B?RXRsS2VKQk1sTmNnSHcrSVhnOS9FWTk1M0Vjd21MYWcxNGE5RG1oUytyeWZR?=
 =?utf-8?B?LzduSXpHSzVtMmJpWHI1Y1lrR0xMdTRpdVNHVjZ4ci9USWtIUEpTY3d2eERC?=
 =?utf-8?B?ZVhOUWJETytDeThRUjdITUdLZHRGMm92bWNwZFRBbVA1bCtlZUlnZWhsY1Jl?=
 =?utf-8?B?MmNscmFKV05wem1mTVhzdmg5aHdIU3B4UExLU21pbjdZNXdjQmRZeFJ5WXd0?=
 =?utf-8?B?RDNFWWthUDZmWEpkdFQ5ZjVsM01aZXBxNmtHbktLZlY0UGJtNVREZW5WeG5M?=
 =?utf-8?B?UU5QZTJUQ213ZVBvYjJ2VVJTZ0IxcEswN1ZOaTNpSjRXeWY4bnJuTHl1SGNK?=
 =?utf-8?B?MmQxU1hzaFo1elJ2NlljSyt4Wlh6K0c4c1hLd0wrZG1ERDlWdTBFazZjdUJB?=
 =?utf-8?B?VVU4UVNVb2JjU0JNVGthN1M1ZGk3ZEhiYW9GWW1kaktZWjJBL1BSc1dmMWUz?=
 =?utf-8?B?UCsvejhBUTAzNnljV0FROER3SmF2QVhWR1VXSkVYbTRpT0d0M0xOSUQ5all4?=
 =?utf-8?B?NHRaTTFRU1MzU2hoZXVuVUZIZVdab3VjcU15Z1l5S0NETGVkUEUzazQzZzhh?=
 =?utf-8?B?MkdyaHA0dzJDQW1UZGw5TmFjSnUxbkU1Q0lGTS9lZUlYanhlbFFxTGhNTTZ3?=
 =?utf-8?B?aFdMYTY2a2xwR3ZMbHJXSkxwNmMzcGlLcndzdzU5UitWTWhyUThzd0c0SFI0?=
 =?utf-8?B?SkYycXVUd25vVXZnVmtkdUQyRE9PcjF4V05KVDlMSXloM2dVamVva2tKM05k?=
 =?utf-8?B?UzUwenhOQ3lFWlI5K2czeWhrNGM5WU01aU9MVCs5MCtqOU5UYU80ZWRNN2Mw?=
 =?utf-8?B?REVRYUNTQWxVdjFXYmF6WkVndlA4cDFrdUxhQ0trUnkzdlNzR2NFb1hwblZr?=
 =?utf-8?B?eUlpdW1pMEpQOTVRQjJsTlc5bjUwcXAvZlNTcmVBakkwMUNrYmNyUTdCeS8y?=
 =?utf-8?B?UDd3ZUgxZnZjcnFTTUxjeEJtQ0p4c0dyWU8wVWhqeWl5ZUNrYlpLSjZ5WUM3?=
 =?utf-8?B?YUE9PQ==?=
X-OriginatorOrg: amlogic.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 06ccea7c-7446-49e0-c6aa-08dbb4fc00ec
X-MS-Exchange-CrossTenant-AuthSource: SEZPR03MB7220.apcprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2023 08:24:25.2087
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0df2add9-25ca-4b3a-acb4-c99ddf0b1114
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HQicvrZx353I+PO/2BMWDcI5jEGfWYisFf+oKxbRnviWCU9qTmLnM3DXer4H2xYEqXl5zES1POiGR/6kIuOekg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR03MB5555
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 14 Sep 2023 01:25:29 -0700 (PDT)
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email

On 2023/9/14 15:19, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
> 
> On 14/09/2023 09:00, Huqiang Qin wrote:
>> Hi Krzysztof,
>>
>> On 2023/9/14 14:16, Krzysztof Kozlowski wrote:
>> ...
>>>> diff --git a/include/dt-bindings/gpio/amlogic-t7-gpio.h b/include/dt-bindings/gpio/amlogic-t7-gpio.h
>>>> new file mode 100644
>>>> index 000000000000..2bab9a99501a
>>>> --- /dev/null
>>>> +++ b/include/dt-bindings/gpio/amlogic-t7-gpio.h
>>>
>>> Use compatible syntax.
>>
>> The amlogic-t7-gpio.h is not a file in the dt-bindings/pinctrl/ directory.
>> Does it also need to be named according to the compatible name of pinctrl?
> 
> The convention, which we introduced since ~1-2 years, is to use the
> device compatible or binding filename as the headers filename. Now,
> where you put what does not affect it.
> 

Okay, got it, I will modify it in the next version.

Thanks


Best regards,
Huqiang Qin