Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
From:   Zi Yan <ziy@nvidia.com>
To:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        linux-mips@vger.kernel.org
Cc:     Zi Yan <ziy@nvidia.com>, Andrew Morton <akpm@linux-foundation.org>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        "\"Matthew Wilcox (Oracle)\"" <willy@infradead.org>,
        David Hildenbrand <david@redhat.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Muchun Song <muchun.song@linux.dev>,
        "\"Mike Rapoport (IBM)\"" <rppt@kernel.org>,
        stable@vger.kernel.org, Muchun Song <songmuchun@bytedance.com>
Subject: Re: [PATCH v3 4/5] use nth_page() in place of direct struct page
 manipulation.
Date:   Wed, 13 Sep 2023 22:45:31 -0400
Message-ID: <89146F73-0D9C-474B-96CA-24B085CA46C9@nvidia.com>
In-Reply-To: <20230913201248.452081-5-zi.yan@sent.com>
References: <20230913201248.452081-1-zi.yan@sent.com>
 <20230913201248.452081-5-zi.yan@sent.com>
Content-Type: multipart/signed;
 boundary="=_MailMate_D2740B76-B33B-4B36-8B8F-6040E8CF87A0_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fvg5M1UwNz6iURBR3OVTpZ6l4YQrR6YCbFvprfMdQPE5z640laiO+HkMxIrS?=
 =?us-ascii?Q?IkZ3Qg7Er80jX2OOKvSJ07MGdZgvqxk23FHYZqwrOXLgoI+kfV8mmUZQL5hz?=
 =?us-ascii?Q?ny146yKHva0Q8kiCHtXIydK4YGeRvdybSQuhV4Aujy3ycd+HvNemUcV3PL7o?=
 =?us-ascii?Q?jgQZMipRZ6/ZnPlfI/7FWi6hu7HdONaaXhJNmBItCyP59bGhN8+dToSF7edZ?=
 =?us-ascii?Q?r7hfuAyq5QqoIKUpu1oGQhBz5XmO8tzsPvnr9OOqJqwCD5qGNGo7T6cMQmxR?=
 =?us-ascii?Q?bcJ/ZMr289fV9q1M9blwc7QIUIC9Ra0xkQlOLtOKIhnjFLh+CbGaLLqByLLU?=
 =?us-ascii?Q?RZERbvshlb2K/bb31+bs75lxSc78/F0WpamYb13gxRrgML4bbx52vfglw9vp?=
 =?us-ascii?Q?f0y1KZ4VHkswjJ+vTAsYgoKvYlVdxo/fQsdUuMXGq/CbgQfUSF50rJyQsE97?=
 =?us-ascii?Q?VvPMaGwW0ia44eXGhWQ8ZzTx491NDxGP2DOWrXw643f1ZoLlZTD6X56FIoeD?=
 =?us-ascii?Q?hfb+Mj8F9Y6hIN+Mj0pd4rlVXQ+RVP4RNvBW1maJxCxsS5M15lJkgC6jAXf3?=
 =?us-ascii?Q?+G2aKqr5CkxOep/AqHYFbkzdJCsJhH+0B4RCLIo40ln6CpNoicdmVDDqdr+7?=
 =?us-ascii?Q?ElgAxsZs2aHmIFE5PcH1PULFg+pLeFSVUEf800nUQBnXfvHJMplqM7zIwWZ/?=
 =?us-ascii?Q?76Lqbb+E4JNCzydF+rmHqA58E9Ks+Nyp0wppwK9d3L9WDuO9LQWiXyufGYwc?=
 =?us-ascii?Q?e7ubsVpeep1td2e3Fkj6cbV+MsrPjs/vldhDn+xrhCSfhYy/961GPE+XWVeW?=
 =?us-ascii?Q?/B0t24UppYCY9vYT1AVM4kGgyRBQXt8PjS3GaJQBwG+o5DYi9430ugkVU7Nx?=
 =?us-ascii?Q?IY5oAxv6H9Z9vIR90btouMtmZ40IkHAXs/utlL44/jvKxYZkGxV97nrcFith?=
 =?us-ascii?Q?hyk6I/PaaraBOUEjDepGC+uhMlnxBfMJ6oo1/LeGmaHpJC1Ft2UeLITS3fcI?=
 =?us-ascii?Q?gCQoEUzpqHkFLcKRQdXvbi5Zxu3SRf9WdcWLUDkUjNEayOHZE7ntMI5Ezjgr?=
 =?us-ascii?Q?Uz4EEmoesvDUAjIonhGrxhsO+vJhaVpu/M/AXH9yP7q1n75z9caQNvLamuN/?=
 =?us-ascii?Q?LdHVJod0a+48rC3PlU4UMqN5wNjksL20T9LB2L0oJI64igNQWQiHfemHNL8H?=
 =?us-ascii?Q?FZIiTFcO0buRVeFRMr8vFSSFwT15CfNAS0ZQ696l7wO9GHu8ydi9XrhISUpI?=
 =?us-ascii?Q?+26vnLoyL4fHo5PSVsgjjwbQdCD1KcLqiPXWfFtVj3goObiLSHWCQ+C7hFjB?=
 =?us-ascii?Q?ls/+QFgfijj0OZ0cu3Cw0wigvtyhQ/dOHEiApK30PCkjm79tZlcGuYkKcwHN?=
 =?us-ascii?Q?J7VCHna1sW4AicMmpEB3QftsA3y8u49i7fKQmOUXtaB1VnBQWiN0W2eY7/iK?=
 =?us-ascii?Q?X53tH+ditfROsiUTKYv3UjmyDdKFeYq2KWlBGGaipWeFEfaeHEpiPnpetnPz?=
 =?us-ascii?Q?wI/rT32ScASR/J18sSQ19ap3/XSZJb2pNodHL6QsdkVdElx/5Qmu1Jww9X69?=
 =?us-ascii?Q?4r3HMK0yC/mKmYGj/sCXjarWveUHFRrvDfuTnttA?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6574e3a3-d87c-4aa3-c305-08dbb4ccabc3
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2023 02:45:35.2172
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: i3DZG8/H2A4lRQLCnF2Md7WL1w6orSD5gxpoObs32w74Sk6ZzAsv6uvJRHIx8Wh1
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8718
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 13 Sep 2023 19:45:47 -0700 (PDT)

--=_MailMate_D2740B76-B33B-4B36-8B8F-6040E8CF87A0_=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On 13 Sep 2023, at 16:12, Zi Yan wrote:

> From: Zi Yan <ziy@nvidia.com>
>
> When dealing with hugetlb pages, struct page is not guaranteed to be
> contiguous on SPARSEMEM without VMEMMAP. Use nth_page() to handle it
> properly.
>
> Fixes: 38c1ddbde6c6 ("hugetlbfs: improve read HWPOISON hugepage")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Zi Yan <ziy@nvidia.com>
> Reviewed-by: Muchun Song <songmuchun@bytedance.com>
> ---
>  fs/hugetlbfs/inode.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
> index 7083fa0caaab..14d3d28e41b0 100644
> --- a/fs/hugetlbfs/inode.c
> +++ b/fs/hugetlbfs/inode.c
> @@ -295,7 +295,7 @@ static size_t adjust_range_hwpoison(struct page *pa=
ge, size_t offset, size_t byt
>  	size_t res =3D 0;
>
>  	/* First subpage to start the loop. */
> -	page +=3D offset / PAGE_SIZE;
> +	page =3D nth_page(page, offset / PAGE_SIZE);
>  	offset %=3D PAGE_SIZE;
>  	while (1) {
>  		if (is_raw_hwpoison_page_in_hugepage(page))
> @@ -309,7 +309,7 @@ static size_t adjust_range_hwpoison(struct page *pa=
ge, size_t offset, size_t byt
>  			break;
>  		offset +=3D n;
>  		if (offset =3D=3D PAGE_SIZE) {
> -			page++;
> +			page =3D nth_page(page, 1);
>  			offset =3D 0;
>  		}
>  	}
> -- =

> 2.40.1

Without the fix, a wrong subpage might be checked for HWPoison, causing w=
rong
number of bytes of a page copied to user space. No bug is reported. The f=
ix
comes from code inspection.

--
Best Regards,
Yan, Zi

--=_MailMate_D2740B76-B33B-4B36-8B8F-6040E8CF87A0_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmUCc8sPHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhUlzYP/iEUlKNBgw1pGQNs9IkwZRK4fy9+7IOGYtga
FWDfxNGRLWq340UpU15iE7b155YNQX62Bm9axKBOAPouaZ+ZnXruJThEdPsoPeDc
Ru36wfb1UsYY9h/p7S4WNk+R/OS6D5jwOKDoFzA1bdUw6dP7hwI66Nv5McvOnl9f
5qRR7WpniAcxd3kvFD2yAPbej1vBOlNp6CNsxqAn8mJFxdEOqJTdSABmIRhSxSR5
mzfcPasuzUhehPwMW3PMa5lt1t6OZuxrtFXtX2FDstn0WDFzvXON5Z35K+PlmihP
ezSNhCMyogFRmj/E5qK6kcxIVobAAxAyHjBlzkPH4rr29IGOF3D2dKe9YvjXOlhM
MCneJm3ytm8jD91oX1f33sGF3VOckoVXGZy8DHZHkvpMShj5/0cyGtVb9X44pJu2
xr0lWbg5KI9bQcHX245GZn1g0k0XGCiis0qX8gYniyh1x3qGUDM4jydV66eq3wEJ
6DMBgUrB//FRjZf5Z763/JU79IW1fL6muCTfVJm3oMFSkmz+FxESDInmguluqGpk
wlqRFyvw2iurDY+YekHN9Xmy0RSmkTtY5XP0/zZqliDR8F6GLE6VZcKZVJ5pi6FJ
W0kURFrrMnKvY5jM04fReG1T22D1Gvr0VZ4YOYlIXiwichs1kRyk+tYf2/l/5exQ
ymjtYrU+
=vFdC
-----END PGP SIGNATURE-----

--=_MailMate_D2740B76-B33B-4B36-8B8F-6040E8CF87A0_=--