Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <cde944c4-acfe-b3fb-32b8-072740475e35@amlogic.com>
Date:   Thu, 14 Sep 2023 15:00:45 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH 1/3] dt-bindings: pinctrl: Add compatibles for Amlogic T7
 SoCs
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        linus.walleij@linaro.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        neil.armstrong@linaro.org, khilman@baylibre.com,
        jbrunet@baylibre.com, martin.blumenstingl@googlemail.com,
        brgl@bgdev.pl, andy@kernel.org
Cc:     linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20230914054525.1180595-1-huqiang.qin@amlogic.com>
 <20230914054525.1180595-2-huqiang.qin@amlogic.com>
 <45637012-0972-fc7b-1276-163da363b962@linaro.org>
From:   Huqiang Qin <huqiang.qin@amlogic.com>
In-Reply-To: <45637012-0972-fc7b-1276-163da363b962@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RHZTS1JGUHZLdmdUdDNjSDE5ckZrWmtjZ0lhQWNDR3lKU1ppWlQxeGlKY0ZR?=
 =?utf-8?B?NlgrWGlyZkFTOTl2SDBtR0Z1U2FZalViaXNOeEM2dnFtTG9wYWhubDVRNC93?=
 =?utf-8?B?amxubVljRnk2WU0xek16WDMxS2ZYNmFGdHpCei9KdXNYZWlVT0Q1dnRyU043?=
 =?utf-8?B?MW5UVU0ydm1UYnkxb1dMQXhYUVc0U0RlUEovb3N0c1QvNFlwSE8rRXlkL01q?=
 =?utf-8?B?UCtsc1MwOVowV1VtczBUdHlrV0RZL09IS1ozMGpweE9YUFhIYnlYdFFmNytU?=
 =?utf-8?B?a0JjaFduVVI1QjhHeEszSXVEUVpmMm45YUVQMEpHZnlQWkF3b2cvSS9YOGVG?=
 =?utf-8?B?WkxjYkpGMTU1YVd3bEFFbEcvdFA2NFdwMmZiMUlDWFBWZjRWWU9XbDhFYVpR?=
 =?utf-8?B?OEVSVURsV2Y2TW8wQWI1NTZvR1oybHVpaCsvOEI0SEJvWkVNS3RueVlvYXRK?=
 =?utf-8?B?b2Z3cUZ3OU1zRjRvd1E2clVKTjY4OHBWMjdvWk5zdnUyenVEVmhlTUpsR0RD?=
 =?utf-8?B?ek1vL2FNNGhwL2UzZzQ3MWVuZWhiait0eWJaR0lVSk93eGJQYS8yWXkraHlx?=
 =?utf-8?B?MnRTVGpJT2p0dFcyV1lmbHllR1VGVUkyUFNpdlhUSU5DYzdLL0ZIbE1sdGU2?=
 =?utf-8?B?cVlUd0dpVTdja3hHV2lpUHZJUzNwT1c3YjFIQ1F3WXdyUm9NbzVKL1UzeHM2?=
 =?utf-8?B?UFNmbUltQUZucnpvVDBIa1RsY2pOdGlqMDY4MCtpdTRDSzRwcEZPSDdVa0lZ?=
 =?utf-8?B?cjVVWmY4TTBIYk5OK1RrSWlzZEMrV203bGZZOWlNN2FIUStNbUZLVkFkZ1E2?=
 =?utf-8?B?SHlJcTMvTC9rcThNRllCNnZ1T0JqalZxV3RVZWM4OWc0elVxL0ZRa29JZ0hr?=
 =?utf-8?B?K3NDcTBxZVcxM2pKaE1JYUxpV2tpeHgrOGIwaXRDRjRvWWw3RjJ4RlM3TzRO?=
 =?utf-8?B?OFBtdmZHb0RUYTJObFRkeC9QRTArWTQvQm9VZEovRkRXZWdxYm9GWSs4MDVy?=
 =?utf-8?B?OVF2U2p3R0QwS1RpcmQvSFZKMWQ2T2xsWXRsZzI1OUxWeGNDU1UxdFJLVVF0?=
 =?utf-8?B?WkRnYStCMUZuT3kyM2JtMk5zOCszQ1pwbGNPUEt0djlsRWQ5MXJIak1Oajho?=
 =?utf-8?B?NTA0bE1Ya05mMUZucUpWY0Q1ek9DMXgwLzV5V3hoKzk2eThCaWJpcHNkaHB6?=
 =?utf-8?B?WngraXRndGVHaEV0WWRQZ1dTV3lwMVU1bzdYNHV2WW1IVzdTT1F4QzBTZVRQ?=
 =?utf-8?B?UGV5M3FiWTU0MFc2YW1XdHIxV2ZDUmgyQWI1d29EeXp5emlJNFZJdTFqbFJ4?=
 =?utf-8?B?OWNFZWlYbE9iVWNSL3F0ZmlWUXU2a2JYZjkvQVhqaWM0RnpkUFZkYktMZ2tB?=
 =?utf-8?B?UncvOXJlVFBRL0o2RFN0WDVhUnRMenk3UWxsNGp0M2NkZ3NvdktBR2dKbTJy?=
 =?utf-8?B?SEVVcGVwclBiZGcwYlowd01vUlJPMmx5SmJwR25wd3p3OXdEOXhhQWFicksy?=
 =?utf-8?B?TllVeHVCM0tNMms3RnRuQ20vVSsveXB6VkIxSWttMU9FTjBvcFJXTEJwODF0?=
 =?utf-8?B?RFpEaDFTKzRUNHo5QUdlemhldTltNzZvVWhPVWdTdFlBWWR6NkN6bnlkWFds?=
 =?utf-8?B?L05pT3U0UmdpNjBlZklhYTEwVHk4cU1vUkhodFplZVd1dUw1MFN0UUZvd1ZV?=
 =?utf-8?B?RVU4TEkrM0RYTXlKMGNSNTFRQXhjZUxPdVNJakhXNjI4dFEyREhGd3VSOWU5?=
 =?utf-8?B?Y2NIWjVtVTAvMUMzeGcvN3FmWEtkWXk3RWlzQytmdm45RHc5ZjEzQ2hLVGxa?=
 =?utf-8?B?aEQ3NEFKRnJwdTVMMlM3L3NrZTdVV0tDTzViYy92M0ovUUU2ZUVpRGhIdC9K?=
 =?utf-8?B?aW1UWXlucEMxVk85NWp5bG5MZk5TS2EyTVlDTHRlampxdWxta0ZiVWRpSEp1?=
 =?utf-8?B?aUZiSUVlWWwzWmtBcFNrbm5xTFN2b3duU3FKWXBUVFkwMGZaR25FWHdrbHVn?=
 =?utf-8?B?bHIyaTkzV09Ca2Y3ZUlyY0pNL25iRzd6d1R3Vk1jYitVTy9TQnlJUS81bVd0?=
 =?utf-8?B?WVExcVR4RUFheXcxbmJwQm1ZMHhQekdEcENwd1lSQ211TFd2UlF2MjJQSHBv?=
 =?utf-8?B?L0k5YlNOV2wvUytxUUZSUG9ValZWb05uNEJQdTFYN2QwRTVYR3A5a3l6Y0t5?=
 =?utf-8?B?Ymc9PQ==?=
X-OriginatorOrg: amlogic.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 58bf06da-03ca-4de7-339e-08dbb4f0649c
X-MS-Exchange-CrossTenant-AuthSource: KL1PR03MB7221.apcprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2023 07:01:18.9562
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0df2add9-25ca-4b3a-acb4-c99ddf0b1114
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aLBY1AC9Pbr5xpVVLixxNJX6efRwzGfKRKrkfy8T06BOJ9FX3vCWxtLIEl167y+aoO/DbBrFb6rJXVy0IeJedw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR03MB5295
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 14 Sep 2023 00:02:34 -0700 (PDT)
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email

Hi Krzysztof,

On 2023/9/14 14:16, Krzysztof Kozlowski wrote:
...
>> diff --git a/include/dt-bindings/gpio/amlogic-t7-gpio.h b/include/dt-bindings/gpio/amlogic-t7-gpio.h
>> new file mode 100644
>> index 000000000000..2bab9a99501a
>> --- /dev/null
>> +++ b/include/dt-bindings/gpio/amlogic-t7-gpio.h
> 
> Use compatible syntax.

The amlogic-t7-gpio.h is not a file in the dt-bindings/pinctrl/ directory.
Does it also need to be named according to the compatible name of pinctrl?

> 
>> @@ -0,0 +1,179 @@
>> +/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */
>> +/*
>> + * Copyright (c) 2023 Amlogic, Inc. All rights reserved.
>> + * Author: Huqiang Qin <huqiang.qin@amlogic.com>
>> + */
>> +
>> +#ifndef _DT_BINDINGS_AMLOGIC_T7_GPIO_H
>> +#define _DT_BINDINGS_AMLOGIC_T7_GPIO_H
>> +
>> +#define      GPIOB_0         0
> 
> Why weird indentation?

Okay, I didn't observe it, thanks for pointing it out.

...


Best regards,
Huqiang Qin