Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp4008249rdb; Thu, 14 Sep 2023 09:05:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFWjD9f5VIzFrb/GZCi6AJK/EshO9prdMF8FHAvUqyKFM5CM8F/Z3ksOgtGtCLydesGTuLS X-Received: by 2002:a17:902:7d89:b0:1c1:f1db:e86d with SMTP id a9-20020a1709027d8900b001c1f1dbe86dmr5538151plm.7.1694707543652; Thu, 14 Sep 2023 09:05:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694707543; cv=none; d=google.com; s=arc-20160816; b=h1EEIoU47uNLuoEoBqNIE4VrUZBJ/iY35mVLkcyNqZXiUE5kOGKeL+HZO1vom/M7ue 7rOWPjMrRmvFB93KM8cxtPcAfDcBKktj3tuTS4JpeKhtBU8/jqd+6G6OLufKyLSuy2GY w+xKf2xYZP6m00XXa/4gGooo2xYImVSL+yOpqHWosLPjkOhSJGLKuVuEcOGQMdROSIOr D82tjqkisPvaRZ5uWJTaPAwfe3qz5YI999eKOEpQNd71RKwBlscnwtsJVbEe4JbSAGTO 9zDBim52S2NEt87VYLfJdT97vDMYlFrXMco/hWXVfwyFwruBDET5CsH3jeDvgNsbzqZN HI2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=NIxqE6FO3o0CdOEr4cjgDYr7N/uQ/DrL4AkGZwEHTu8=; fh=gItNRXpuof63wgbjwWpvDX+zPsOcLTt3XO2EkxQVxAQ=; b=Ea92aX3Mr4+IT3fA/uD5MSzL/W5oMDj7J5/6LpdVzwXBAoEEYl8k+SpBB4vF8vVYRv 57Ks9KzOu42CcG3UclqMbbzjYcwXL9CLt+3S2gAa8ZYcr2T69CCDtV77R8L2/qVhoTL3 TDtVJF3ogD+TaEFTxahI84L6qpWkjS+O5fHt6m8ESOOt3fuy9+rVKb4oouEw/oPCL0bJ 3CLkYk0+hnq4fJXhWgAgZW9ofAUwCwB3V0GmHc3a2G+StBqcdq7fD3uB3wkkQgCALHA+ aS2oIjddeGp9ITAn/dNQgzVoWt3LFw/6sicyWlBEXTLkKfhPlXCQC+/48maMLC7+WRgY AB+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=hn2YVqcb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id n1-20020a170902d2c100b001b811261289si2087501plc.482.2023.09.14.09.05.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Sep 2023 09:05:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=hn2YVqcb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 8B1D08075914; Tue, 12 Sep 2023 15:15:59 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234813AbjILWP7 (ORCPT + 99 others); Tue, 12 Sep 2023 18:15:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234111AbjILWP6 (ORCPT ); Tue, 12 Sep 2023 18:15:58 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC4D510D9 for ; Tue, 12 Sep 2023 15:15:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=NIxqE6FO3o0CdOEr4cjgDYr7N/uQ/DrL4AkGZwEHTu8=; b=hn2YVqcbHWqeqqP7MmMWcU3nEn 0el62pWkKyH9Fwy/jU8ypzwa2Zp5VRK2ogfpTiRd+97hTCnzI1Qy6edA4E7+Ca6aKmANUpPI2JqRl lRiw2GAD+hFW201bCqdYgMy9UQCjuX6tufNX5FeuCEIEPXe5wWScQ+994znoQyk+C8eZxc3RzfOwk MV7ADONj34KUhicu/sDg7cai3DXZRPO5k9lNtibLjYI2jraLtcFepWJt8hdPbI3VzPq7Yjeulkwwp SYLPd7Z18+PxVrV1BrBJBllRScDQ40EsCG2Wptn+Cqc/4Tb35R+BBb6/XK9//iLQr68piTe6T3pPf 3BskT9jA==; Received: from [2601:1c2:980:9ec0::9fed] by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qgBfi-004B9h-0V; Tue, 12 Sep 2023 22:15:50 +0000 Message-ID: Date: Tue, 12 Sep 2023 15:15:49 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] soc/aspeed: Add host side BMC device driver Content-Language: en-US To: Ninad Palsule , joel@jms.id.au, andrew@aj.id.au, eajames@linux.ibm.com Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org References: <20230912220923.3701688-1-ninad@linux.ibm.com> <20230912220923.3701688-2-ninad@linux.ibm.com> From: Randy Dunlap In-Reply-To: <20230912220923.3701688-2-ninad@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 12 Sep 2023 15:15:59 -0700 (PDT) Hi, diff --git a/drivers/soc/aspeed/Kconfig b/drivers/soc/aspeed/Kconfig index f579ee0b5afa..8a4f096d84cd 100644 --- a/drivers/soc/aspeed/Kconfig +++ b/drivers/soc/aspeed/Kconfig @@ -52,6 +52,17 @@ config ASPEED_SOCINFO help Say yes to support decoding of ASPEED BMC information. +config ASPEED_HOST_BMC_DEV + bool "ASPEED SoC Host BMC device driver" + select SOC_BUS + default ARCH_ASPEED + depends on PCI + help + Say yes to support PCIe based VUARTs from the host side. The end to + end VUART communication between host and BMC requires BMC side driver + to activate VUART functionality. This is a driver for the BMC device + on host. ~~~ Please clean up that indentation. Consistently use one tab + 2 spaces, as documented in coding-style.rst. Also, can this be tristate instead of bool? If not, why not? Thanks. -- ~Randy