Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <539752971c7a61ce7a5deddc1478686a.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20230913175612.8685-1-danila@jiaxyga.com>
References: <20230913175612.8685-1-danila@jiaxyga.com>
Subject: Re: [PATCH] clk: qcom: gcc-sm8150: Fix gcc_sdcc2_apps_clk_src
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     danila@jiaxyga.com, adomerlee@gmail.com,
        linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org
To:     Danila Tikhonov <danila@jiaxyga.com>, agross@kernel.org,
        andersson@kernel.org, dkatraga@codeaurora.org,
        konrad.dybcio@linaro.org, mturquette@baylibre.com,
        quic_tdas@quicinc.com, vkoul@kernel.org
Date:   Thu, 14 Sep 2023 09:20:50 -0700
User-Agent: alot/0.10
Precedence: bulk

Quoting Danila Tikhonov (2023-09-13 10:56:11)
> Set .flags =3D CLK_OPS_PARENT_ENABLE to fix "gcc_sdcc2_apps_clk_src: rcg
> didn't update its configuration" error.
>=20
> Fixes: 2a1d7eb854bb ("clk: qcom: gcc: Add global clock controller driver =
for SM8150")
> Tested-by: Arseniy Velikanov <adomerlee@gmail.com>
> Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
> ---
>  drivers/clk/qcom/gcc-sm8150.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/clk/qcom/gcc-sm8150.c b/drivers/clk/qcom/gcc-sm8150.c
> index 41ab210875fb..05d115c52dfe 100644
> --- a/drivers/clk/qcom/gcc-sm8150.c
> +++ b/drivers/clk/qcom/gcc-sm8150.c
> @@ -774,7 +774,7 @@ static struct clk_rcg2 gcc_sdcc2_apps_clk_src =3D {
>                 .name =3D "gcc_sdcc2_apps_clk_src",
>                 .parent_data =3D gcc_parents_6,
>                 .num_parents =3D ARRAY_SIZE(gcc_parents_6),
> -               .flags =3D CLK_SET_RATE_PARENT,
> +               .flags =3D CLK_OPS_PARENT_ENABLE,
>                 .ops =3D &clk_rcg2_floor_ops,

In what case are we getting the rcg stuck? I thought that you could
write the rcg registers while the parent was off and switch to that
parent if the parent isn't enabled and it wouldn't get stuck.