Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
From:   "S.J. Wang" <shengjiu.wang@nxp.com>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        "abelvesa@kernel.org" <abelvesa@kernel.org>,
        Peng Fan <peng.fan@nxp.com>,
        "mturquette@baylibre.com" <mturquette@baylibre.com>,
        "sboyd@kernel.org" <sboyd@kernel.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>
CC:     "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>
Subject: RE: [PATCH 0/5] clk: imx: imx8: Fix some error handling paths
Thread-Topic: [PATCH 0/5] clk: imx: imx8: Fix some error handling paths
Thread-Index: AQHZ5vVuJ1bkWufps0KPYlMW4So/JQ==
Date:   Thu, 14 Sep 2023 10:22:57 +0000
Message-ID: <AS1PR04MB92641B7B3944C2CF9F3DA3B3E3F7A@AS1PR04MB9264.eurprd04.prod.outlook.com>
References: <cover.1693126687.git.christophe.jaillet@wanadoo.fr>
In-Reply-To: <cover.1693126687.git.christophe.jaillet@wanadoo.fr>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5Gf6n21D12/hTdrfi2VS7XmildQMzXyLBfwzCi4RsA/jYQx95fRy0bH3MhW5?=
 =?us-ascii?Q?Spyb/k/aXHLoimFUdYPmCRH7vMu/vpXzFofADAPtaPzbVPTf4Da6STYUYJjH?=
 =?us-ascii?Q?KFH10NX20CbgVhU/HPFpUP53TpBwxvFE8WZr+PRdlVQG+aehbjTwNw15uBYC?=
 =?us-ascii?Q?w1GzxI48DJ0KSXeti7a6vbi53BZrOUZsXDsuc48Yn0Yowpw7Qo6gU1UiimK9?=
 =?us-ascii?Q?gpuyYiT6AY2aJAdqSFeydvdsMpgT5inTZvIwk/+b2IEM6+dFsKrQoeuUt/Nx?=
 =?us-ascii?Q?PCg0HX0CH5yGDW8JNvZhi3tWvGY7egFaMmda+y0JfVvYqyNrXtsIBXWkxktt?=
 =?us-ascii?Q?rtkrnZyNil2MU4TsR7hW03gA8+u7N5XW8UeYk60WLNx+IL0P6eCZq3fwDio+?=
 =?us-ascii?Q?yc8nBoac8YlOftVTws0vDkAUiNVOSKtV34i9DsVByAUASeJuP+I+i4Svgw5Z?=
 =?us-ascii?Q?dZnWaIkefvC4n9zZ8a0YvUUU1Ka7PVznBHDFGsfXFdcTxTAhNFpZSKjyYtRj?=
 =?us-ascii?Q?/jOlxy2ZHW8w+bIDfrIcyFBD4Wfv4IVE6kfqbCrZ51wfs7dii+C+rOPlXqwR?=
 =?us-ascii?Q?nbqI4KZunhW9anRMTDG2PmKH0E41l/7b63Klyv7iaJMw4cCMuP5w2tcQQIu+?=
 =?us-ascii?Q?lyk+J6rl9OOwSEroW3kxGJhd/r9cOnRud3/l0CCzjqrOlq/ILCg89OYo4b/r?=
 =?us-ascii?Q?/CCfiHy+MY+cxcLYBveC/LrQ/lug3lcw+BZTkU9uBHuiMZnUQQ7vkTZWEwUU?=
 =?us-ascii?Q?Jq7uZ0JUW4lafhrXUZ1j5ido6xfI+2Fn9HQ3BA0q5ax1RxFjhHaxlve5gxWm?=
 =?us-ascii?Q?1wyG4PFrcca4ASKu78SQ0fDEAtO6hXMbIqc6TLOJjgwJ50Al2SWtdy1JKf3c?=
 =?us-ascii?Q?mRry7TCU0N0BnEMZ1bsy5VNiMJlNdbtnad8idQdHaedYxfJpT4vriXGmhVWQ?=
 =?us-ascii?Q?A5YFeo2QUbcjjGMU8lD4vKi7oroqEk8m9sCHqSpbgCfGsgwhD5A9ZQU5jK8l?=
 =?us-ascii?Q?PpBaoXukbtvKn7F4DnWVAflpKyEMT+g5b1voH0scD7QRmGWD6CvfrL1LNPbn?=
 =?us-ascii?Q?phkamSsGUc0/Bc74J3fwLgNU5VUMekE3t+f5t0Wknh95ORPU7UfHJS1UQbgp?=
 =?us-ascii?Q?OHp2FZ3fL2BRFrqskY93rOCt1a/dgFkI8atPWcMksycw/J+tEVSwInPwASmm?=
 =?us-ascii?Q?b/2/PGqXS2pRt1pFXbllX9g0pR0Xl/miL/isuQHTzpTOAOINp74KlUSondY7?=
 =?us-ascii?Q?Q2rE1uFGdcMrZNAJnTFdoK84CHCyju2tRKlKfVC+wJD/Wv6dP9a3GSS8PU0L?=
 =?us-ascii?Q?XqrAtXoCaCvLayCMrpyC498sYh3pohAPFwN0FAGVua9cozvUm+c+jWyNgJgE?=
 =?us-ascii?Q?kMjSm1XVv5H8cgS7STY/rZPJ1oj6pcHduqNqoaUTD5fQBi8PNvOoEv+ASC6b?=
 =?us-ascii?Q?3fnXHisEhIVU8g20I6TWN21ovwF7ZWYqH3HoEuLheKsT5gRKmmTF7R/zymQI?=
 =?us-ascii?Q?V6p5sWYAclWWXMr4Q4qOpYepMuI3yDYjTH76ob1aN4SfFO+HYmCBIXNh21Wp?=
 =?us-ascii?Q?XcvTOOvhgKh/1WHcQGr/cvHYVztXnNqxKUg+bdQb?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AS1PR04MB9264.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4d004c07-64ce-497c-bc94-08dbb50c90d7
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Sep 2023 10:22:57.7163
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: uE5PnIvHCXUh3hp0MRrkQ5fcPmt2Hixlqo1ILQFyK9Ct8H78BJysg3jkBzRAplsONqCRdDf38BJZduHYIhjcew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB9803
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 14 Sep 2023 03:23:14 -0700 (PDT)
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email

>=20
> This serie fix some error handling paths. It is split in different patche=
s to ease
> review because the issues are unrelated and the proposed fixes are maybe
> wrong (I don't have the hardware to test anything)
>=20
> Patch 2 and 3 are more speculative than the 3 oher ones. Review with care=
.
>=20
>=20
> Finally, I got some problem when generating the serie, and some patches
> have been hand-modified afterwards.
> They look good to me, but I hope have not screwed up things...


From the 3rd patch,  it can't be applied, maybe there is generating issue.

Best regards
Wang Shengjiu

>=20
> Christophe JAILLET (5):
>   clk: imx: imx8: Fix an error handling path in
>     clk_imx_acm_attach_pm_domains()
>   clk: imx: imx8: Fix an error handling path if
>     devm_clk_hw_register_mux_parent_data_table() fails
>   clk: imx: imx8: Fix an error handling path in imx8_acm_clk_probe()
>   clk: imx: imx8: Add a message in case of
>     devm_clk_hw_register_mux_parent_data_table() error
>   clk: imx: imx8: Simplify clk_imx_acm_detach_pm_domains()
>=20
>  drivers/clk/imx/clk-imx8-acm.c | 27 +++++++++++++++------------
>  1 file changed, 15 insertions(+), 12 deletions(-)
>=20
> --
> 2.34.1