Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Date:   Thu, 14 Sep 2023 18:53:11 +0200
From:   Larysa Zaremba <larysa.zaremba@intel.com>
To:     Maciej Fijalkowski <maciej.fijalkowski@intel.com>
CC:     <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>,
        "Daniel Borkmann" <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        "Martin KaFai Lau" <martin.lau@linux.dev>,
        Song Liu <song@kernel.org>,
        Yonghong Song <yonghong.song@linux.dev>,
        John Fastabend <john.fastabend@gmail.com>,
        "KP Singh" <kpsingh@kernel.org>,
        Stanislav Fomichev <sdf@google.com>,
        Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf-next] bpf: Allow to use kfunc XDP hints and frags
 together
Message-ID: <ZQM6dy80CMl2AVzJ@lincoln>
References: <20230914083716.57443-1-larysa.zaremba@intel.com>
 <ZQM293Gdx//GQPzA@boxer>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZQM293Gdx//GQPzA@boxer>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?EA19Eqcav/ynB7en1I7DaCr8Dnet0VuJqCHQD0fd2iqXWbEk9gJJCy+Z9lt6?=
 =?us-ascii?Q?7+DnLCwn77lpiSr9GkXkRljMF383rWSWK1mO84lg4tBWXdLP3hEbP5Wf1r5W?=
 =?us-ascii?Q?qnKUXKLCIJ0HuhaFv3VVxIsslsYVJvulbrOBVSC87NHMh8IqRnLIfRx+Cbg4?=
 =?us-ascii?Q?yICW7WXCCBmOG6AuttPNAREutGkMBj7BgiJxR1orlEvsHc+vCEHnAeENLTBZ?=
 =?us-ascii?Q?RKf5OjeJLRvm2/dtiMop2t9n5fl/tGyy74KZ78h09isqsmdEGHai1qOZWqRy?=
 =?us-ascii?Q?RU+j9+JCyRDXckkgRzdfZCID6+haBNvNCFaQMbhjMQ7z++1nNfwqIahBAMMK?=
 =?us-ascii?Q?BNx/W6Em9UctisCakD9S5dG1FgKhA4K8MbiKwGMzlDOhIvhHq0BAaLMWUSfa?=
 =?us-ascii?Q?Chf+8+GKDhK+q+xToOlwayRKlEl6viddF1VWetgNtpgMiIvSAkdBpTMYfd5C?=
 =?us-ascii?Q?Vd9zsP/ckRhe5TTnlvEJmISJsrsrbB1hRE82vp//L3EudS3/iK4IsgcVBunj?=
 =?us-ascii?Q?3NRD+ueTOHGG0fRYbxQCgeaiFMqqSR8Yebft4CCzPCjMbzRkqyspVjvTJJ/2?=
 =?us-ascii?Q?ngiNDug/qJKH0V/G+LLee+Ursm/mStoYVDp8bBorbiQXoYxL7ePxcwC4/3rc?=
 =?us-ascii?Q?Hgqt+6M5/Ye5JbFdcY+uziAGGqIoYiT4AL3RgecMsdwR3lHXOBnlcNEjm8OZ?=
 =?us-ascii?Q?/snGj6EW0Mw4AOEOtxaWNFFH/Lq/3f/sqHadBKDdKmnKpPXsPHXe/IiASOcA?=
 =?us-ascii?Q?CYfXnsKK5GzZFvBW4R95JlL4lM5OytLfZWaxRRZbhPwHNDWG7mBLbQOT5zeS?=
 =?us-ascii?Q?ULwIo8VkZ6ABe7fvif+Df/6xccASQTrHcQul+7Lec4/1sz4uYteSsG9eEP+q?=
 =?us-ascii?Q?eY2iXpZOJxpfmPcgRpVLkTetca8RYnK+bom1gvVR96/4iL+goqYXGulDSnDr?=
 =?us-ascii?Q?tW0uiwkgHmCFxYus3046KctK4L1A8/nRR6JJ6PVMt80iMj4FLxJHe023SrPA?=
 =?us-ascii?Q?a072HYhSQlvJWu1DT/4eYvc2+bTUWbRh/MuyhtcUxkNbZ68doBSAgqYbtbn4?=
 =?us-ascii?Q?C2ed2K3K1JDD7dx+L3d7NHNKHf3r1L2IN94SkK2YW6JmaYAdBMnQx/89H8s3?=
 =?us-ascii?Q?xxIEPEdXTLFK6Sh2zR6NbDjriSWeaF7dziat3nHIpvwUS3E5Vg5xYqiH9M5Z?=
 =?us-ascii?Q?2UNSFtiDzJ5MIc7ammwxEIVHARONdK8LpHYFxoq6ZEInKeNu3ngUaZjrVDIk?=
 =?us-ascii?Q?6CRaRiI1+4zUNm6NF8eTbQEBQnT5vy73snfwG44DooGks+J6Cwdlgs0MiB2k?=
 =?us-ascii?Q?2bOEmLQwoTkK6aBc1OGmrR7sIEcssuBV7CcWWCOTxb92r4Q1aYhGK4QoBR6K?=
 =?us-ascii?Q?n7k76sLmKuusYdIkjIvmb5OWPb/+mQf7cV41+hsKR2Ev+LMChB5e8HmiMQ1W?=
 =?us-ascii?Q?0k6QrNEu5/bgDAdV8kkmoM0Bs0Zy/X35XJlMwN40e5WhCMwgDtlDZlzkycJT?=
 =?us-ascii?Q?8sKCKo+cP3yJUkN62X6xVe3/jgUzbTHAK4mhggy1R4jPOl32XTShg539XL0Y?=
 =?us-ascii?Q?6pTwCRLs6R8jZav1/c5glM2UrXzJYKNnv5oHF4oOPsVPmUAqAxzBfBzDuphs?=
 =?us-ascii?Q?ww=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 77133fc6-6e9d-4e84-bbbe-08dbb543df36
X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7540.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2023 16:58:51.6388
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XFM0jwDwTomYVRkzRreA5xJEY15HeXQgFUnL3RcT4JctEuugEzxe2Jo3D91JCY6rne782yDt/VcZF1nPZcjbyekqCffx1jbo7p4/nK/lGL8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB8063
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 14 Sep 2023 09:59:03 -0700 (PDT)
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email

On Thu, Sep 14, 2023 at 06:38:15PM +0200, Maciej Fijalkowski wrote:
> On Thu, Sep 14, 2023 at 10:37:11AM +0200, Larysa Zaremba wrote:
> > There is no fundamental reason, why multi-buffer XDP and XDP kfunc RX hints
> > cannot coexist in a single program.
> > 
> > Allow those features to be used together by modifying the flags conditions.
> > 
> > Suggested-by: Stanislav Fomichev <sdf@google.com>
> > Link: https://lore.kernel.org/bpf/CAKH8qBuzgtJj=OKMdsxEkyML36VsAuZpcrsXcyqjdKXSJCBq=Q@mail.gmail.com/
> > Signed-off-by: Larysa Zaremba <larysa.zaremba@intel.com>
> 
> Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> 
> Though it would be worth spelling out something in the commit msg about
> additional check you're adding (frags flag can't go without dev bound)
>

Ok, I'll add to the commit message the below:

Frags are allowed only if program is dev-bound-only, but not if it is requesting 
bpf offload.

> > ---
> >  kernel/bpf/offload.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> > 
> > diff --git a/kernel/bpf/offload.c b/kernel/bpf/offload.c
> > index ee35f33a96d1..43aded96c79b 100644
> > --- a/kernel/bpf/offload.c
> > +++ b/kernel/bpf/offload.c
> > @@ -232,7 +232,11 @@ int bpf_prog_dev_bound_init(struct bpf_prog *prog, union bpf_attr *attr)
> >  	    attr->prog_type != BPF_PROG_TYPE_XDP)
> >  		return -EINVAL;
> >  
> > -	if (attr->prog_flags & ~BPF_F_XDP_DEV_BOUND_ONLY)
> > +	if (attr->prog_flags & ~(BPF_F_XDP_DEV_BOUND_ONLY | BPF_F_XDP_HAS_FRAGS))
> > +		return -EINVAL;
> > +
> > +	if (attr->prog_flags & BPF_F_XDP_HAS_FRAGS &&
> > +	    !(attr->prog_flags & BPF_F_XDP_DEV_BOUND_ONLY))
> >  		return -EINVAL;
> >  
> >  	if (attr->prog_type == BPF_PROG_TYPE_SCHED_CLS &&
> > -- 
> > 2.41.0
> > 
> >