Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <e1e818fb-a842-eafc-d365-bd1f9314852b@intel.com>
Date:   Thu, 14 Sep 2023 08:04:47 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.0
Subject: Re: [PATCH 2/5] selftests/resctrl: Remove duplicate feature check
 from CMT test
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>
CC:     Shuah Khan <shuah@kernel.org>,
        Shuah Khan <skhan@linuxfoundation.org>,
        <linux-kselftest@vger.kernel.org>,
        =?UTF-8?Q?Maciej_Wiecz=c3=b3r-Retman?= 
        <maciej.wieczor-retman@intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        <stable@vger.kernel.org>
References: <20230911111930.16088-1-ilpo.jarvinen@linux.intel.com>
 <20230911111930.16088-3-ilpo.jarvinen@linux.intel.com>
 <40ba8890-32d1-e440-29fd-b8f8db69acc5@intel.com>
 <80695068-4a6-b8e9-107f-8d29ab3543be@linux.intel.com>
 <fb32abc8-4381-00bf-c07e-b28066f51cdb@intel.com>
 <82c78269-324-5f49-e33f-55364d94c8cf@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <82c78269-324-5f49-e33f-55364d94c8cf@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Tzg0eFZUMTRmL1Q3NkdSdFRKWDVxQ0dzdkVSVTFCZGU0cGFEN3VrR0c3ME9k?=
 =?utf-8?B?a2hLUXZLcklieTc0R3kwTTJBZTZDYmRicDRYN0tjUjdGak56c0VPSEpjNzBk?=
 =?utf-8?B?b0QzU2NLQzFMOVArTE5nNDhHTFREaGlYRVo0UVMvSU9WYkpoUnJjRmVnTFRv?=
 =?utf-8?B?S1hsaW9GeldmaGFocDVGSG1JcTNkVll6N2dISXU5TzRlQVhpUzFnNlFvOTBv?=
 =?utf-8?B?cUJTYmFQdlFsT3RFUXlhbm9PVkQ2S1kyRXo4Nm0vUURDdkRGSWNQMVlHVEVi?=
 =?utf-8?B?RGFnY2ZYc1lOSTBtcHdZemF6bFlPVXU2UnF4Y3BSNnFGNFpiSVVoN0NJdkQ3?=
 =?utf-8?B?STdrODNkdXN5QmV5azgwRTZUeTl0T2hxM3pacEJFMlNHUWhkVnVJVmNIbU96?=
 =?utf-8?B?UzdKcnRUb04xSFZBZTZtd2RpTkpOQkE3T1g3WDJQV3BNUzZ1M3RFT3E3MkFD?=
 =?utf-8?B?bXpNN2tDRm1TR0V4b0FuTDZham5RaURiZldKamt5bms4QWFHV2NQU3pha1Zr?=
 =?utf-8?B?dE1SKzdQemZmZnVjRUowWHBoMWFpalZ0N1RSMkVWYk11OWpjZWRpZTVSaWR5?=
 =?utf-8?B?bmJ4TUh2eG9mNHZNaHJUb3JZZ09lNEJKNmRNeGE2bjdBUVd1Z0UzRTVYL3d1?=
 =?utf-8?B?VTFiWWxXcHEvZmxUWEJRVEpxWHdMZWV5VXlVdVV4Yi9vNTlmUURJTmtYRVVl?=
 =?utf-8?B?WVN0eGhKczBUK2Zhd2NNTkZrUnRlYmtTemJQQ3pLcjI0NFV1bFBGSk4xYXJB?=
 =?utf-8?B?K1dCbkEzb3ZkdndHQ21WSHg4Z1RlYThyVkNIQWkzM2JwZzVCeXUrcFpqeSts?=
 =?utf-8?B?MXFlNENnaEMwaENsa0w4Y0RiNnpMWE1oSTVacGxCWncxMVhDK3V2ZlZPSlBR?=
 =?utf-8?B?MStod0lUNHNpcmZnaFQybk1Xb21Fa2JrL2V5YkprekR4NFJGU3VBSWNGczM4?=
 =?utf-8?B?Nmxqb204Z3p1ZUFHUVVuSHh6Z1BMbTltZnNMMEhYU3BGMVNCN0ZGQ2kyeHlj?=
 =?utf-8?B?ZlRadWR4c29jcU15a1FmVzVvNmYrNDdidlM2ZDVhVERraDBpRDhHUjByQ3FH?=
 =?utf-8?B?UGNwNE5SVVRCcjEraTZ1REFXM1ZWcWg4bnV6bmJWcDgwOG5UVzRMMGk1K2tr?=
 =?utf-8?B?c09ObWVaeVBGeGt4WVVnQXdlOUtPY0ZVNEFTRzVIbkZnRDUzRlE5N21KM0hK?=
 =?utf-8?B?aW9wZTZjNFNPcGZScGsxeXljN204ckNibUxBdFc4eWJXNkFFVldpdCs0RE5W?=
 =?utf-8?B?cjdyYVlSams4NlFzN3ZtSE1kd2xoSjFIbG56bVQ3M1BRRTF3dXRna3UrZ01K?=
 =?utf-8?B?OFFTQmtUUC9QM0lTUE9YVnZpakd3OS84Y24wVVFaaldMaDR1OUo0T2hBYi9J?=
 =?utf-8?B?clNwNmVPbUgzbUxCWkpSUjRYMXZxUzlrM3VTaitUZCtyRWcweEhiZVFuakpM?=
 =?utf-8?B?UkRHclZpUG1zc3h1THhUL1RxM00wYTBGTHlFTUlCQ1NVcFZ2K0MxYWNwYlBy?=
 =?utf-8?B?eUJyZENCUERLZ0JQMFdqZk82TktwK09rdVVmZ0tMdUdjL1RSejdPZjNXcDZu?=
 =?utf-8?B?Qmk2UW1EZnprdjl1YmV3MTRwajhnSDcxckxyQm1yNm5zTTdCbUFiTTIvK1JS?=
 =?utf-8?B?VENIbkJ3TVhNQUtIbHRXUTJQWExnSWxmME9xV01YU3ZwY1ZmYm5hM3hrTXp2?=
 =?utf-8?B?djZIMzNEbzh4RjBZWStPMm5VN2JMWlhaOTY4VnQ1U2hldmJVVUdDUHlFUzBa?=
 =?utf-8?B?ajkwZUJtMG50SVEyc1VPU1lNYVk3UDBqekRkU3EzbVE3OEVyNUE2QjM0M0t3?=
 =?utf-8?B?QXBIcTdwNmhwTWVKZ3FtcVg0NDU5V1VNTG9icUlqVGpDSTJ6dENpMFBmenhl?=
 =?utf-8?B?d0xHM3dCREZ1bU9MS2UxU293eHlMU3hwdThPZlBSK1FiMnRZT3hZclpBdldP?=
 =?utf-8?B?ZEg2RWxNZWgyUHBZNkFNWjNTYnRQMSt1MTRoeWViU3B5MXhuenVIbjFnQS9t?=
 =?utf-8?B?ZkdvWnFxeWZzQ01hYnMyOFlydXF2SHZSYWdMZmNkZzVoUGRxY3hpNGFSVTk3?=
 =?utf-8?B?aURsd1lUOGw1QTNSRUJzRTBDUm8weWRPbXhpb0JWZ2xtUFRPbFh4anpxSDVN?=
 =?utf-8?B?Y3lCa3BFdjd3c3NFcW9kZWFtcDQzc3JhbVdTMXZjUVFJQU8waHZyS3ZHOGJh?=
 =?utf-8?B?M1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 354587d1-6d25-400a-f354-08dbb533f127
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2023 15:04:49.8279
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9GU0g5CZr2/fVej+gFed1yD4adn7wq8E2bEKQ8H/x2b9c3hBzWl/7ckrSi7fUv5TvujZWgQ2wXoPuR5AdkG9pjJMQHW0u9K+KLLBxwDTy2k=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB7087
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 14 Sep 2023 08:05:53 -0700 (PDT)
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email

Hi Ilpo,

On 9/14/2023 2:58 AM, Ilpo Järvinen wrote:
> On Wed, 13 Sep 2023, Reinette Chatre wrote:
>> On 9/13/2023 4:11 AM, Ilpo Järvinen wrote:
>>> On Tue, 12 Sep 2023, Reinette Chatre wrote:
>>>> On 9/11/2023 4:19 AM, Ilpo Järvinen wrote:
>>>>> The test runner run_cmt_test() in resctrl_tests.c checks for CMT
>>>>> feature and does not run cmt_resctrl_val() if CMT is not supported.
>>>>> Then cmt_resctrl_val() also check is CMT is supported.
>>>>>
>>>>> Remove the duplicated feature check for CMT from cmt_resctrl_val().
>>>>>
>>>>> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
>>>>> Cc: <stable@vger.kernel.org>
>>>>
>>>> This does not look like stable material to me. 
>>>
>>> I know but when constructing this series I had 2 options:
>>>
>>> Either convert also this when changing validate_resctrl_feature_request() 
>>> or remove this call entirely.
>>>
>>> Given it's duplicate of the other CMT check, I chose to just remove it 
>>> (which I'd do anyway). As patch 4/5 requires 3/5 which in turn requires 
>>> this, this has to go stable if 4/5 goes too.
>>>
>>
>> Understood. This makes it a dependency of an actual fix, which is addressed
>> in 4/5's sign-off area. This notation is new to me but it is not clear to me
>> that the dependency should also be tagged as stable material (without a 
>> fixes tag). Since it is not an actual fix by itself yet is sent to @stable
>> I think it may cause confusion. Is just listing it as a dependency of the
>> actual fix not sufficient (as you already do in 4/5)? Perhaps as compromise
>> this patch can also get a note to the stable team. Something like:
>>
>> 	Cc: <stable@vger.kernel.org> # dependency of "selftests/resctrl: Fix feature checks"
>>
>> I am not sure though - I would like to avoid confusion and not burden
>> the stable team. If this is a flow you have used before successfully I'd
>> defer to your experience.
> 
> I came across that dependency format when Greg KH replied to somebody how 
> to deal with the cases where there isn't yet a commit id 
> (the cases mentioned in Documentation/process/stable-kernel-rules.rst 
> assumes there is already a commit id). Unfortunately it's long time ago 
> so I cannot easily find the link.

I see, thank you. I was not aware of this custom.

Reinette