Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp4073465rdb; Thu, 14 Sep 2023 10:55:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFBAUU/hDZjOy+MGEHkU21TDH2vJxuOp2bFcUsdt1aQsa2+ewwkO+kzTDa1jaF5gQ4CuWnx X-Received: by 2002:a05:6358:1814:b0:142:e7cd:f04b with SMTP id u20-20020a056358181400b00142e7cdf04bmr4209199rwm.0.1694714147719; Thu, 14 Sep 2023 10:55:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694714147; cv=none; d=google.com; s=arc-20160816; b=GkiwZdVbcq9Dy3yU1NrbyvVB5exJaZbMKrQ7vRRJ9JOfSxe/t1ZA3p+059G16jJhaT IV3OXPqfzVv9knyJ0ATpgt0n0hIwGALYlJN+JNZSdwZaQ6Q/7nvEIkhI7WHKpPlOKFCp i8f1esQRFBp8xvfWnBhoqc4JbBN9pPjgphUSkKfo+BEwV3DLkpfy1n4nDEmpsnd0649k 12ulOuBr9nPO22J+t0BxqYxbaq+1S4v6/UUrsrzGO6JIH8ZOwHSkwlN5nud3dGvDfmGQ FwlcF0OYJVLRgl16AiE+ZpnmEAXkWI9ozhbwPobP72oHG3/qbYtSomLmWkEEoRyDS2N6 70FA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:in-reply-to :subject:cc:to:from:message-id:date:dkim-signature:dkim-signature; bh=lZRieROqbwcDhGtcftY4gNUE3C/0M9g8+nAIb/BCYK8=; fh=ioU4v7Iz2qoS2/+kvYEd2Bw84BRg6F2vLjWVJuhFnx0=; b=daLKX2NLs8WxEsH9UmR8pypyvyVct6dHPB3vHnHkyc+TyORg7zjhKzifUgZLYVO071 kUiL35mGMP7nndTmx7gfQqKNxTdC6CVItep2HfudHemd0NRlYrTZv/1ax2WsJxCcLd7A QZJ6oz6MTufB3dLk+L5NkVXTHp2l3xH+o9XWPxQrnzvjscApmYZTVCVFs/FXhhN1JNQc kC+9SwNp+Ae35M1zxx8EybLd1wb06y3zjDQOlOQgiQfWyXhQOILmtEkYjzymb6nr3TuH PnPrXc7g+vzHBAsxcC1lfHOzFY382tbNmBqS1TvK9RWfHYipuq8q3yWVcDMshBAjIh4B wUCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=cp6fCWVm; dkim=neutral (no key) header.i=@suse.de header.b=CYblOK5z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id o4-20020a6548c4000000b00577ae8b603fsi1856568pgs.314.2023.09.14.10.55.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Sep 2023 10:55:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=cp6fCWVm; dkim=neutral (no key) header.i=@suse.de header.b=CYblOK5z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 4B8898083AB4; Thu, 14 Sep 2023 07:37:31 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238205AbjINOhc (ORCPT + 99 others); Thu, 14 Sep 2023 10:37:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233693AbjINOha (ORCPT ); Thu, 14 Sep 2023 10:37:30 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE3D21AD for ; Thu, 14 Sep 2023 07:37:25 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A1FF521842; Thu, 14 Sep 2023 14:37:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1694702244; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lZRieROqbwcDhGtcftY4gNUE3C/0M9g8+nAIb/BCYK8=; b=cp6fCWVmRmhxGFp2vxv37JeKGKUzTZz5QvZQtfmU/3DLy+XlaKWpBJnwRWOi+CNFo16MgN X1g/kaJ9coBrYxaB5sQEJldmBAe9TljMQJKVXRBUoxNx1zSHWyT0ESY295aAurJwKioIrm gX7UsaGaoiEqnxGJUmw6aQep07MgQs8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1694702244; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lZRieROqbwcDhGtcftY4gNUE3C/0M9g8+nAIb/BCYK8=; b=CYblOK5z/3NzYmTTCuwIY3/csHiYxFVfB0NXTnNAnQYhcpuWjCRZh+pMqGb91pusfgOKFr 2zM4SARn5zIzeuAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7D7DE139DB; Thu, 14 Sep 2023 14:37:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 3Rd4HaQaA2WweAAAMHmgww (envelope-from ); Thu, 14 Sep 2023 14:37:24 +0000 Date: Thu, 14 Sep 2023 16:37:23 +0200 Message-ID: <87wmwsyg64.wl-tiwai@suse.de> From: Takashi Iwai To: Richard Fitzgerald Cc: , , , Subject: Re: [PATCH] ALSA: hda: cs35l56: Don't 'return ret' if ret is always zero In-Reply-To: <20230914140852.7112-1-rf@opensource.cirrus.com> References: <20230914140852.7112-1-rf@opensource.cirrus.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 14 Sep 2023 07:37:31 -0700 (PDT) On Thu, 14 Sep 2023 16:08:52 +0200, Richard Fitzgerald wrote: > > The final return in cs35l56_hda_posture_get() was returning the > value of 'ret', but ret is always zero at this point. So this > can be a simple 'return 0'. > > Signed-off-by: Richard Fitzgerald Thanks, applied. Takashi