Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <ef9d4ca5-35e4-ff8c-c1aa-f77a4b04d0a2@intel.com>
Date:   Thu, 14 Sep 2023 17:22:00 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH net-next v3] net/core: Export dev_core_stats_*_inc()
Content-Language: en-US
To:     Yajun Deng <yajun.deng@linux.dev>
CC:     <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <horms@kernel.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20230914023718.3854545-1-yajun.deng@linux.dev>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <20230914023718.3854545-1-yajun.deng@linux.dev>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b3QwUHNqRFZwcGJBQkhsVG5FOFgvVVR5ZWRDMjN0eHY5empuMVF3TWxxMk1X?=
 =?utf-8?B?TWtTNXZRbDBkVVAwTUk3dFRlVHJyTW43SHVVVm5MSUtGaDlxb0lxM2VndU54?=
 =?utf-8?B?akRNY0RaeU9rUGxjUWlpTnVZcEdhL1J4YzhrRWdmU1UyaWUvNlpPL1N5eVpG?=
 =?utf-8?B?SjZaYUxvb3R4VkhiLzA5SlpjN2pJT3d5dVdqTWVnK1pRSEVTRm1sei9DWDhL?=
 =?utf-8?B?ZmE2cWtkRWRuL3M3Q0ptRC84S3Jxck9rbUNkOUNYcVYrZFR1NzkwQnRjRUor?=
 =?utf-8?B?TTZ4cXVZTTVxdFdoNWNsTlVPOU1TcGF1UUdlNUxvdldDWTdTZlU4YkhNZUg4?=
 =?utf-8?B?ZFZrSUhEZHNsZnpzMlk5TjBYdVUvL0N3SDJDYTU0RzJyREVodWhwTGcvRkFr?=
 =?utf-8?B?ZnE3Mk9YRW9SZjBqSU9IZkhnbVJsWjdoc2VuekpaZkVIaEJTQTZxU25EVytE?=
 =?utf-8?B?eVlYNFhEVGpiWHVLcEQvS0Z4UUp0aThrZDVyUnk2UzBGNDh6ZFVTRTNFekor?=
 =?utf-8?B?bkhDb3REU0pncyt1aXVsbE9wcTVabHNMQ1U4UUZXUk8xcVFSc1QrcEZhQTVK?=
 =?utf-8?B?NVFlTmZxaW5IRDBzd2JaNTExWGRmMys3K3NWcWxRWHB5a0E1bHJ2cUxIcHJm?=
 =?utf-8?B?RFZFN0VUa1JEdC9FME96bnJudW0yejdpaE9wb1ZKV0ZtOEd5UkZCTTMrVisv?=
 =?utf-8?B?czIxSzMyZS85dzBiVlVNNlpDVmtqSmJ0L1U4MkZIekJrWE45S3BEQ0hXazVh?=
 =?utf-8?B?Vm1wbWVaVFA0N2Q2MUdGMWkwbU1Oc1IrWW1sK3JHWk5NUVBmZWVZWC9JWnQ3?=
 =?utf-8?B?Q0t2NTJHSjU4bDlnQ1NRZU95ZTBaUUVBV2F6dENwUWYxK1B3VTZKSjVveGlG?=
 =?utf-8?B?UkdES2JYZ0phT05HNzN5REpINXU5ZzR4ZHdRSTdtdndJYmpKYnZZOS9Xalhx?=
 =?utf-8?B?UjQ5LzB3by9walVXM2paVmMyRFZFV2dhdmRzaEllTkora2NxU25pM2ZlZXFk?=
 =?utf-8?B?ZVJ5QVNZVnIzTzJOWkRoSlg0eVhySlNhZm4xVVYyanV0MURiNWNyRlNsQ0p5?=
 =?utf-8?B?Rkp3aXFQM2g4a3lRcERYQVN1QW5RVExzZmw2L2hPK3FCeTVEbC9yWEpXMzFw?=
 =?utf-8?B?NVYyOEYrc3hvck1wYnF4T29jTGc0YmJOUjJZYlp4bDQ0Q3FxckVaNHJGNEdX?=
 =?utf-8?B?eTdNeFNFa1RROS9pSFRTbno4cE1scWUyaExiWDlrZElmbjU4VFJNN0tkak1s?=
 =?utf-8?B?SkUyeW9pVGQ3VThPTUZIVkpWL3VjWnBPUExlUHUwdWFFOFJlT1NVcWJ1WmNX?=
 =?utf-8?B?ZldNQi83K2p6OE8zRGhPTi9UNC9LZGs1M28yZ2lqTElDNng2ajJOd2xPVm83?=
 =?utf-8?B?eW5RYlAzNXdPV010Vy8vQVFzcTNqNzlxc2t6RXBob05QdDFOM1d4WTNubFo2?=
 =?utf-8?B?ZzFwQXdHNmw3TjdQcVhmYTVDVElBamw4OTJHREc5TS9KeVRySkoyTUkrSnlZ?=
 =?utf-8?B?QnUwVGVubll4eXZCNHpqbU5LcjJqS0RZbDNwQVhmL0w2UDNWeWdtRFJCek9G?=
 =?utf-8?B?N0NaL25PVEpWcHpCNkY0S1U0a2Jmb1NHV0hwYlBLeGY2eWRhYXl1b25iWXJ2?=
 =?utf-8?B?U21oV3d4ZFl3M1lsTGQ4T1crRmsvZndsWWZuZFhvRlo4dE1lelpxMDEyOHY5?=
 =?utf-8?B?d2hkNnJBdlRiNVlPODhaUTlJZDEzWHRFRXgycmhUbWJDM2R5SU1qZmN6Wkgw?=
 =?utf-8?B?TDNoMzZXL3Njb05EQlQxZWhSeko2eFlLUllmSEZ5YjB4UmFIZUs5RmMwSzIx?=
 =?utf-8?B?Tlg5MHpDV0JnSHQ1cUhCNG43WVBkUkxNMVVsblJoK0Y1RDJlVXpyeXp5RGlq?=
 =?utf-8?B?dXZNKzFSbmFKV0dnaG9XSVJrNDJJZnRFSzVHY25MdWVsQlJwU0JxK043YTJW?=
 =?utf-8?B?UnRlKzJtMTRKY2M0MzR4cld2Q256eXRCOVZVd0twaDZzeG9VYzQyS25xNFRy?=
 =?utf-8?B?dFlaQjV3bWpzN0hXdXF6TmxvN3JBV0p1cUlPSllzY21rVFl1RFBYdmR0NjJI?=
 =?utf-8?B?RjdYRWk2cWJNYTRJbEhEaHNXc25KNVhZQTdvU2JxRzdYU1VlOU9tN3BXNnd3?=
 =?utf-8?B?ZTB5RFB3Nm9VL0UvYzlmQ1ZJZ0VjSGxFZjdXUEEyMi80Qm5YK3B3ejNnaHpT?=
 =?utf-8?B?RUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3a6aaff2-5e57-479a-dc7a-08dbb536756a
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2023 15:22:50.8327
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZMqBb1Ekktrq+IVnnzQzy1lNxv1BspPEiqZqDHlGK4mOFcQRz/nL8KpWHNm/+uW80k74pUyvJzz68jwsuZ0dXrfqqPvFwyxlDnvwdVr6ZHE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7460
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 14 Sep 2023 08:22:58 -0700 (PDT)

From: Yajun Deng <yajun.deng@linux.dev>
Date: Thu, 14 Sep 2023 10:37:18 +0800

> Although there is a kfree_skb_reason() helper function that can be used to
> find the reason why this skb is dropped, but most callers didn't increase
> one of rx_dropped, tx_dropped, rx_nohandler and rx_otherhost_dropped.
> 
> For the users, people are more concerned about why the dropped in ip
> is increasing. So we can export dev_core_stats_rx_dropped_inc sets,
> which users would trace them know why rx_dropped is increasing.
> 
> Export dev_core_stats_{rx_dropped, tx_dropped, rx_nohandler,
> rx_otherhost_dropped}_inc for trace. Also, move dev_core_stats()
> and netdev_core_stats_alloc() to dev.c, as they are not called
> externally.

I'd like to hear some arguments against having them static inlines + one
external that I proposed earlier.

> 
> Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
> ---
> v3: __cold should be added to the netdev_core_stats_alloc().
> v2: use __cold instead of inline in dev_core_stats().
> v1: https://lore.kernel.org/netdev/20230911082016.3694700-1-yajun.deng@linux.dev/

...as it's not at least mentioned here in the changelog.

[...]

> diff --git a/net/core/dev.c b/net/core/dev.c
> index ccff2b6ef958..98592e4c1df0 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -10475,7 +10475,7 @@ void netdev_stats_to_stats64(struct rtnl_link_stats64 *stats64,
>  }
>  EXPORT_SYMBOL(netdev_stats_to_stats64);
>  
> -struct net_device_core_stats __percpu *netdev_core_stats_alloc(struct net_device *dev)
> +static __cold struct net_device_core_stats __percpu *netdev_core_stats_alloc(struct net_device *dev)

This is way over 79/80 chars, break the line before "netdev_".

>  {
>  	struct net_device_core_stats __percpu *p;
>  
> @@ -10488,7 +10488,35 @@ struct net_device_core_stats __percpu *netdev_core_stats_alloc(struct net_device
>  	/* This READ_ONCE() pairs with the cmpxchg() above */
>  	return READ_ONCE(dev->core_stats);
>  }
> -EXPORT_SYMBOL(netdev_core_stats_alloc);
> +
> +static inline struct net_device_core_stats __percpu *dev_core_stats(struct net_device *dev)

Same for the line length.
Also notice that now some of the functions you touch have "dev_" prefix,
others have "netdev_", I'd probably take a look into unifying this.

(note for the maintainers that it would be probably better to leave
 explicit "inline" here, but no bloat-o-meter was provided by the
 author, so I can't say anything for sure)

> +{
> +	/* This READ_ONCE() pairs with the write in netdev_core_stats_alloc() */
> +	struct net_device_core_stats __percpu *p = READ_ONCE(dev->core_stats);
> +
> +	if (likely(p))
> +		return p;
> +
> +	return netdev_core_stats_alloc(dev);
> +}

[...]

Thanks,
Olek