Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Date:   Tue, 12 Sep 2023 11:16:09 +0530
From:   Aditya Gupta <adityag@linux.ibm.com>
To:     Namhyung Kim <namhyung@kernel.org>
Cc:     acme@kernel.org, jolsa@kernel.org, irogers@google.com,
        linux-perf-users@vger.kernel.org, maddy@linux.ibm.com,
        atrajeev@linux.vnet.ibm.com, kjain@linux.ibm.com,
        disgoel@linux.vnet.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] perf tests task_analyzer: use perf check for
 libtraceevent support
Message-ID: <kondzija2p2qdahlqib5mmmfda2ecogyhrpj7r7cyskj7vm6kb@4q6c7akd3kgz>
References: <20230903114721.190733-1-adityag@linux.ibm.com>
 <20230903114721.190733-4-adityag@linux.ibm.com>
 <CAM9d7chkvhnfhZo+Whypg40Vik3XiuvbKWZ_3jF0Zpsj+6JfqA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAM9d7chkvhnfhZo+Whypg40Vik3XiuvbKWZ_3jF0Zpsj+6JfqA@mail.gmail.com>
Precedence: bulk

Hi Namhyung,
Sorry for the late reply.

On Thu, Sep 07, 2023 at 02:32:22PM -0700, Namhyung Kim wrote:
> On Sun, Sep 3, 2023 at 4:47 AM Aditya Gupta <adityag@linux.ibm.com> wrote:
> >
> > Currently we use output of 'perf version --build-options', to check whether
> > perf was built with libtraceevent support.
> >
> > Instead, use 'perf check --feature libtraceevent' to check for
> > libtraceevent support.
> >
> > Signed-off-by: Aditya Gupta <adityag@linux.ibm.com>
> > ---
> >  tools/perf/tests/shell/test_task_analyzer.sh | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/tools/perf/tests/shell/test_task_analyzer.sh b/tools/perf/tests/shell/test_task_analyzer.sh
> > index 92d15154ba79..8fbc33c95025 100755
> > --- a/tools/perf/tests/shell/test_task_analyzer.sh
> > +++ b/tools/perf/tests/shell/test_task_analyzer.sh
> > @@ -52,8 +52,8 @@ find_str_or_fail() {
> >
> >  # check if perf is compiled with libtraceevent support
> >  skip_no_probe_record_support() {
> > -       perf version --build-options | grep -q " OFF .* HAVE_LIBTRACEEVENT" && return 2
> > -       return 0
> > +       perf check --feature libtraceevent >/dev/null && return 0
> 
> Maybe we can add -q/--quiet option to silent messages.

Nice idea, thanks. Will do so.

Thanks
- Aditya Gupta