Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <30bbcc92-f5ff-cbda-7a3b-cc801aa560ed@linux.ibm.com>
Date:   Thu, 14 Sep 2023 12:29:14 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.15.1
Subject: Re: [RFC PATCH net-next] net/smc: Introduce SMC-related proc files
To:     Wen Gu <guwen@linux.alibaba.com>,
        Wenjia Zhang <wenjia@linux.ibm.com>, kgraul@linux.ibm.com,
        jaka@linux.ibm.com, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com
Cc:     alibuda@linux.alibaba.com, tonylu@linux.alibaba.com,
        linux-s390@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <1694416820-60340-1-git-send-email-guwen@linux.alibaba.com>
 <2b1d129c-06e2-0161-7c8a-1e930150d797@linux.ibm.com>
 <a0a4567e-07f1-91db-50cb-bbfc803f5969@linux.alibaba.com>
Content-Language: en-US
From:   Alexandra Winter <wintera@linux.ibm.com>
In-Reply-To: <a0a4567e-07f1-91db-50cb-bbfc803f5969@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 13.09.23 11:53, Wen Gu wrote:
> 
> 
> On 2023/9/11 19:54, Wenjia Zhang wrote:
>>
>>
>>
>> Hi Wen,
>>
>> I can understand your problem and frustration. However, there are two reasons I'm not really convinced by the proc file method:
>> 1) AFAI, the proc method could consume many CPU time especially in case with a log of sockets to read the pseudo files.
>> 2) We have already implemented the complex netlink method on the same purpose. I see the double expense to main the code.
>>
>> Then the question is if the lack of dependency issue can be handle somehow, or the proc method is the only way to achieve this purpose?
>>
>> Any opinion is welcome!
>>
>> Thanks,
>> Wenjia
> 
> Hi, Wenjia. I agree with your concerns.
> 
> My initial intention is to make these proc files serve as a supplement to netlink to conveniently
> check smc connections in an environment where smc-tools cannot be easily obtained.
> 
> Yes, proc files won't be the first choice for diagnosis, but can be a convenient backup.
> 
> Thanks,
> Wen Gu
> 
> 
As /proc is an interface to userface,  we would have to maintain the 2 redundant methods basically forever.
I personally don't think we should implement another interface without a very strong reason.