Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
From:   Paul Durrant <xadimgnik@gmail.com>
Message-ID: <d28de5c6-27ff-5ced-95dc-575325e71598@xen.org>
Date:   Thu, 14 Sep 2023 11:38:12 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.0
Reply-To: paul@xen.org
Subject: Re: [PATCH 5/8] KVM: pfncache: allow a cache to be activated with a
 fixed (userspace) HVA
Content-Language: en-US
To:     David Woodhouse <dwmw2@infradead.org>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Paul Durrant <pdurrant@amazon.com>,
        Paolo Bonzini <pbonzini@redhat.com>
References: <20230914084946.200043-1-paul@xen.org>
 <20230914084946.200043-6-paul@xen.org>
 <7c023cb88c5f13e70b53ac695a7b45213c4f97a3.camel@infradead.org>
Organization: Xen Project
In-Reply-To: <7c023cb88c5f13e70b53ac695a7b45213c4f97a3.camel@infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 14/09/2023 10:29, David Woodhouse wrote:
> On Thu, 2023-09-14 at 08:49 +0000, Paul Durrant wrote:
>>
>>   int kvm_gpc_refresh(struct gfn_to_pfn_cache *gpc, unsigned long len)
>>   {
>> -       return __kvm_gpc_refresh(gpc, gpc->gpa, len);
>> +       return __kvm_gpc_refresh(gpc, gpc->addr, len, gpc->addr_is_gpa);
>>   }
>>   EXPORT_SYMBOL_GPL(kvm_gpc_refresh);
> 
> I think I have a slight preference for leaving kvm_gpc_refresh()
> working on a GPA unconditionally, thus calling __kvm_gpc_refresh() with
> the final argument set to true.
> 
> Introduce another one-line wrapper kvm_gpc_refresh_hva() for the false
> case. And perhaps BUG_ON() calling the 'wrong' refresh function?

Hmm. That makes life harder for the code messing with the vcpu_info. I 
would need to know which cache it was looking at, because it could be 
the vcpu_info cache or shinfo cache, and if it's the shinfo cache it 
would need to know how it was activated.

   Paul