Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <b1cf5990-1019-49ea-a1e8-e22410922801@amd.com>
Date:   Thu, 14 Sep 2023 16:52:13 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] perf/x86/amd: Do not WARN on every IRQ
Content-Language: en-US
To:     Peter Zijlstra <peterz@infradead.org>,
        Breno Leitao <leitao@debian.org>
Cc:     Jirka Hladky <jhladky@redhat.com>, Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Ian Rogers <irogers@google.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
        "H. Peter Anvin" <hpa@zytor.com>, leit@fb.com,
        dcostantino@meta.com,
        "open list:PERFORMANCE EVENTS SUBSYSTEM" 
        <linux-perf-users@vger.kernel.org>,
        "open list:PERFORMANCE EVENTS SUBSYSTEM" 
        <linux-kernel@vger.kernel.org>
References: <20230616115316.3652155-1-leitao@debian.org>
 <20230616132954.GG4253@hirez.programming.kicks-ass.net>
 <ZQHiJxHSSGNk+ul5@gmail.com>
 <CAE4VaGBXO5Joynan_o13XpT=mNrwt4D84NTZF6H62GXJjpMbBA@mail.gmail.com>
 <f06ef3dd-dd71-4ba4-a4fa-18a08788c035@amd.com>
 <20230914091234.GE16631@noisy.programming.kicks-ass.net>
 <ZQLSw6PeUbV+p2gH@gmail.com>
 <20230914111845.GF16631@noisy.programming.kicks-ass.net>
From:   Sandipan Das <sandipan.das@amd.com>
In-Reply-To: <20230914111845.GF16631@noisy.programming.kicks-ass.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VU1VbGFvWG1aSlhFOWVRd1ZmM0NMWkNtaGN6dXIvRjd6ZFQ5ZTU2UlVkWkRa?=
 =?utf-8?B?US9SYTZObXJuVC9IK1RqS2lHYi82MmIvWjFXQVZiRFNDVC9TaGJtellxalM2?=
 =?utf-8?B?NmlpZEhuaU1OK0dROTg1T2p3dVVUSkQyVURxRTk2SjJtamVFQnN1dlBNZlkr?=
 =?utf-8?B?QkgxYTlwREwyV2piRVBZamtzcDhNNG5XQUwyamtrUXVVUS9mNS9SL0xNR01Q?=
 =?utf-8?B?SEptR0lTNTRGSk9pUjBOaTlKYm1jVUg5KzlndUdUVlNhbmVKLzdRcWcxVUE4?=
 =?utf-8?B?U3pVMTdVOUU3eXViKzlOak1IS1pCSThwL2t2VlZRUndOdVFYd1A3R01ieGtk?=
 =?utf-8?B?YlJ1TmxKNTh3dXlkR29jYVQ1RElBdkE4eUp6NGNuQjB3aS9EK3o5aVBpVml0?=
 =?utf-8?B?TDFadEdzd1JLcCtsN2wzK0ZvNmdjdUtUOC9sMTlsK255Z1F3Q1REYmhrVUNL?=
 =?utf-8?B?YlpSZU9CZnU2ZWJhQnluczVzaC9mZWNDeE5oUVBubm9VMkJ0UnFYMFU5WUJE?=
 =?utf-8?B?eU1Lb3RycUtKNUJtVEI4c2taWHZxOE9zU2NJYnQyeFA3Tk1NaU5tYU9GSmlJ?=
 =?utf-8?B?S1JySWlmY254NDVMNWs5Y1hvdzJRalhxVnl3M3lqYjZxcCtaaDQwNyswY2dY?=
 =?utf-8?B?UnUwaG5hNXg1UWpwVEc3cm5jdXpLTjhXNzNHOTBpZjhnSkViT3pucE5rclp2?=
 =?utf-8?B?cVdqWTM0SzJlamNBZUplY1puL21sNDNTMVgyYllNcjdYbXdBaVV3WC8raGJw?=
 =?utf-8?B?akthZDNCazBqYjI0bjdWRTFzWm53WGpEK2t5bFJZZlo3RWQ3dTdMeTJDcVlv?=
 =?utf-8?B?YkZBSmRBM0VXQzh1WngvYUhTSGFBK1RINURFY3I5eXpqMkNOcmpyYW5jSDVt?=
 =?utf-8?B?VXc5VjZORzFaNGg3b3VLTG55SmpGWDUvY0gxaGdRaVl2T1AvTWp1S1R4bG93?=
 =?utf-8?B?ZTlkR3IzbTNrZ1F1Z3o4TzFhMzdicWZRNWw3alI0Z2pNZTU5SEs4ckw3T3dr?=
 =?utf-8?B?MytCQ05LZVdPNFcrNGpLK0NzNG9yYU5SYjlZNVdvamZmWWV5ZDB4MmZCUXcr?=
 =?utf-8?B?ZE90SzNUWFIvZXZSaXFTTUQ3TzV0UzRiTHJ5OGI1dmdwa3ZnV0JhK1hhcmZF?=
 =?utf-8?B?ZWYwV1I1RkE3RG1wQnRKb3IxSThKeWsvTGhhZE5nQVlnaTZVRmhwWkJPeXUx?=
 =?utf-8?B?bGlCNWZwSWZMQmd2R2xVVzBiT3JNdTJNcnJ3REZMRzFIK21uUHRzOVlxaHZ5?=
 =?utf-8?B?SE9QcmV3MTI1cUhNNUErM2YvcHBQeUI3OVJPdFdXci9qMjNZdFlxeFVqVXZk?=
 =?utf-8?B?NUlvMVJsUW9kcTJTY2hNcktqbXhSYlhFd1lWRWtyeHBCbS8rOHc0NVZBTTcr?=
 =?utf-8?B?SUpnVE5ja0gyQjlEL08vd1J6NkQ5cnBkVmxPaVRUU3VvWi9IVTlFYlBadUdu?=
 =?utf-8?B?OE5ka3NhK3Ixa2dyNjJ3TFJUYkxIZk52aGxUZlJpeGs5UnJzVnVtbENlUEMv?=
 =?utf-8?B?a1NkNXJ5Z0VjWjhHVFYvZi9OTHkzMzBDZWxoNENkbWl0cUZ6TElDZHhsdkZB?=
 =?utf-8?B?dzVleU0yWXZyT3lwM1ZvU0x0dlFKZUlDbXZSWjVVQU5JUVlSZ210bll6V2VQ?=
 =?utf-8?B?dlZveDJ1dnFLaHV0ZmJZek5KbXhWVjNvY2NMSTFOODVQd1lIdU1MSWZpSXRK?=
 =?utf-8?B?TFJaV1JkRHJCV1lsOVdMcmdWT2laZmFLeDBpS05mSHFwbnljT2R0OXo4ZmJv?=
 =?utf-8?B?ZEh5MDl3RlNiaitsVjd5c01OdVB0UDZ0Vmp5bmY4dk9FYXB2dzhDcUIwcjNX?=
 =?utf-8?B?dnlwS0RWdmo3UVBMTlJXc1JxOUowT2dUakdlLzg5OElBMHVzbzdROFIwektE?=
 =?utf-8?B?bUhRV01XWFlkQXpkUHo2N25HSG1BRWJuTU1OWVJGcEFlQnJ0ZU1CeTJmd0NT?=
 =?utf-8?B?cVVuU1Q1T1dQLzdMV0M3SHdLWlltdHR6WHYxK0c1d3pVY0tWVDlyY25tcVVH?=
 =?utf-8?B?YklmWUhMbnBhS1k2cm9NVGxseHFXSGY2REQ2MXRSZWplbjNGalQ0RlpITFd0?=
 =?utf-8?B?VHdOVnZMRjF4SS9oNms1WlpBUzlESzJVQW1pV0xtUG02WFZFakFSWGJtVUNu?=
 =?utf-8?Q?A5SNw2MVwbkXmdpnegZxhxwdg?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cf458640-39f7-4f5a-e6b7-08dbb514dd50
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB5712.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2023 11:22:22.3756
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sZHvsfooJdW8jbS7A+R1Erj5atxRRokCTXI95mn9KM6uz7cqOIQOIcj58rT/1j7WAoUSe7xi+iTy55Xym/lctQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5058
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 14 Sep 2023 04:22:31 -0700 (PDT)

On 9/14/2023 4:48 PM, Peter Zijlstra wrote:
> On Thu, Sep 14, 2023 at 02:30:43AM -0700, Breno Leitao wrote:
>> On Thu, Sep 14, 2023 at 11:12:34AM +0200, Peter Zijlstra wrote:
>>> On Thu, Sep 14, 2023 at 02:25:40PM +0530, Sandipan Das wrote:
>>
>>>> I agree with using WARN_ON_ONCE() to make this less intrusive.
>>>
>>> Could you send a patch that AMD is happy with?
>>
>> Why the current patch is not good enough?
> 
> Sandipan, can you answer this? I don't tihnk I'm qualified to speak for
> the AMD pmu and certainly I don't have insight into their design future.

Hi Breno,

Functionally, the patch looks good to me and I will be reusing it
without any change to the authorship. However, as Peter suggested, I
wanted to add a message to prompt users to update the microcode and
also call out the required patch levels in the commit message since
different Zen 4 variants and steppings use different microcode.

Here's what I plan to send.

diff --git a/arch/x86/events/amd/core.c b/arch/x86/events/amd/core.c
index abadd5f23425..186a124bb3c0 100644
--- a/arch/x86/events/amd/core.c
+++ b/arch/x86/events/amd/core.c
@@ -909,6 +909,13 @@ static int amd_pmu_v2_handle_irq(struct pt_regs *regs)
                status &= ~GLOBAL_STATUS_LBRS_FROZEN;
        }

+       if (status & ~amd_pmu_global_cntr_mask)
+               pr_warn_once("Unknown status bits are set (0x%llx), please consider updating microcode\n",
+                            status);
+
+       /* Clear any reserved bits set by buggy microcode */
+       status &= amd_pmu_global_cntr_mask;
+
        for (idx = 0; idx < x86_pmu.num_counters; idx++) {
                if (!test_bit(idx, cpuc->active_mask))
                        continue;

--

Hi Peter,

There is another case where users will see warnings but the patch
to fix it (link below) is yet to be reviewed. May I rebase and
resend it along with the above?

https://lore.kernel.org/all/20230613105809.524535-1-sandipan.das@amd.com/