Date: Wed, 07 Nov 2007 00:10:45 -0800 (PST)
Message-Id: <20071107.001045.90391662.davem@davemloft.net>
To: bunk@kernel.org
Cc: toralf.foerster@gmx.de, dbrownell@users.sourceforge.net, jgarzik@pobox.com,
       linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [2.6 patch] let USB_USBNET always select MII
From: David Miller <davem@davemloft.net>
In-Reply-To: <20071101222524.GB7227@stusta.de>
References: <200711012024.57412.toralf.foerster@gmx.de>
	<20071101222524.GB7227@stusta.de>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1160
Lines: 34

From: Adrian Bunk <bunk@kernel.org>
Date: Thu, 1 Nov 2007 23:25:24 +0100

> All this USB_USBNET_MII trickery is simply not worth it considering how 
> few code it saves.
> 
> As a side effect, this also fixes the following compile error reported 
> by Toralf F?rster:
> 
> <--  snip  -->
> 
> ...
>   LD      .tmp_vmlinux1
> drivers/built-in.o: In function `usbnet_set_settings':
> (.text+0xf1876): undefined reference to `mii_ethtool_sset'
> drivers/built-in.o: In function `usbnet_get_settings':
> (.text+0xf1836): undefined reference to `mii_ethtool_gset'
> drivers/built-in.o: In function `usbnet_get_link':
> (.text+0xf18d6): undefined reference to `mii_link_ok'
> drivers/built-in.o: In function `usbnet_nway_reset':
> (.text+0xf18f6): undefined reference to `mii_nway_restart'
> make: *** [.tmp_vmlinux1] Error 1
> 
> <--  snip  -->
> 
> Signed-off-by: Adrian Bunk <bunk@kernel.org>

Applied, thanks Adrian.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/