Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Date:   Thu, 14 Sep 2023 12:47:26 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Dave Jiang <dave.jiang@intel.com>, Chen Ni <nichen@iscas.ac.cn>,
        <oohall@gmail.com>, <dan.j.williams@intel.com>,
        <vishal.l.verma@intel.com>, <ira.weiny@intel.com>,
        <aneesh.kumar@linux.ibm.com>
CC:     <nvdimm@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] libnvdimm/of_pmem: Use devm_kstrdup instead of
 kstrdup and check its return value
Message-ID: <6503634e78f61_35db1029469@iweiny-mobl.notmuch>
References: <20230914070328.2121-1-nichen@iscas.ac.cn>
 <8ff1ddf4-a3b7-2fed-5dfd-041aaaf981d2@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <8ff1ddf4-a3b7-2fed-5dfd-041aaaf981d2@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MizPwh5UiTx+nf9+IcRaBR/iE8usetcp7BGAJozo0N7NMdFxmI94TnGEp0M+?=
 =?us-ascii?Q?lxdQ/A2vWWLDydhUqK3Hc3FtOfAokPCLYGNl/BCfYHwwmzpCgHtCO8lfcwfF?=
 =?us-ascii?Q?Dl3G9CSBkmTOn+/tmFRy5mun744JefqCn2EJitio2CmL5W9kQQToBhz1WfRb?=
 =?us-ascii?Q?1+KMYbGAieL9YDYnO2ktCbOK7XarzDd1yQw5EbSrPLrVCc71ivjcRK8OujuO?=
 =?us-ascii?Q?2ZeYcFifqHa+8vk5eMUa+3HdahhAaZbxd2LQN7BHr6CQ1iKwJJr6f6wIQPz/?=
 =?us-ascii?Q?rE5y2fuJNYEgmw1UEmoPMoCFrHMVme8EbkRDJiiINN0KU9BduyZmWMup75Tx?=
 =?us-ascii?Q?9wk380K+3++zzTDLwARxsGBkZZAfdNR8PtBZAo8esWtg6QNDRA7zeuEG2c2H?=
 =?us-ascii?Q?8NTxNdknc7avl/oBt3ny8ZMFu1bC11kXJjWu4xr+VoX8/VZg/VS0oAZA32yc?=
 =?us-ascii?Q?ldXBGOO4PrmaoRdaC4k0/0SBZvmAA/F2ovoYrLjyVmy8gzoB6x6Oqj9/meoB?=
 =?us-ascii?Q?XF2ga5JaBHz7Tll3wjRHZxD5eJysjQ1O/f2X7q+mVYnHf/kK80lAVhbZtsbZ?=
 =?us-ascii?Q?k9R9Avw7kWnrryLn/oi4b8acsoDsihvk55bJtNVNgAPFiuE+2bWXgZ9BpLwB?=
 =?us-ascii?Q?KyW8K9021tIOp2oyWLaHjb01AoiTuX8v4E6HFytQkXyun4xFLtQm31rtZRWm?=
 =?us-ascii?Q?ASKoYUyTOhObNHG3NBYjpi3jY+H8AnpFFOd/v9srQJS6JNgL5rS3l7tpa9n4?=
 =?us-ascii?Q?9twF4qwq3QMaAz8pmsfgGpEpt4lScxnZ6JUc9PPzMbziA4+jhodgczfOI+G4?=
 =?us-ascii?Q?fikOTMuLmXTr+NoXMP41Mh8k8IZx3UTcl5BZDXfLl3UOsKzfRObmdYbGNe40?=
 =?us-ascii?Q?uVgkGN4S4fD0RLGyYWjlMrvAxW9J4OuVVq2TdhMbNjY4MMNhjryalYkYzTXg?=
 =?us-ascii?Q?J+d9wAIBWgM5BnNA2xsvPDdRRrUHwBdnJAPcO/CCuaqH7hfR+Rg4rZrheS1i?=
 =?us-ascii?Q?/uOAafboDHnsHclTb+6u6EHCpER27BUZNpF8+AyJFBLHE92E+WqzxXri26wd?=
 =?us-ascii?Q?lzjwhK/7nDsA+tP19fSb772bcL0BdoJUObnv2J9/EOvi4BfSOPjHAMzwOXwV?=
 =?us-ascii?Q?hugq21KHO1oms2Xw2xDJzTsx6n07hzPqQclywLNuRJVNwFsRsSCrgjrq/UMA?=
 =?us-ascii?Q?/myCcLobt0XGwPbeb4LsH1sk+jocxf7FCN1Eznlg7s0hIu3nS1EZ6KS4Pb0n?=
 =?us-ascii?Q?Im0IadZptubxKnrX8BMjJQdBxsIwTGtR48uXV4pdfm53yp46CrfCqiS8IWO5?=
 =?us-ascii?Q?6rP10sWqyWR9pLc5MaMvYHWjzQnVCeELSmvXpIs5AzHmAtMvg7eoYCqfx4O0?=
 =?us-ascii?Q?+woxutZTWMjdM9ENkTJMUtTcqC9F/rdGvlOCwJKbEsm8qlgyzfrXU9ygINXH?=
 =?us-ascii?Q?vaK24jav5ZkowDdoqfAX0DWR2e81MR0dg7DK2gosPE+32uxiY8nIYdsxgDxp?=
 =?us-ascii?Q?AYfHmb7mIFIzIHajXi/20o1XUN8vUKjaOJIigd1zS7cX0YOBtmO7Snbkck/N?=
 =?us-ascii?Q?vwP0UQfdZakfj2JyqRA9gMC/KFcWg5AiqDYRuOOC?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0b6d67eb-b556-4a5a-9a15-08dbb55b736b
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2023 19:47:40.0708
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +b4e/FeND0KG5tUPIev54zH2swZqfNzFNiUgPCa9lRXsY9xzMChMQD5BecWPDiBfREIrVLIt3ArZfRZRVHtjxQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4984
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 14 Sep 2023 12:47:54 -0700 (PDT)
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email

Dave Jiang wrote:
> 
> 
> On 9/14/23 00:03, Chen Ni wrote:

[snip]

> > diff --git a/drivers/nvdimm/of_pmem.c b/drivers/nvdimm/of_pmem.c
> > index 1b9f5b8a6167..5765674b36f2 100644
> > --- a/drivers/nvdimm/of_pmem.c
> > +++ b/drivers/nvdimm/of_pmem.c
> > @@ -30,7 +30,13 @@ static int of_pmem_region_probe(struct platform_device *pdev)
> >  	if (!priv)
> >  		return -ENOMEM;
> >  
> > -	priv->bus_desc.provider_name = kstrdup(pdev->name, GFP_KERNEL);
> > +	priv->bus_desc.provider_name = devm_kstrdup(&pdev->dev, pdev->name,
> > +							GFP_KERNEL);
> > +	if (!priv->bus_desc.provider_name) {
> > +		kfree(priv);
> 
> I wonder if priv should be allocated with devm_kzalloc() instead to reduce the resource management burden. 

I think it could be but this is the driver and I wonder if leaving the
allocation around until the platform device goes away was undesirable for
some reason?

Ira