Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
From:   Rahul Rameshbabu <rrameshbabu@nvidia.com>
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     linux-kernel@vger.kernel.org, Jiri Kosina <jkosina@suse.cz>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        linux-input@vger.kernel.org
Subject: Re: [PATCH] HID: nvidia-shield: add LEDS_CLASS dependency
References: <20230914000517.16252-1-rdunlap@infradead.org>
Date:   Wed, 13 Sep 2023 19:09:08 -0700
In-Reply-To: <20230914000517.16252-1-rdunlap@infradead.org> (Randy Dunlap's
        message of "Wed, 13 Sep 2023 17:05:17 -0700")
Message-ID: <87r0n14ibf.fsf@nvidia.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rAsj1cHXLxoA5YHQ4xqbYbTcVqmkDit3fYtwVBkIRh67b7HwToOhMvl0oezc?=
 =?us-ascii?Q?jaCt+h+Q9IDolWk/4zVsVrLyPMNsueZ6Uk2DIjZc2JNTh5VhXyQ/boWCKcpO?=
 =?us-ascii?Q?/adxVvMOF+J0pOVJAFEDElvZVVs0yAk0+3/NcJ+hEHCilDHVEHKtSINte+8y?=
 =?us-ascii?Q?Jkg85F8C0zuNh61Rkz1gDqA49sIvk+/xqm62evKPhS5PaY5B1mWA4MDYYz/B?=
 =?us-ascii?Q?/spy7aDVzPX3qXVjPVz2ZpDf3huEUg7FxbvK2Cow0KE1T4WERxuksW6yVwe4?=
 =?us-ascii?Q?QV0fyTs+sXFC5krftItydBYLzSs5omjFKTkj8jd3mrD1xe58LiU1mD735Xdd?=
 =?us-ascii?Q?hyZ33zFYEE6xbm8WdlJpYAfIXN3Wfi5O7qcWIT/OzEXISv7MxmUvzXnaENbV?=
 =?us-ascii?Q?gSc6we3E4QMA4okKF01tx5P95oCQFdoEqGYT1Iw4+pkM97RpGltO5qfIlRtu?=
 =?us-ascii?Q?WV0yIBIjiLhDM0tV5VHrZwWU12iS8yVlOQRKScyR9m+XK/XuTWlvty8FLJll?=
 =?us-ascii?Q?lczcB/hzNhbMdRczO89kdD5WKhoZXX0ZHyHEyKA075Tk0KemvUZYAfzsVYmU?=
 =?us-ascii?Q?AOtwlPKf2/nOyAMKGBtndVowk+mebzKCnywhmYTsCnwacuDYiFeT2ISwcBgU?=
 =?us-ascii?Q?TWwEgr5Kl+/fB9IfPSgByMsD5/BMgWK70KbE5kWuylWWdBtVFfasyMHA7WTF?=
 =?us-ascii?Q?OEJryACq9a+52v5Rfrzgm1jRiuwtc5jzgQCWxOx/aKHNioVaNbBL8maoNQFf?=
 =?us-ascii?Q?icbqM7PKG14EdEW7NKgxD0Rr7pNuOSgblt2ujPksN0zBa2L6iZJzB1TQ8E/a?=
 =?us-ascii?Q?rmvHO/LSZM9hksQgUFqS+emi79nesQXOH17GsHJ109ArjLmXMgvj9U60K+vv?=
 =?us-ascii?Q?hcI84NA58Fwp7IjU/nMxi7fJhHI6ZjtWlRwl4znkhRf9kI4tjmPnR/uSnYh/?=
 =?us-ascii?Q?USF52z1G7zB0JOHZ2YAnQhwv4lKj6RvZFwcjHr4fMdMnvQLtr9nMfvhHcX2V?=
 =?us-ascii?Q?QwuC3c2IrWFilcY+vDkysFUfCMf7Wi43brQVRmqbziwOvAP7Wq87/OW1JQTt?=
 =?us-ascii?Q?xIIITeIIrZWJFxTfkhpI3BfdlOKqdFUvP7YuwY7nT5ldIgUUMJw4V2Fb3JXl?=
 =?us-ascii?Q?OJ8oGPqOdNhz6vZHCnu4pr6flbO/zo8hkV0ojxHHwEoRqGTZmIPL46YDflzL?=
 =?us-ascii?Q?W511POeX4qHPWVc6DctXes2bMVOovFGZLNWGbqTI2QQTzK+I8do5Ir7LA8Zt?=
 =?us-ascii?Q?g4eMHl+rktS4kIWzrpcJGKWuGieNDQGhBVeZt5I2JCucOZBrFZD4BJsdkgRH?=
 =?us-ascii?Q?qHeyx4A9UaHTDOmz0v2mmLCiZbY9N26r8hAyzrR4ab833ASpiMAAxiJ0x56T?=
 =?us-ascii?Q?Zaj/AVgZWx5GBH0it805QcKJDZLvyEDuf1fr46xTPvlmLqsqQtPY5WUyNEzf?=
 =?us-ascii?Q?jHycXXQemeDVIcUfnGuxk7LrZSGz86YSL5yOnev0eQLgYFosjl8pjPN7eNUd?=
 =?us-ascii?Q?7Q8tXu9J7+tSFd1+dcxuMXljB9gAavzzZJRR9JjLcuhMxyO68w2/EgBqMFHv?=
 =?us-ascii?Q?xDjG6GK8wXgHE3gJbQ2K7FYE8+rKLLvWx+iaBnyH?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d9ed9abc-2240-48e3-8f62-08dbb4c799f3
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2743.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2023 02:09:17.8957
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 200xd/wbY8yqD/CH9h+lIiCJzRgxLp1kUeW4/NFRUMU7hTtNz5R9N1ZAI2F/V2brB8vmVeZCTcoAUgDFmIjckw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8181
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 13 Sep 2023 19:10:08 -0700 (PDT)
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email

On Wed, 13 Sep, 2023 17:05:17 -0700 Randy Dunlap <rdunlap@infradead.org> wrote:
> The hid-nvidia-shield driver uses functions that are built
> only when LEDS_CLASS is set, so make the driver depend on that
> symbol to prevent build errors.
>
> riscv32-linux-ld: drivers/hid/hid-nvidia-shield.o: in function `.L11':
> hid-nvidia-shield.c:(.text+0x192): undefined reference to `led_classdev_unregister'
> riscv32-linux-ld: drivers/hid/hid-nvidia-shield.o: in function `.L113':
> hid-nvidia-shield.c:(.text+0xfa4): undefined reference to `led_classdev_register_ext'
>
> Fixes: 09308562d4af ("HID: nvidia-shield: Initial driver implementation with Thunderstrike support")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Rahul Rameshbabu <rrameshbabu@nvidia.com>
> Cc: Jiri Kosina <jkosina@suse.cz>
> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> Cc: linux-input@vger.kernel.org
> ---
>  drivers/hid/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
>
> diff -- a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -799,6 +799,7 @@ config HID_NVIDIA_SHIELD
>  	tristate "NVIDIA SHIELD devices"
>  	depends on USB_HID
>  	depends on BT_HIDP
> +	depends on LEDS_CLASS
>  	help
>  	  Support for NVIDIA SHIELD accessories.

Thanks for the patch. This also reminds me that the same needs to be
done for POWER_SUPPLY since support was added for the controller's
battery. I will send out a patch for that soon.

Reviewed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>