Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp4241284rdb; Thu, 14 Sep 2023 16:57:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEtrtCIuiJ+xulSV2jpBR2Zt481f2anSICUPgweI8wsrkBVeHvdf+OtyImbzIG9xt7SH564 X-Received: by 2002:a05:6a21:a590:b0:153:40c3:aa71 with SMTP id gd16-20020a056a21a59000b0015340c3aa71mr315153pzc.43.1694735825495; Thu, 14 Sep 2023 16:57:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694735825; cv=none; d=google.com; s=arc-20160816; b=055r96/OlTddaE4doiOnYTHmaKWKYdZPM/WKM4+XOAaqLkmTtnxrbXafvtvfdKFG9E kfIWTmBj2ZyH7av2TV2o1O1N5ylG4IdPgwStQMsbD/An8dyh/zxDrx4x8rlbcGk9HqGk qPTk5+xU5kvwZDrvsCuD1cep4y0fsM2fP0o3J95FeIwytjp/beql+8+GYoTMYA2htYA0 5dWIS0MeLJ2nhz4Vh/XFhlX6neqSyMJ/UePSibB5J8hpIXFlT5xzaCha3exXva+3mWGe isMwM3ZPI2wEPQpqYutw2JWtCyrXhRyk52qbRI1ypfKb6m2O+vz51NmktjSSvJAq3W80 qNzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=oaOaUdxJgZnLuYhBrckJP0eFDQeLYiIGdcGaFrUUAno=; fh=Zg+EhkgR7kRUwW4CnMB1CP5X3EYZZMExEKv5HDkYFEE=; b=XD+Fge0oBTj6KbMNxwj559DMvh0hFdcQ0dBL/L1hxO+6mewvHDBjIHqUa/LoBwjxY8 oTCGSsuiKZZoZsc5vIuMp+v7qh/O7mVtAp+RXsa13uTiHlm4v0BvlgpJVeiBXM7zXkJv ordmf0lKG7l9VCl1sDJk7bJqLMVsSIKD6RDgLa/A+03t0twdDHaYCUycMQoV8WtJVmlA +X4RYlFcUB+hRa7QZ5kYgMklRsgKLKFYMQXvs7Gop32VU/Sc3Z8AE9us9ecOutW1fqTX XopnjkMj8FRXhv/X/U205lNsL6/6+x/A8BZNMowu+eAQo/IaWoB0Af2LD9jgpwzM+0Qc 2y/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="MaxLcaH/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id z21-20020a631915000000b005775302b11csi2283059pgl.81.2023.09.14.16.57.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Sep 2023 16:57:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="MaxLcaH/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 38F0680743E2; Thu, 14 Sep 2023 15:25:49 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229959AbjINWZu (ORCPT + 99 others); Thu, 14 Sep 2023 18:25:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229487AbjINWZt (ORCPT ); Thu, 14 Sep 2023 18:25:49 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8960B2100; Thu, 14 Sep 2023 15:25:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694730345; x=1726266345; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Mh8fE6vgowiAhHm4fpC4Alsp4aaY+wRem+ZyVjBKytg=; b=MaxLcaH/ANp911yYyp8wPYrf/sGiAibh7IDXd/m8xgXlfE/IBLNnbDhR pVGaY9pN4w0oug+mcgRS9MDDeqhqEfpycwPO0Irp3UPa+MZg/b4XEZ/0+ 2Yebe3Vzu7C+32qws6MJzm8BDb5usmbOjTTyExnXJ2684/wf6YMKGrwKi JPx+UjS1YBSFekdFWFBfQ43vRTXXOL7wmJKM6CnDf/CzONdQ2jE9Js6r2 sZ+W7I6cqBDFRJC0C/aeWEv/qwP3ZT18JMfJrcVzgjhlmblbEPKr5Wzjq 3B3u/3WnhEjmtdUW8QxW/AGvfO22fNaMDj4kDHcabX58eCw/iCrzXz2GZ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10833"; a="410033378" X-IronPort-AV: E=Sophos;i="6.02,147,1688454000"; d="scan'208";a="410033378" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2023 15:25:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10833"; a="1075553706" X-IronPort-AV: E=Sophos;i="6.02,147,1688454000"; d="scan'208";a="1075553706" Received: from powerlab.fi.intel.com ([10.237.71.25]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2023 15:25:43 -0700 From: Michal Wilczynski To: linux-acpi@vger.kernel.org Cc: rafael@kernel.org, linux-kernel@vger.kernel.org, lenb@kernel.org, Michal Wilczynski Subject: [PATCH v1] ACPI: processor_pdc: Fix uninitialized access of buf Date: Fri, 15 Sep 2023 01:25:27 +0300 Message-ID: <20230914222527.3472379-1-michal.wilczynski@intel.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 14 Sep 2023 15:25:49 -0700 (PDT) Bug was introduced during unification of setting CAP_SMP_T_SWCOORD for _PDC and _OSC methods. Third u32 in buffer is never being zero-ed before setting bits on it. The memory is not guaranteed to be zero as it was allocated by kmalloc() instead of kzalloc(). Fix this by initializing third u32 in buffer to 0. Fixes: b9e8d0168a7a ("ACPI: processor: Set CAP_SMP_T_SWCOORD in arch_acpi_set_proc_cap_bits()") Signed-off-by: Michal Wilczynski --- drivers/acpi/processor_pdc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/acpi/processor_pdc.c b/drivers/acpi/processor_pdc.c index 1a8591e9a9bf..994091bd52de 100644 --- a/drivers/acpi/processor_pdc.c +++ b/drivers/acpi/processor_pdc.c @@ -19,6 +19,7 @@ static void acpi_set_pdc_bits(u32 *buf) { buf[0] = ACPI_PDC_REVISION_ID; buf[1] = 1; + buf[2] = 0; /* Twiddle arch-specific bits needed for _PDC */ arch_acpi_set_proc_cap_bits(&buf[2]); -- 2.41.0