Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
From:   Paul Durrant <xadimgnik@gmail.com>
Message-ID: <8419c105-205a-bd25-b84a-ed81a9447bd1@xen.org>
Date:   Thu, 14 Sep 2023 15:58:11 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.0
Reply-To: paul@xen.org
Subject: Re: [PATCH 5/8] KVM: pfncache: allow a cache to be activated with a
 fixed (userspace) HVA
Content-Language: en-US
To:     David Woodhouse <dwmw2@infradead.org>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Paul Durrant <pdurrant@amazon.com>,
        Paolo Bonzini <pbonzini@redhat.com>
References: <20230914084946.200043-1-paul@xen.org>
 <20230914084946.200043-6-paul@xen.org>
 <30eece756f273881b276f8069ab30692ded5af49.camel@infradead.org>
Organization: Xen Project
In-Reply-To: <30eece756f273881b276f8069ab30692ded5af49.camel@infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 14/09/2023 14:51, David Woodhouse wrote:
> On Thu, 2023-09-14 at 08:49 +0000, Paul Durrant wrote:
>> --- a/include/linux/kvm_types.h
>> +++ b/include/linux/kvm_types.h
>> @@ -64,7 +64,8 @@ struct gfn_to_hva_cache {
>>   
>>   struct gfn_to_pfn_cache {
>>          u64 generation;
>> -       gpa_t gpa;
>> +       unsigned long addr;
> 
> On 32-bit hosts gpa_t is 64 bits and doesn't fit in an 'unsigned long'
> 

Damn. So used to the host only ever being 64-bit. A u64 it is then.

>> +       bool addr_is_gpa;
> 
> Don't put that there. There are already bools at the end of the struct
> which wouldn't leave 63 bits of padding.
> 

True. Will move.

   Paul