Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
From:   Michael Ellerman <mpe@ellerman.id.au>
To:     Tyrel Datwyler <tyreld@linux.ibm.com>,
        Yuanjun Gong <ruc_gongyuanjun@163.com>,
        Nicholas Piggin <npiggin@gmail.com>,
        Christophe Leroy <christophe.leroy@csgroup.eu>,
        linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] powerpc: fix a memory leak
In-Reply-To: <54bf92e8-f884-1567-2149-caf638ff8f68@linux.ibm.com>
References: <20230914094620.3379729-1-ruc_gongyuanjun@163.com>
 <54bf92e8-f884-1567-2149-caf638ff8f68@linux.ibm.com>
Date:   Fri, 15 Sep 2023 10:50:28 +1000
Message-ID: <87il8c6yzv.fsf@mail.lhotse>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Tyrel Datwyler <tyreld@linux.ibm.com> writes:
> On 9/14/23 02:46, Yuanjun Gong wrote:
>> When one of the methods xive_native_alloc_irq_on_chip, irq_create_mapping
>> or irq_get_handler_data fails, the function will directly return without
>> disposing vinst->name and vinst. Fix it.
>> 
>> Fixes: c20e1e299d93 ("powerpc/vas: Alloc and setup IRQ and trigger port address")
>> Signed-off-by: Yuanjun Gong <ruc_gongyuanjun@163.com>
>> ---
>>  arch/powerpc/platforms/powernv/vas.c | 14 +++++++++-----
>>  1 file changed, 9 insertions(+), 5 deletions(-)
>> 
>> diff --git a/arch/powerpc/platforms/powernv/vas.c b/arch/powerpc/platforms/powernv/vas.c
>> index b65256a63e87..780740b478f0 100644
>> --- a/arch/powerpc/platforms/powernv/vas.c
>> +++ b/arch/powerpc/platforms/powernv/vas.c
>> @@ -54,7 +54,7 @@ static int init_vas_instance(struct platform_device *pdev)
>>  	struct xive_irq_data *xd;
>>  	uint32_t chipid, hwirq;
>>  	struct resource *res;
>> -	int rc, cpu, vasid;
>> +	int rc, cpu, vasid, ret;
>
> You can you reuse rc for the return value in the error path instead of
> introducing a new ret variable.

Yep, please send a v2.

cheers