Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
From:   Ilkka Koskinen <ilkka@os.amperecomputing.com>
To:     Will Deacon <will@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        Suzuki K Poulose <suzuki.poulose@arm.com>,
        Besar Wicaksono <bwicaksono@nvidia.com>,
        Robin Murphy <robin.murphy@arm.com>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Ilkka Koskinen <ilkka@os.amperecomputing.com>
Cc:     linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-doc@vger.kernel.org
Subject: [PATCH v7 3/4] perf: arm_cspmu: Support implementation specific validation
Date:   Wed, 13 Sep 2023 16:39:40 -0700
Message-Id: <20230913233941.9814-4-ilkka@os.amperecomputing.com>
In-Reply-To: <20230913233941.9814-1-ilkka@os.amperecomputing.com>
References: <20230913233941.9814-1-ilkka@os.amperecomputing.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FwZL8D/88+d2pU64tOe06sTXGNt/nDackjroEwhlf6P21Nh0Hb6RO5M61HpS?=
 =?us-ascii?Q?4i9TmxH/3jkd0el6pgG70lsg0kE1O+FC7mVqakIux0iXU+kDVeVaowoNnjRx?=
 =?us-ascii?Q?mvMebrpWQpFctGIOQFpRMX7nCISlPYyBnlGJrmJ04u7BdTOHts7s9/9xQyUH?=
 =?us-ascii?Q?l2/NRgoLTwILoLm2R331QbC01oOCkB8zTgZSGtKJLU5h96Ky4C3NDIuX6Q07?=
 =?us-ascii?Q?xPGAAaZlgqMt6tyIBkeGrHbDzvuXJw1cwe8W4RpRioJSNtUNVQqYD0UkQF/X?=
 =?us-ascii?Q?KftB4KvFNO3TV6YIcICldxheCzLQ5YjhP7Gzs0Iia1eYv+3Hn0S5/j2Puh9+?=
 =?us-ascii?Q?4cBlabosqL/NCgVjFNRC5N7hl2uxZJsAvxU78Rg9RXEkURhIxpZkiATEC6Cd?=
 =?us-ascii?Q?TMxWUPmuuWyw0fx8B3cviWYqHZo60dQIK3Lss+1AH75oeK+NXuQvE5MkS1ez?=
 =?us-ascii?Q?RsRr6UPsZioqZe6i9HA8KOaXTIR7P/1joUwH3hhGhJGMH+9LZ58li9kFTNNu?=
 =?us-ascii?Q?E289YRrV2RVIwP/f/aXbtRn7YulFfE94lsTlenWQETPeE+IJtpyAvSWwdUGE?=
 =?us-ascii?Q?GJfZBVto0rZSSHSdBbWxEP3Ble7OT8yhGTSUix16eXG7gnO++dXZ9RUNhNPZ?=
 =?us-ascii?Q?G4woR4LTsG6hJX36rRiB/2Rc42qV6IbKeB+SfzHTur2LMRx2+A6la5EXcEYQ?=
 =?us-ascii?Q?JSlSancmxFLHdj1lX7MlZDkE9P04G3L8/+6sUkBXizkx7XxscHSEEucLmwXg?=
 =?us-ascii?Q?yoeLi+a7pFRoZK60lzSSXgyBToqc5ux/0AL76z1m8PVRQ+reZ4O4bI1IeFHP?=
 =?us-ascii?Q?Vzww7uZ62dTwdOqWtsZpqAaGe4HhSaOFI8GNJYqCKq0ELDAfRhJsba3F6Hu1?=
 =?us-ascii?Q?q8cKvQpJzrMCfp+HmyJim/B6LqH0t26NG/cvk8uJmHTNKcHP9HKOEgt4is2I?=
 =?us-ascii?Q?pLHSfY/deWJKf0UhZYeBoW0uDvC5s8r0xdsMGZAkkQapyf9wwSnDj4ypjzT6?=
 =?us-ascii?Q?Pn7EBdL9Z8CK8Cgmj8A0AdPc6BIKpdBGEiS6Zxv8MEkoDZtJNrlPJL+folQ1?=
 =?us-ascii?Q?XKfVazgxObrJh0F/4/NjiLB/H5E4diDq/CXTGa0zfaWijeSuwKSmVpsImrUf?=
 =?us-ascii?Q?ekksJAIZIwRO6C4jH+SXaRwiHnk0487vH2YzCT9eo65u5D89aVcvZEi7mBAD?=
 =?us-ascii?Q?EY7Z5rRa7kGZZ75dODVtlyK18/HzGyGgYFrheCJxITX2Uwt5QcReVnOgwJsJ?=
 =?us-ascii?Q?paUlnagAVGfw+n/2VF/9+zyJwUyI8ocZO68b8za2gzXAWs/HQiSJa8Ay62bD?=
 =?us-ascii?Q?2ZvcA6N8j51TgNKLwAy4IeWZfI2z4zS/oq6vtSr8q0VZnQhYvzGlKdKiV6S3?=
 =?us-ascii?Q?EjXlsv8vywAFL+WZ7ogGf4omYY6r2pligzuUc8kr9/GbO+0PTLj3RsTpuyUp?=
 =?us-ascii?Q?HcHjVO6OELLITOJl3rXxKGRCfnQ4cwtmgQgZu0TuszHxnABY33VPIGolIs3F?=
 =?us-ascii?Q?S9dAiDKzGNMgG77otIiPOQuY+R9JNANqQXpmhD8zwgFTRlx5iXJ9ZkWBa/86?=
 =?us-ascii?Q?/aNC+wgrx8WQ+pMfmzoZ6EwlSSd0jIpexXJ1aqNVYh2/2BihtnjVIffRP8OC?=
 =?us-ascii?Q?enYpJNZTmuqkWRcRp9ftywU=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cd72b84a-bd02-4238-6049-08dbb4b2e783
X-MS-Exchange-CrossTenant-AuthSource: DM5PR0102MB3590.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2023 23:41:08.5293
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QaCvjXbD3Cl//tBOkPA1h0voDF42/F3nHO4+IXn2xKW8sEb6VE826keAKmB29YBfcuru50We4ugxIgRWNFGpJ2HeS/7cTWAoexzF8FaM+yDi31HeOwkTSMj/oufazCin
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR01MB6241
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 13 Sep 2023 16:41:34 -0700 (PDT)
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email

Some platforms may use e.g. different filtering mechanism and, thus,
may need different way to validate the events and group.

Signed-off-by: Ilkka Koskinen <ilkka@os.amperecomputing.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
---
 drivers/perf/arm_cspmu/arm_cspmu.c | 8 +++++++-
 drivers/perf/arm_cspmu/arm_cspmu.h | 3 +++
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/drivers/perf/arm_cspmu/arm_cspmu.c b/drivers/perf/arm_cspmu/arm_cspmu.c
index 2ecbf8d7714b..1ba00d640352 100644
--- a/drivers/perf/arm_cspmu/arm_cspmu.c
+++ b/drivers/perf/arm_cspmu/arm_cspmu.c
@@ -576,7 +576,7 @@ static void arm_cspmu_disable(struct pmu *pmu)
 static int arm_cspmu_get_event_idx(struct arm_cspmu_hw_events *hw_events,
 				struct perf_event *event)
 {
-	int idx;
+	int idx, ret;
 	struct arm_cspmu *cspmu = to_arm_cspmu(event->pmu);
 
 	if (supports_cycle_counter(cspmu)) {
@@ -610,6 +610,12 @@ static int arm_cspmu_get_event_idx(struct arm_cspmu_hw_events *hw_events,
 	if (idx >= cspmu->num_logical_ctrs)
 		return -EAGAIN;
 
+	if (cspmu->impl.ops.validate_event) {
+		ret = cspmu->impl.ops.validate_event(cspmu, event);
+		if (ret)
+			return ret;
+	}
+
 	set_bit(idx, hw_events->used_ctrs);
 
 	return idx;
diff --git a/drivers/perf/arm_cspmu/arm_cspmu.h b/drivers/perf/arm_cspmu/arm_cspmu.h
index e0cca5b4aab9..a30c8372214c 100644
--- a/drivers/perf/arm_cspmu/arm_cspmu.h
+++ b/drivers/perf/arm_cspmu/arm_cspmu.h
@@ -107,6 +107,9 @@ struct arm_cspmu_impl_ops {
 	/* Set event filter */
 	void (*set_ev_filter)(struct arm_cspmu *cspmu,
 			      struct hw_perf_event *hwc, u32 filter);
+	/* Implementation specific event validation */
+	int (*validate_event)(struct arm_cspmu *cspmu,
+			      struct perf_event *event);
 	/* Hide/show unsupported events */
 	umode_t (*event_attr_is_visible)(struct kobject *kobj,
 					 struct attribute *attr, int unused);
-- 
2.40.1