Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp4273040rdb; Thu, 14 Sep 2023 18:17:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHGre1cYwPcNzrpzKBmIaz7t3O0VhNzK3TDj3Zs3WLiIdKQLNz8MBc+tWs6oHuQRWyXPuip X-Received: by 2002:a54:4790:0:b0:3a8:1727:5af4 with SMTP id o16-20020a544790000000b003a817275af4mr264475oic.24.1694740636999; Thu, 14 Sep 2023 18:17:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694740636; cv=none; d=google.com; s=arc-20160816; b=cPfqN9neAwoSwoSO4KrEE8G20SRaOlaNR547uA6MqztE0ZAJjQU3OEXRJ2Y9SxlKgS Q88R/yFM9gMrj/Pc0UFjzWpsKqqvhR8NmIaN8wa43m623Xp76/34IYdEHjoNNwIILD/w zGNkf5P972IQ8tBbpJoEnrhm/P9aTQCma8gQkaanQoVpSxjrn2/BDaCM3qJXj3FIOuc8 9StOBgaQtsgc/Bxdc0UnlCUflRGqwy76s581ENx7EnJbkTc1d3e+opgIUvVT9w9uLhqQ sOTBtqC7Svqv6q9211lzBqpRHggIKwL4hH+GdYc5Njj8Pe9ZEz0g55JrZpK2ChVaaXI+ Rhtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=AWjszMGAWwAmKRftVpe0hRnvM8CrBy/Ah5EmpYh7ovU=; fh=HP0u6UTDta/+GqBM4mahf5Lc0EVr0KtIYijFiIYMcHg=; b=bGokQUMUUyGVJ1UFajtzwfkJmqe7Wmt9V2Tz6pD3tN0DHWk5BITnrgXfJPVgyK2eCh UZZg84UPz/sEAjXSvl5t9odL3Kbgsv+CPDm9OmxNOuHDbpzGqoRy08b3ogMF2Rig3n2b PTm7rR/t3bF+WVL6F+C6TBogI+7ebLG5qiKJ2MwFUwJXyQ8vGbObjFCzon64NxxVax37 xVnhEzFgEAdZ0UlI6fetK4H1lL9zte0zNYrAQI7N0hJqc6CTD2bOOtjPwQhKoyCoAL4d LaTRnYYgGFj6s7kwvzo0b4OrgRZ6RdW6bbGZi2hnZEhqfOdMRxowBg0thWFeIu9MQhRK 3Arg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=weob5U3W; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id cj11-20020a056a00298b00b00682759c6440si2413472pfb.40.2023.09.14.18.17.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Sep 2023 18:17:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=weob5U3W; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 8070D830D617; Wed, 13 Sep 2023 18:55:36 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233741AbjINBzY (ORCPT + 99 others); Wed, 13 Sep 2023 21:55:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233796AbjINBzQ (ORCPT ); Wed, 13 Sep 2023 21:55:16 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA9D41BD0; Wed, 13 Sep 2023 18:55:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=AWjszMGAWwAmKRftVpe0hRnvM8CrBy/Ah5EmpYh7ovU=; b=weob5U3WI1KVyn80QQzY4IVrs3 Nu306fsr4NyATTTU73asLYk0ASWuNiui/fHYecrXRng8P4gemkx5OKzRiSEHeYtAkLJdb9ecLALXA vmDY/cl+pk5uWrdFXRhJvFuizdBcO2baumL2Qwv6PLff/BrMMV92n+IQSMnnAUtJYwpE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1qgbZP-006M7W-W0; Thu, 14 Sep 2023 03:55:03 +0200 Date: Thu, 14 Sep 2023 03:55:03 +0200 From: Andrew Lunn To: Parthiban Veerasooran Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, corbet@lwn.net, steen.hegelund@microchip.com, rdunlap@infradead.org, horms@kernel.org, casper.casan@gmail.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, horatiu.vultur@microchip.com, Woojung.Huh@microchip.com, Nicolas.Ferre@microchip.com, UNGLinuxDriver@microchip.com, Thorsten.Kummermehr@microchip.com Subject: Re: [RFC PATCH net-next 5/6] microchip: lan865x: add driver support for Microchip's LAN865X MACPHY Message-ID: <8d5078b0-1a45-43ac-89bd-c71c514336f5@lunn.ch> References: <20230908142919.14849-1-Parthiban.Veerasooran@microchip.com> <20230908142919.14849-6-Parthiban.Veerasooran@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230908142919.14849-6-Parthiban.Veerasooran@microchip.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 13 Sep 2023 18:55:36 -0700 (PDT) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email > +#define REG_STDR_RESET 0x00000003 This appears to be a standard register, so you should not need to define it here. > +#define REG_MAC_ADDR_BO 0x00010022 > +#define REG_MAC_ADDR_L 0x00010024 > +#define REG_MAC_ADDR_H 0x00010025 > +#define REG_MAC_NW_CTRL 0x00010000 > +#define REG_MAC_NW_CONFIG 0x00010001 > +#define REG_MAC_HASHL 0x00010020 > +#define REG_MAC_HASHH 0x00010021 > +#define REG_MAC_ADDR_BO 0x00010022 > +#define REG_MAC_ADDR_L 0x00010024 > +#define REG_MAC_ADDR_H 0x00010025 > + > +#define CCS_Q0_TX_CFG 0x000A0081 > +#define CCS_Q0_RX_CFG 0x000A0082 These are proprietary vendor registers, so please add a prefix to make this clear. Andrew