Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-745-g95dd7bea33-fm-20230905.001-g95dd7bea
Mime-Version: 1.0
Message-Id: <73cdb822-4819-4621-bbd0-de60392552b5@app.fastmail.com>
In-Reply-To: <70e9fe45ca8bbe2dec5541a0c21bee3de8f82f91.camel@physik.fu-berlin.de>
References: <20230802184849.1019466-1-arnd@kernel.org>
 <20230802184849.1019466-4-arnd@kernel.org>
 <CAMuHMdVjmD357K-yxxW-jn-6vKsXTg+u1Psw9DftyxH=dQoMEg@mail.gmail.com>
 <5dad2d86-78ea-4a39-8ee1-98e3eb134d36@app.fastmail.com>
 <CAMuHMdVYcvPL+JpPw9sA48=615cdfwa8d0LP-bVp0NWqbQ+JOw@mail.gmail.com>
 <190041c8-2d99-4bc3-adc3-6fbe902c1265@app.fastmail.com>
 <70e9fe45ca8bbe2dec5541a0c21bee3de8f82f91.camel@physik.fu-berlin.de>
Date:   Thu, 14 Sep 2023 17:56:54 +0200
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "John Paul Adrian Glaubitz" <glaubitz@physik.fu-berlin.de>,
        "Geert Uytterhoeven" <geert@linux-m68k.org>
Cc:     "Arnd Bergmann" <arnd@kernel.org>, linux-sh@vger.kernel.org,
        "Rich Felker" <dalias@libc.org>,
        "Yoshinori Sato" <ysato@users.sourceforge.jp>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] sh: machvec: remove custom ioport_{un,}map()
Content-Type: text/plain
Precedence: bulk

On Thu, Sep 14, 2023, at 08:23, John Paul Adrian Glaubitz wrote:

> On Wed, 2023-09-13 at 16:30 +0200, Arnd Bergmann wrote:
>> > In the meantime, there is a v2, which I wasn't aware of when I wrote
>> > my previous email, so perhaps my comment is no longer valid.
>> > "[RFC PATCH v2 00/30] Device Tree support for SH7751 based board"
>> > https://lore.kernel.org/linux-sh/cover.1694596125.git.ysato@users.sourceforge.jp
>> 
>> Right, it looks like the GENERIC_IOMAP part if gone from that
>> series, and I also see that the PCI host bridge does not actually
>> map the port I/O window. That's usually fine because very few
>> drivers actually need it, and it also means that there should be
>> no need for GENERIC_IOMAP or the simpler alternative.
>> 
>> The first version probably only did it accidentally, which is a
>> common mistake, and I think the ones for hexagon, m68k, and
>> mips can probably be removed as well with some simplifiations.
>> 
>> x86 and ia64 want GENERIC_IOMAP because they require using
>> custom instructions for accessing IORESOURCE_IO registers,
>> but it's not really generic.
>
> Would you suggest to apply your series before or after Yoshinori's series to
> convert arch/sh to device trees? If you want it to go in before the conversion,
> could you rebase your series against v6.6-rc1?
>
> I'm asking because the current version did not apply against v6.5-rc2.

I've rebased and resent the series now, with no other changes
added in. I expect that you can apply it in either order now
if the other series no longer relies on GENERIC_IOMAP.

    Arnd