Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp4300804rdb; Thu, 14 Sep 2023 19:39:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFwlzZzDzdcJ5n78x6j4CeuxBrOMh6csjFtwKyF2YGl1pVWX6xRhlQV6ccmbluplLS+hM4+ X-Received: by 2002:a05:6870:7312:b0:1bf:5559:4aaf with SMTP id q18-20020a056870731200b001bf55594aafmr490926oal.34.1694745576103; Thu, 14 Sep 2023 19:39:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694745576; cv=none; d=google.com; s=arc-20160816; b=MUjsyY9tWVWjW6DkpuqT3WAsUv3B332CdhtWiYk1bOa/qaY8UxAG7hEVvyV1xSIPsZ 0uq0nYjbeXH8j+bO4bCzMJLXcv8SRTFYzMD9OxfZVNZsWkCPXTKfGzkuc1VWOMXBNFSa p3chpgqVd1IvEmmD9HkRnstvjA8DpCnO0RGGXXtWahP5lNy+ztN5hg+uOfVu0oddNHPv i0MJxY//ykfX/M/3Hckz2WEMYCuuclDktms4iFVu0zzqJKkp1uHsoCOIHup/Tbcxxfaa LSse2JYBIunqVtUl+4kh8q17zM+wVYqabAKV3pxkgk4qVPPVk43A/2Fymy8PNQljIpMq /AwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :organization:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:dkim-signature; bh=91ItEaA48PaYp5ILUtPQ0EOz3NpWw/JFlwU7DDokP0U=; fh=u2QaK0Fii6BNUYtN6nfYX99hGuP/PDKe2n+jbXcdk6w=; b=EssOwTHOxoxoUx79z4m7/wGIcMvYouUkP2nemqzoDZSKCWsn9BTW/S/Jh6/chZkAQH Q0+58NqQNTALhQ3LDlW9SJI49vB3NsMl90lrjen2I69iLQwTT9DH9znYAPvAkrpCiZwJ 8D6sKD1ls1RWlzRI+FUHndgwu7M1JFuLxrzKfco5eKus05Tbl2uM+IuBv6loqQek9VQd fzE4ajN4oOkV5n3RR2/70Tfc5JvPQL/zUnjTGu8qoj9lmzAjvmdwCjnY6JqXSEvOkaoC znyWIQV8tV6SINr35zwgC1641OidVMRZpLWiK7PFkpsG8x1vSfHcI46REYd1uIZyRZuJ ATog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=H8v7pz02; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id bs66-20020a632845000000b0057806be7290si1669409pgb.451.2023.09.14.19.39.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Sep 2023 19:39:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=H8v7pz02; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 9FB2B832D725; Thu, 14 Sep 2023 11:52:27 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241840AbjINSw2 (ORCPT + 99 others); Thu, 14 Sep 2023 14:52:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241783AbjINSwE (ORCPT ); Thu, 14 Sep 2023 14:52:04 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6FD772698 for ; Thu, 14 Sep 2023 11:47:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694717250; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=91ItEaA48PaYp5ILUtPQ0EOz3NpWw/JFlwU7DDokP0U=; b=H8v7pz02M0YZQq83o6gHy+7Qxt9FBnoE/sk4FDzjyVAuH8UqbKVj44u5TCz8FUOd4cN40s /RzHppus6yrBrkPMUChcAe5vP9xBFPuzDvlZR2KdZxuvMMYBOXKAWhGoZLYKQDupUQOwF+ MUltAVVxCiFMTM6NjZR9GiRI2voDs+s= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-527-LP1vXaJAPPGMk959vRQ5lQ-1; Thu, 14 Sep 2023 14:47:29 -0400 X-MC-Unique: LP1vXaJAPPGMk959vRQ5lQ-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-31facb07f53so572314f8f.1 for ; Thu, 14 Sep 2023 11:47:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694717248; x=1695322048; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=91ItEaA48PaYp5ILUtPQ0EOz3NpWw/JFlwU7DDokP0U=; b=fhMJdWjsZuiYfECa/BgLve1jeOeds40KeDaMD3UZp4yy2mQOcnnBnn2gth5g0qs37t It/X6nEAsnZ/U4wPBCs8c8enBVAd1OAD5UV4TvUDbzgu1yXJ9NynDb3Dz2Mcvwhin+7K +Ew1y2TWpCb44eu3oVbuDYUMalYC87W4KFsggZNwRSU2RM14cvXJh6drCouXlmcUIazp 0jk9QAd+BwEtSivA81x0+q7xcZI55eerVT8RMtsMt56d4AE6NUcK9wbuHax3lp8jFYsq josXyLReptPIcBoX5MbcKIP6OHDnG0K5frxo8nqfgtKZ/waPo/6iu5spjMQs0AGIr4WV /95A== X-Gm-Message-State: AOJu0YwZv+TknXD3zzhc+kPttmHTNH0q7IMHUkF5nFIfUrpWBHKH/DV+ lSlt80CvZSDIQIh5zZZg6Fs9RysGsSFXvaZj2NywkKDzurzMP7RPV29mTSDMKC6YHGfqJJKiXSl XqQ7sXJUpnfA5OIOpfeAEjbGv X-Received: by 2002:adf:ef09:0:b0:319:6997:9432 with SMTP id e9-20020adfef09000000b0031969979432mr2074726wro.1.1694717248105; Thu, 14 Sep 2023 11:47:28 -0700 (PDT) X-Received: by 2002:adf:ef09:0:b0:319:6997:9432 with SMTP id e9-20020adfef09000000b0031969979432mr2074717wro.1.1694717247674; Thu, 14 Sep 2023 11:47:27 -0700 (PDT) Received: from ?IPV6:2003:cb:c71c:600:4630:4a91:d07:7095? (p200300cbc71c060046304a910d077095.dip0.t-ipconnect.de. [2003:cb:c71c:600:4630:4a91:d07:7095]) by smtp.gmail.com with ESMTPSA id e11-20020a056000120b00b003196b1bb528sm2456394wrx.64.2023.09.14.11.47.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Sep 2023 11:47:27 -0700 (PDT) Message-ID: Date: Thu, 14 Sep 2023 20:47:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 2/3] userfaultfd: UFFDIO_REMAP uABI Content-Language: en-US To: Suren Baghdasaryan , akpm@linux-foundation.org Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, shuah@kernel.org, aarcange@redhat.com, lokeshgidra@google.com, peterx@redhat.com, hughd@google.com, mhocko@suse.com, axelrasmussen@google.com, rppt@kernel.org, willy@infradead.org, Liam.Howlett@oracle.com, jannh@google.com, zhangpeng362@huawei.com, bgeffon@google.com, kaleshsingh@google.com, ngeoffray@google.com, jdduke@google.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com References: <20230914152620.2743033-1-surenb@google.com> <20230914152620.2743033-3-surenb@google.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230914152620.2743033-3-surenb@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 14 Sep 2023 11:52:27 -0700 (PDT) On 14.09.23 17:26, Suren Baghdasaryan wrote: > From: Andrea Arcangeli > > This implements the uABI of UFFDIO_REMAP. > > Notably one mode bitflag is also forwarded (and in turn known) by the > lowlevel remap_pages method. Sorry to say, but these functions are unacceptably long. Please find ways to structure the code in a better way. -- Cheers, David / dhildenb