Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756748AbXKGKkx (ORCPT ); Wed, 7 Nov 2007 05:40:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752108AbXKGKkq (ORCPT ); Wed, 7 Nov 2007 05:40:46 -0500 Received: from lazybastard.de ([212.112.238.170]:55353 "EHLO longford.lazybastard.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751419AbXKGKkp (ORCPT ); Wed, 7 Nov 2007 05:40:45 -0500 Date: Wed, 7 Nov 2007 11:35:55 +0100 From: =?utf-8?B?SsO2cm4=?= Engel To: Andreas Schwab Cc: =?utf-8?B?SsO2cm4=?= Engel , Christoph Lameter , akpm@linux-foundatin.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Mel Gorman Subject: Re: [patch 14/23] inodes: Support generic defragmentation Message-ID: <20071107103554.GF7374@lazybastard.org> References: <20071107011130.382244340@sgi.com> <20071107011229.893091119@sgi.com> <20071107101748.GC7374@lazybastard.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1050 Lines: 30 On Wed, 7 November 2007 11:35:13 +0100, Andreas Schwab wrote: > > > > The fact that all pointers get changed makes me a bit uneasy: > > struct foo_inode v[20]; > > ... > > fs_get_inodes(..., v, ...); > > ... > > v[0].foo_field = bar; > > > > No warning, but spectacular fireworks. > > You'l get a warning that struct foo_inode * is incompatible with void **. - struct foo_inode v[20]; + struct foo_inode *v[20]; Looks like my example needs a patch as well. Anyway, the function is used in a way that makes this a non-issue. Jörn -- You cannot suppose that Moliere ever troubled himself to be original in the matter of ideas. You cannot suppose that the stories he tells in his plays have never been told before. They were culled, as you very well know. -- Andre-Louis Moreau in Scarabouche - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/