Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Date:   Fri, 15 Sep 2023 13:05:25 +0800
From:   Feng Tang <feng.tang@intel.com>
To:     "Lameter, Christopher" <cl@os.amperecomputing.com>
CC:     Hyeonggon Yoo <42.hyeyoo@gmail.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        Andrew Morton <akpm@linux-foundation.org>,
        Pekka Enberg <penberg@kernel.org>,
        David Rientjes <rientjes@google.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        Roman Gushchin <roman.gushchin@linux.dev>,
        <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [RFC Patch 3/3] mm/slub: setup maxim per-node partial according
 to cpu numbers
Message-ID: <ZQPmFcmaRSrbK45H@feng-clx>
References: <20230905141348.32946-1-feng.tang@intel.com>
 <20230905141348.32946-4-feng.tang@intel.com>
 <CAB=+i9RWVvUb5LyoTpzZ0XXWoSNxbKJuA6fynvOd4U+P5q+uaA@mail.gmail.com>
 <ZQKwu3TrorCvgH9b@feng-clx>
 <21a0ba8b-bf05-0799-7c78-2a35f8c8d52a@os.amperecomputing.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <21a0ba8b-bf05-0799-7c78-2a35f8c8d52a@os.amperecomputing.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?oNgA1XJBD3Yk4hdUqvJH1CqKJV/1o3xC+/fmdadH8M662yf00E83MvwUQMrV?=
 =?us-ascii?Q?Q0lkSPQp5fbFtTf4chOCnY38twLuLTDu+F0lLj1iSUvE78DXi17LTZkQ+cSC?=
 =?us-ascii?Q?wseZCYfKb+jo4gm+QzNGPDV5A4CcHopZC4Vyhj0bk1mdFUjPDIMJysoHagRi?=
 =?us-ascii?Q?0FVmEK2F1VhY1r/KZSVnuaw2NlvX8gJr/XLivXwQDxUPhC0/jbbhk6IQ4aqe?=
 =?us-ascii?Q?TtpGSmJWnc81+DVBYkq7ZOMkWnuYS5FWzMFvYcgQN+nAdXbrEUXPTBWQlc9q?=
 =?us-ascii?Q?DruT2fQM/CXBaWGJdxhDOaHQvccwMVpkpQRqsuFrUhwXaNqoFpYoEPWXFKuX?=
 =?us-ascii?Q?CcDU2RLx/6Ui9VGVoOguqZr8yoCWT6Uq36D5oXet7TbSAh0z/VXXCSBgPvdW?=
 =?us-ascii?Q?3WxcQ0Z3KDn6q1ZROiKHska6CfnWZY1q8Y1Q1IKmnCypu5YgMhCkoLMr/yau?=
 =?us-ascii?Q?T66CXEZv5fBx3TARMBxE1IUO1x6+wvEAE3OUB9IAZ7bET+lxXaVO+O8DdPwK?=
 =?us-ascii?Q?k4p8sF1kKAPhN166sMqv5sbbU97CFEDQOjhYDAq8ryjsyit0wnIng48RhLng?=
 =?us-ascii?Q?4z2Jtks568UHL3BSiiRByY9yDCgPQg7zOVC5a2bCrXaTpvPyIKrnqVnlk6Ys?=
 =?us-ascii?Q?ZOEPlZvmzjBwjiuQKLP/W6Z+mz1ro/mITMsfM9q5OO9cDSHoKzjrbVYWlXph?=
 =?us-ascii?Q?yyfdQYHXfx857mWRyqfDkqkRhZRLIz+BfTPPAU6st3k3zC9K8FUc+SYLVf5l?=
 =?us-ascii?Q?aJDsbZIpyLPZ8Ifqi1twXmotILoJZ0er/UaD6T+uDF1tWzNiTn3CiV3Yon3E?=
 =?us-ascii?Q?saQ7zt7fSgQSaBXiG5dG+PEE62xRIR6nw3pTH6edasS+69AVl8OYJk6inWKl?=
 =?us-ascii?Q?PnpCAhuGFCGOjR61j+c8pP5or51nFARw6qoMF8prmySXWWKTYUmtXOvnqrm7?=
 =?us-ascii?Q?drGj/0iXmpuX9OJXm774WcxsVS/zR5dIJSXI2w8P5MxY9cbfLdihygE+EHZS?=
 =?us-ascii?Q?X3Ay9TBjxklyV2/Ph3et1hV9SGmUNsyaS+4ttSuUsbahTMvDDs3W1VRRoCwl?=
 =?us-ascii?Q?3n8LO/HkkLk3g8ydQQJTH2+AVaVw+5W0HxHDTNXDDCMbiiidFKIcxsnqgU26?=
 =?us-ascii?Q?guqSPDWWaAmUUpjlZPBYPWKzipchPWtPqXgHKS+SvVca34dBDr8ewENIO/Vu?=
 =?us-ascii?Q?d5/B7pWFOBrDAgK8O7AuqxwBLnb5BGfaM6G8v0pSmX4oFC0tbx+MSctdbnYe?=
 =?us-ascii?Q?ubN8Z01qmpOhUVFMtS/WKJyj5qTEhoz84ApIppYTCxyUI24tCUEG0rMOawLU?=
 =?us-ascii?Q?qGBr0lkygeH/LOh7qR7uG/9WSyhMdfGEfSOjgs7X83kdSfre3hWHDKT1Aqyv?=
 =?us-ascii?Q?NGqellbYmodAznmL9w6Z0PwuDayOjQYulMXbx28NeWvPruvJLhjzX4unYxxD?=
 =?us-ascii?Q?bKcfVTIeUCsbA4BMOeRwvpHwarF8izbCJkH+bQnDEQqmQHfGZbPmdgjRLgUC?=
 =?us-ascii?Q?fSGe9SeFOogliS36TzOpcqfZl/eaC3J7UJ+PlYI93/NyvpMQgFXuW0jSFzZC?=
 =?us-ascii?Q?EHIeAb8iGgnXiT+tER2qlCbfRC30Z+ILvilvEBKD?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 995f7ec5-c844-421b-a01c-08dbb5aab35c
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2023 05:14:56.2687
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PERWKyJDwpkWM2nIdh5isc6kI1hO6gCFtRKigykZa4EUePxTob03o5PNnEJOTy5+mGYwlXfzhv/Wqj5f7wYQuw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5566
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 14 Sep 2023 22:15:07 -0700 (PDT)

On Thu, Sep 14, 2023 at 07:40:22PM -0700, Lameter, Christopher wrote:
> On Thu, 14 Sep 2023, Feng Tang wrote:
> 
> > One reason I wanted to revisit the MIN_PARTIAL is, it was changed from
> > 2 to 5 in 2007 by Christoph, in commit 76be895001f2 ("SLUB: Improve
> > hackbench speed"), the system has been much huger since then.
> > Currently while a per-cpu partial can already have 5 or more slabs,
> > the limit for a node with possible 100+ CPU could be reconsidered.
> 
> Well the trick that I keep using in large systems with lots of memory is to
> use huge page sized page allocation. The applications on those already are
> using the same page size. Doing so usually removes a lot of overhead and
> speeds up things significantly.
> 
> Try booting with "slab_min_order=9"

Thanks for sharing the trick! I tried and it works here. But this is
kind of extreme and fit for some special use case, and these patches
try to be useful for generic usage.

Thanks,
Feng