Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Thu, 14 Sep 2023 10:15:46 -0500
From:   Steve Wahl <steve.wahl@hpe.com>
To:     Hans de Goede <hdegoede@redhat.com>
Cc:     Steve Wahl <steve.wahl@hpe.com>,
        Justin Ernst <justin.ernst@hpe.com>,
        Kyle Meyer <kyle.meyer@hpe.com>,
        Dimitri Sivanich <dimitri.sivanich@hpe.com>,
        Russ Anderson <russ.anderson@hpe.com>,
        Darren Hart <dvhart@infradead.org>,
        Andy Shevchenko <andy@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H . Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org, Justin Stitt <justinstitt@google.com>
Subject: Re: [PATCH v2] x86/platform/uv: Rework NMI "action" modparam handling
Message-ID: <ZQMjouJ+TpuEHtIW@swahl-home.5wahls.com>
References: <20230913180111.85397-1-hdegoede@redhat.com>
 <ZQIka+OM1+2M3CsU@swahl-linux>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZQIka+OM1+2M3CsU@swahl-linux>
Precedence: bulk

On Wed, Sep 13, 2023 at 04:06:51PM -0500, Steve Wahl wrote:
> On Wed, Sep 13, 2023 at 08:01:11PM +0200, Hans de Goede wrote:

> Maybe rework the message so a possible newline doesn't look so
> awkward, by removing the comma?
> 
> > +	pr_err("UV: Invalid NMI action:%s Valid actions are:\n", val);

It occurred to me overnight that leaving val out completely is an
option, as printing it adds very little value.  So a reasonable option
would be:

+	pr_err("UV: Invalid NMI action. Valid actions are:\n");

--> Steve

-- 
Steve Wahl, Hewlett Packard Enterprise