Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Thu, 14 Sep 2023 19:59:59 +0200
From:   David Sterba <dsterba@suse.cz>
To:     Johannes Thumshirn <johannes.thumshirn@wdc.com>
Cc:     Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
        David Sterba <dsterba@suse.com>,
        Christoph Hellwig <hch@lst.de>,
        Naohiro Aota <naohiro.aota@wdc.com>, Qu Wenruo <wqu@suse.com>,
        Damien Le Moal <dlemoal@kernel.org>,
        linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 07/11] btrfs: zoned: allow zoned RAID
Message-ID: <20230914175959.GA20408@twin.jikos.cz>
Reply-To: dsterba@suse.cz
References: <20230914-raid-stripe-tree-v9-0-15d423829637@wdc.com>
 <20230914-raid-stripe-tree-v9-7-15d423829637@wdc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230914-raid-stripe-tree-v9-7-15d423829637@wdc.com>
User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12)
Precedence: bulk

On Thu, Sep 14, 2023 at 09:07:02AM -0700, Johannes Thumshirn wrote:
> --- a/fs/btrfs/zoned.c
> +++ b/fs/btrfs/zoned.c
> @@ -1397,9 +1397,11 @@ static int btrfs_load_block_group_dup(struct btrfs_block_group *bg,
>  				      struct zone_info *zone_info,
>  				      unsigned long *active)
>  {
> -	if (map->type & BTRFS_BLOCK_GROUP_DATA) {
> -		btrfs_err(bg->fs_info,
> -			  "zoned: profile DUP not yet supported on data bg");
> +	struct btrfs_fs_info *fs_info = bg->fs_info;
> +
> +	if (map->type & BTRFS_BLOCK_GROUP_DATA &&
> +	    !fs_info->stripe_root) {
> +		btrfs_err(fs_info, "zoned: data DUP profile needs stripe_root");

Using stripe_root for identifier is ok so we don't have overly long ones
but for user messages please use raid-stripe-tree. Fixed.