Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
MIME-Version: 1.0
References: <20230914140823.1732-1-justinjiang@vivo.com> <CAOUHufY+7j1L37c1RvCBdkx36qyNZYOBuZa_+GAA4j=9vKzwWA@mail.gmail.com>
 <JH0PR06MB684964083AEC0B49CA56EC51C7F6A@JH0PR06MB6849.apcprd06.prod.outlook.com>
In-Reply-To: <JH0PR06MB684964083AEC0B49CA56EC51C7F6A@JH0PR06MB6849.apcprd06.prod.outlook.com>
From:   Yu Zhao <yuzhao@google.com>
Date:   Thu, 14 Sep 2023 21:25:10 -0600
Message-ID: <CAOUHufYKJ9YCNU6WEQjkM5Ad7X0wWXhUQm5sQWZhZ0Tb-cFzDQ@mail.gmail.com>
Subject: Re: [PATCH] mm: mglru: fix add unevictable folio to lruvec->lists
To:     =?UTF-8?B?5rGf5b+X5Zu9?= <justinjiang@vivo.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "opensource.kernel" <opensource.kernel@vivo.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Sep 14, 2023 at 9:19=E2=80=AFPM =E6=B1=9F=E5=BF=97=E5=9B=BD <justin=
jiang@vivo.com> wrote:
>
> Hi Yu Zhao:
>
> How is the unevictable folio managed in kernel?

https://www.kernel.org/doc/Documentation/vm/unevictable-lru.txt

> On Thu, Sep 14, 2023 at 8:08=E2=80=AFAM Zhiguo Jiang <justinjiang@vivo.co=
m> wrote:
> >
> > The unevictable folio is not supported to add to lruvec->lists in
> > lruvec_add_folio().
> >
> > So use lruvec_add_folio_tail() instead of lruvec_add_folio() to add
> > unevictable folio to lruvec->lists in sort_folio().
> >
> > Signed-off-by: Zhiguo Jiang <justinjiang@vivo.com>
> > ---
> >  mm/vmscan.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)  mode change 100644 =3D>
> > 100755 mm/vmscan.c
> >
> > diff --git a/mm/vmscan.c b/mm/vmscan.c index
> > 661615fa709b..a15e45632034
> > --- a/mm/vmscan.c
> > +++ b/mm/vmscan.c
> > @@ -4237,7 +4237,7 @@ static bool sort_folio(struct lruvec *lruvec, str=
uct folio *folio, struct scan_c
> >                 success =3D lru_gen_del_folio(lruvec, folio, true);
> >                 VM_WARN_ON_ONCE_FOLIO(!success, folio);
> >                 folio_set_unevictable(folio);
> > -               lruvec_add_folio(lruvec, folio);
> > +               lruvec_add_folio_tail(lruvec, folio);
> >                 __count_vm_events(UNEVICTABLE_PGCULLED, delta);
> >                 return true;
> >         }
>
> NAK.
>
> lruvec_add_folio()
> {
>         ...
>
>         if (lru !=3D LRU_UNEVICTABLE)
>                 list_add(&folio->lru, &lruvec->lists[lru]); }
>
> lruvec_add_folio_tail()
> {
>         ...
>
>         /* This is not expected to be used on LRU_UNEVICTABLE */
>         list_add_tail(&folio->lru, &lruvec->lists[lru]); }
>
> struct page {
>         ...
>                         union {
>                                 struct list_head lru;
>
>                                 /* Or, for the Unevictable "LRU list" slo=
t */
>                                 struct {
>         ...
> }