Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <691dc45e-8c06-71b6-c7bd-6e077d5fcea2@quicinc.com>
Date:   Fri, 15 Sep 2023 08:16:18 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.1
Subject: Re: [RFC] usb: gadget: ncm: Handle decoding of multiple NTB's in
 unwrap call
To:     =?UTF-8?Q?Maciej_=c5=bbenczykowski?= <maze@google.com>
CC:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Linyu Yuan <quic_linyyuan@quicinc.com>,
        <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <quic_ppratap@quicinc.com>, <quic_wcheng@quicinc.com>,
        <quic_jackp@quicinc.com>
References: <20230914182922.27157-1-quic_kriskura@quicinc.com>
 <CANP3RGeMFnBdQ3yS3i_QqWCuQB34Ma8ToEnfH-WjZQBeNgqoFw@mail.gmail.com>
Content-Language: en-US
From:   Krishna Kurapati PSSNV <quic_kriskura@quicinc.com>
In-Reply-To: <CANP3RGeMFnBdQ3yS3i_QqWCuQB34Ma8ToEnfH-WjZQBeNgqoFw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 9/15/2023 6:54 AM, Maciej Żenczykowski wrote:
> Reviewed-by: Maciej Żenczykowski <maze@google.com>
> 
> The casts should probably use the actual correct ptr type instead of void*
> 

Hi Maciej Żenczykowski,

Thanks for the review.

I initially tried to typecast it to char* since the skb->data is of that 
type. But nothing was working. So I kept it void* since the initial 
variable tmp too was kept to void*

Will add the stable and review tag as well and send v2 to be merged.

Regards,
Krishna,