Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp4417456rdb; Fri, 15 Sep 2023 01:11:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGphkbW8nB/jqY5aDkJ/qrq2C0fB034nqtQd69rb5uN2rUv+FdvfneenyWZPAgUe5qbnv+q X-Received: by 2002:a17:902:a40c:b0:1c4:1538:85fc with SMTP id p12-20020a170902a40c00b001c4153885fcmr814873plq.51.1694765483784; Fri, 15 Sep 2023 01:11:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694765483; cv=none; d=google.com; s=arc-20160816; b=LqZweLFM03AjcF2U+dJBmzFb5wJS/4DMJ9lRZJRoVwePhv2byV+jAxOR1AzaZ/RzFX NiHhASeQcKdyJOGyzlkbOADf3c0Tz9mmffawJY381YYnmBnyywdo/hTPlCipZ4Wgd9DV TtcITca0SJ+RVyNLiF33kBZJ/AQebL5MBOocSLYJioXeKvZOo0+BaCEUjEm+r5UkEpIO /3r8qrTAL8JC+yONQ9efoXfVdBacnPI2UQuqFeBOlBLB4DTJC5MWzJ9hsy4IMrQlJltJ hE6XUPmtjqrDYJnJNyx1zMDh+9I8s/JsNSTurPYKyjUk/yp/wxdPO117LvsjlQeH0dTw jamA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=r2l7ZtAanKEwy1j8vHLn3lrgD262RUx6+uGderDuawQ=; fh=o4amDHB0iIbZ5YX++ASOil2zB4OFgwL2QXdwSMQC9R0=; b=xomWSanwDe+0sjxIzwRDUPuTix+UT/1hIBN+frzdwdRr4Zl7Wo1gu7h9GK/KS4qeYj N5b0wMwel+Yk/pUoNpvd8/QY0WGqQix5V2il+0/bq+oYuWt8EeGfOPVAmG/B60+V33vI Vv5c3xgi6ZwA44yrLZRfJpcE/Itzq0a6d0nKGl3mM6AC4yh0Y3kQfJnC7IUxZ66nYu5k uKnEtOtCpS4qmFFEHuRpqqWDCEkA0/rWZ3pDL1uYAdgxpRkNU8jN/UYl1nTEQJj4JbaO /49aIZLKLI31cHOx0x76iyU1Qy9Ow1MF0TXtJ11MbJi9VjJXBBNbvSc6WPIWvy4xZ2QZ kUKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rvwj7lj8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id e10-20020a17090301ca00b001c3b4eb2135si3117123plh.463.2023.09.15.01.11.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 01:11:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rvwj7lj8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 34ADC8236242; Fri, 15 Sep 2023 00:58:18 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232720AbjIOH6R (ORCPT + 99 others); Fri, 15 Sep 2023 03:58:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232262AbjIOH6Q (ORCPT ); Fri, 15 Sep 2023 03:58:16 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9519193 for ; Fri, 15 Sep 2023 00:58:11 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D4B6C433C9; Fri, 15 Sep 2023 07:58:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694764691; bh=t+ZshDk3vSry1uc6hCwYDbU+R1dULuj35xmF6dRVMrk=; h=From:To:Cc:Subject:Date:From; b=rvwj7lj8FTEWHvf1wUbhIc8CK5XVM4UyBTKgXnVGlvnMvDvIiuwrT/7wJJHf8L0/j DQLpHPOpajgELw/genwY5AfrHU5D1bHCuW6T49J9ge+LlUSOPyhj7o9KzuqPyblGT4 iBeGAJoKwE5SH581mv/T5N5N1tit9oDbbA4VThjaayi07QnsmCLKIFl/rIQvc0lfUQ JEb+NxHkp8yCmzPRNnSUk11iIZijw9jWj90cvNjn2WzJPll/L01f1DCDP7JJVJit+l 03onA6v36HsZ/+RKmw/UU+AOoCqlTnxeWDIm7kfiuGeBOIxMSvceyppdQTViv7Yp1p P5P33W5K4xkuA== From: Michael Walle To: Chun-Kuang Hu , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , AngeloGioacchino Del Regno Cc: Jitao Shi , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Michael Walle Subject: [PATCH] drm/mediatek: dsi: Fix EOTp generation Date: Fri, 15 Sep 2023 09:57:56 +0200 Message-Id: <20230915075756.263591-1-mwalle@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Fri, 15 Sep 2023 00:58:18 -0700 (PDT) The commit c87d1c4b5b9a ("drm/mediatek: dsi: Use symbolized register definition") inverted the logic of the control bit. Maybe it was because of the bad naming which was fixed in commit 0f3b68b66a6d ("drm/dsi: Add _NO_ to MIPI_DSI_* flags disabling features"). In any case, the logic wrong and there will be no EOTp on the DSI link by default. Fix it. Fixes: c87d1c4b5b9a ("drm/mediatek: dsi: Use symbolized register definition") Signed-off-by: Michael Walle --- drivers/gpu/drm/mediatek/mtk_dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index d67e5c61a9b9..8024b20f6b13 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c @@ -407,7 +407,7 @@ static void mtk_dsi_rxtx_control(struct mtk_dsi *dsi) if (dsi->mode_flags & MIPI_DSI_CLOCK_NON_CONTINUOUS) tmp_reg |= HSTX_CKLP_EN; - if (!(dsi->mode_flags & MIPI_DSI_MODE_NO_EOT_PACKET)) + if (dsi->mode_flags & MIPI_DSI_MODE_NO_EOT_PACKET) tmp_reg |= DIS_EOT; writel(tmp_reg, dsi->regs + DSI_TXRX_CTRL); -- 2.39.2