From: Akio Takebe <takebe_akio@jp.fujitsu.com>
To: Glauber de Oliveira Costa <gcosta@redhat.com>
Cc: linux-kernel@vger.kernel.org, jeremy@goop.org, hollisb@us.ibm.com,
       kvm-devel@lists.sourceforge.net, avi@qumranet.com,
       Akio Takebe <takebe_akio@jp.fujitsu.com>
Subject: Re: [kvm-devel] include files for kvmclock
Date: Wed, 07 Nov 2007 22:27:46 +0900
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
In-Reply-To: <4731BAB2.9040004@redhat.com>
References: <11943875362987-git-send-email-gcosta@redhat.com> <11943875433821-git-send-email-gcosta@redhat.com> <1DC8211684B62Btakebe_akio@jp.fujitsu.com> <4731BAB2.9040004@redhat.com>
Message-Id: <1FC82141FC3CCFtakebe_akio@jp.fujitsu.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 961
Lines: 26

Hi, 

>> Why does kvm_hv_clock need page_align?
>Each vcpu will register a page on its own. In the guest side, it will be
>an array of pages. So, we make it page sized.
>
>> And also the kvm_hv_clock is alloced with kvm_vcpu,
>There's no requirements on the host part at all. So it doesn't really
>matter. In the next version, I may make it even a simple pointer.
>
>> so the align is not enough, isn't it?
>> I thik __atribute__((__aligne__(PAGE_SIZE)))) is better than it.
>It deals with the start of the structure, but not with its size. See the
>guest part: Where it matters, I do use it.
Oh, I confused the guest/host part, but I could understand it.
Thank you for your explanation.

Best Regards,

Akio Takebe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/