Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp4425787rdb; Fri, 15 Sep 2023 01:31:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHCIVHKU2sfFjOLT1XwPLh4tMH/em/rHjjWLMrnNlZ8oNiD0ZDnCaQtzeE+Ij7BVL6WBAPf X-Received: by 2002:a05:6a20:6a0a:b0:15a:20e6:ffd8 with SMTP id p10-20020a056a206a0a00b0015a20e6ffd8mr1393663pzk.41.1694766712628; Fri, 15 Sep 2023 01:31:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694766712; cv=none; d=google.com; s=arc-20160816; b=YMYsnUs/ayNyVRMg1xdEJ+aREiuU8r9conx4L3nD++ikWw9VbVbpwkjkmepSMyt786 SDc+qAZL8Z/wDUuUlPiYBVV099xfD8Vs2iIVIbyp4z8IBP8eQ712Gbo12ZHtRZiJvqwT 9a3QHZVF073BaMnGNKzS2m7ImHqjHwnGQ1Flv0WHGG0tw5qIScxTJJ7+SOUhjiaBO0jW JIxwIdJF/BwTB19jc6zqoRQozWLQIeRxdeQGDTt1dYoiuOzTeexZlcf1ReP1mcWXsZ0X ONTU1dmxHt8HnqFxm5WEQ6mfVTiU0mq22FGl26gFirFVAOgrIXIU+0CexcDdjo3GPCsx V75A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=xn9oFhHLAknaWRf3uArqHTLA9prBJhnE4LW7Dd164uA=; fh=KIY9eBGZKI57bAUK81HjZ3H4wuV6bY95Ap3GbH40Zws=; b=jB/8C/ddBXSvgTak+8JENkl7nEDYHAIwDvFA8PZdQths7r6qdGO11ljbzotGHXW2x9 B93tsXv23Emuyvz7makWJpYpnCvldTNNb0pcv82sXwxKjgqLcuSgQiNMXc5yJE6YkpGc e9z+I0ps/WByGSLJg6Eh/6sRYtCPckV2QhjVWESPLM8sdBMJhxVd6+rtKh+MfF//W45j 2lfE5fQxh3ZbkN1s8QekI6PKGYZRjYutzg43rCXaAIwfn7nj0MBv/FUPX5WvWDycxdYK 7N3wvX+aHu+SsOebkROirdsmMvFBrxhIL5bN4oCwKqJ6qq+SDkyZZQHpIWOibiVXmHtR FhjA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=dK+HDjyZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id x63-20020a636342000000b00565f4166f4bsi2897987pgb.284.2023.09.15.01.31.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 01:31:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=dK+HDjyZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id D4FC682606E7; Thu, 14 Sep 2023 22:28:44 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232005AbjIOF2p (ORCPT + 99 others); Fri, 15 Sep 2023 01:28:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231616AbjIOF2o (ORCPT ); Fri, 15 Sep 2023 01:28:44 -0400 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6C4E2D55 for ; Thu, 14 Sep 2023 22:28:17 -0700 (PDT) Received: by mail-lj1-x22c.google.com with SMTP id 38308e7fff4ca-2bce552508fso26259711fa.1 for ; Thu, 14 Sep 2023 22:28:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1694755696; x=1695360496; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=xn9oFhHLAknaWRf3uArqHTLA9prBJhnE4LW7Dd164uA=; b=dK+HDjyZaIzzWjOpKGliaqyaq/IuzoIhWNmB8yFOe3y4+beIdkyiw3y4C+DO86gi5Z AQEBqzuRuIB+l5fp3AsZavt6Lz/jrs3lfLVPhX4ZEpJm1WJvceXX/P831J+WFK8f1/it eIQBvIggVMaXhLBOOAxyvA/w4SoUn970h/sCw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694755696; x=1695360496; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xn9oFhHLAknaWRf3uArqHTLA9prBJhnE4LW7Dd164uA=; b=BL0aOJmj8uu05dmCOXVMmqz2krRCUeKgm4CLhiKNEUd2kS6myh4y6bkA2BBUWu6s9F zINuGOl3roNBzeLB8fFy6MeQd50guBXQRj0r8nFEfFvFUnL5dVCO+8F321pbxkiiECLB AheCUxxgk8WTERTD2xK3oCISgTcP1uAnPFs3T3j2oekbThpKDt48R4KmlQenP7RZPnDT 3qWoeVJjXydGCNJ8AhcY4JM9wlrI3oZcAZGuEf4oYq4OM0yM8GZZW1KArB+e9Z0ByZTm GQC1kxr9TRLsjvtr4RMGmDJhfe66dLrXWuIeHG5QyIuhIKu4+YStMEp/MjKMx5wu9qLB p4Lw== X-Gm-Message-State: AOJu0YziBZ2ZU8p7jwiQ6jimIQEHrSrbSV0v4+NV53+7k9tO2tRjuDHp gFNeoG4b8fdROIjsaZhuDmm8lxYyQ6jbQkhJpXJQ+A== X-Received: by 2002:a05:6512:48c9:b0:502:d639:22ed with SMTP id er9-20020a05651248c900b00502d63922edmr518597lfb.48.1694755696091; Thu, 14 Sep 2023 22:28:16 -0700 (PDT) MIME-Version: 1.0 References: <20230914131058.2472260-1-jani.nikula@intel.com> <20230914155317.2511876-1-jani.nikula@intel.com> In-Reply-To: <20230914155317.2511876-1-jani.nikula@intel.com> From: Chen-Yu Tsai Date: Fri, 15 Sep 2023 13:28:04 +0800 Message-ID: Subject: Re: [PATCH] drm/mediatek/dp: fix memory leak on ->get_edid callback audio detection To: Jani Nikula Cc: dri-devel@lists.freedesktop.org, Chun-Kuang Hu , Guillaume Ranquet , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Markus Schneider-Pargmann , Bo-Chen Chen , linux-mediatek@lists.infradead.org, Dmitry Osipenko , Matthias Brugger , linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 14 Sep 2023 22:28:45 -0700 (PDT) On Thu, Sep 14, 2023 at 11:53=E2=80=AFPM Jani Nikula wrote: > > The sads returned by drm_edid_to_sad() needs to be freed. > > Fixes: e71a8ebbe086 ("drm/mediatek: dp: Audio support for MT8195") > Cc: Guillaume Ranquet > Cc: Bo-Chen Chen > Cc: AngeloGioacchino Del Regno > Cc: Dmitry Osipenko > Cc: Chun-Kuang Hu > Cc: Philipp Zabel > Cc: Matthias Brugger > Cc: dri-devel@lists.freedesktop.org > Cc: linux-mediatek@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: # v6.1+ > Signed-off-by: Jani Nikula Looks correct to me. Reviewed-by: Chen-Yu Tsai