Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Date:   Fri, 15 Sep 2023 08:21:19 +0100
From:   Conor Dooley <conor.dooley@microchip.com>
To:     Wang Chen <unicornxw@gmail.com>
CC:     <linux-riscv@lists.infradead.org>, <conor@kernel.org>,
        <aou@eecs.berkeley.edu>, <krzysztof.kozlowski+dt@linaro.org>,
        <palmer@dabbelt.com>, <paul.walmsley@sifive.com>,
        <robh+dt@kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <jszhang@kernel.org>,
        <guoren@kernel.org>, <chao.wei@sophgo.com>,
        <xiaoguang.xing@sophgo.com>, Wang Chen <wangchen20@iscas.ac.cn>
Subject: Re: [PATCH 01/12] riscv: Add SOPHGO SOC family Kconfig support
Message-ID: <20230915-groovy-fragile-8c3a3a7b038e@wendy>
References: <20230915071005.117575-1-wangchen20@iscas.ac.cn>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="ENGkoMse754EbNpY"
Content-Disposition: inline
In-Reply-To: <20230915071005.117575-1-wangchen20@iscas.ac.cn>
Precedence: bulk

--ENGkoMse754EbNpY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Yo,

On Fri, Sep 15, 2023 at 03:10:05PM +0800, Wang Chen wrote:
> From: "xiaoguang.xing" <xiaoguang.xing@sophgo.com>

This needs to be a name, not the contents of their email address.
Probably just needs the . swapped for a space?

> The first SoC in the SOPHGO series is SG2042, which contains 64 RISC-V
> cores.
>=20
> Signed-off-by: xiaoguang.xing <xiaoguang.xing@sophgo.com>
> Signed-off-by: Wang Chen <wangchen20@iscas.ac.cn>
> ---
>  arch/riscv/Kconfig.socs | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>=20
> diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs
> index 6833d01e2e70..fc7b5e6c7def 100644
> --- a/arch/riscv/Kconfig.socs
> +++ b/arch/riscv/Kconfig.socs
> @@ -110,4 +110,14 @@ config SOC_CANAAN_K210_DTB_SOURCE
> =20
>  endif # ARCH_CANAAN
> =20
> +config ARCH_SOPHGO
> +	bool "Sophgo SoCs"
> +	select SIFIVE_PLIC

This should not be needed, this should be selected at the arch level.

> +	help
> +	  This enables support for Sophgo SoC platform hardware.
> +	  SOPHGO is committed to become a provider of universal
> +	  computing power, focusing on the development and
> +	  promotion of computing power products such as AI and
> +	  RISC-V CPU.

This is not a place for marketing blurbs, please take a look at the
other entries.
Also, this should not be placed at the end of the list, it should be
before ARCH_SUNXI.

Thanks,
Conor.

> +
>  endmenu # "SoC selection"
> --=20
> 2.25.1
>=20

--ENGkoMse754EbNpY
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZQQF6QAKCRB4tDGHoIJi
0oTJAP9c52u8XECYZvn+Qt9RdRvorAS3pVREBUDao12bLGJQcQEAxhTfNeJImtXF
WhPAFatMpxtY1G/qD8E+TiVnTwgm4Qo=
=FBOL
-----END PGP SIGNATURE-----

--ENGkoMse754EbNpY--