Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp4436413rdb; Fri, 15 Sep 2023 02:01:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEgXoouhNyXQOz3FrER6w0yOkV+i5Un1i1c7WiycueJl/hGm58XsuYYLEk/eTmV77/MFKU7 X-Received: by 2002:a17:90b:3549:b0:274:77df:50cd with SMTP id lt9-20020a17090b354900b0027477df50cdmr802441pjb.9.1694768461311; Fri, 15 Sep 2023 02:01:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694768461; cv=none; d=google.com; s=arc-20160816; b=y7vRWCBzYrk+tZrYIFfRb3hi6eOVsIkZplOMRjmF2aWd2tVsehN72j3dqHzeLpV0hj 8IYLlRvjxiNy1OJqUJ+rYjOUA5PTwebNXKFJS8uZUq36cZSiSG9gUSRUywAwKNeO9DRJ u/ztqAKn+D8XJaQDVf+mjhp6ZP0S4FbG6bHfU7daHeoddC/yQJLPGJv5wrTyFahaKICR L/UmVTJuM7ZNWa5Byt6ek2VTnYfgVbl/gY4cDpc1DraAVTlKMl4Lfk0SjSP7C1IM/Y4V uEvu3aeCvQxb3UACyN77S3HH49KpI5MzAisAMrR7c/eXa+bGqXZyLmc4ac4L+INXIAWc uOsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=oGfA+/nRZMbR/XPuFTXJG7B+zLW/Q8qaAPUbrSyMQao=; fh=KH8HnsdO2yip8Q9uuYy0FWJVbOcjQeNq7C+3VKM5Hzg=; b=Em0cQC0eY1n967l2n4RoLlk4bM5RdwW/v+Aigkkb5/xAyU8rmyZJ7Fy065E4e4z4mJ r4lSUvlUZ1RK0wOldOK4BCcVmfkjDhpq9oDCQ6BmfVFAItVSBwZ7yd3iVj5ZRnsxxJ5F xrpqRGFG/+ZYh6t45qp5sz0CzHpCIz2yfs8X0KuZgOSBDs+MIJ7+1fKXn/zMyoftIdiH Hbi0RlBWOmXuFseG+apYOnNo9kCgBy2bR7WlIgZLBvOxVxQxRED+U9s4bsk/9Zl/Lp87 UojGxZT4ZXgyq+x3fCNlNzyJ2vTRA1QucpVOLMeFBLVnVoCNVvDzOswpB/k7UFKy7TNg k2GQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id in4-20020a17090b438400b0026f5ae36740si2886365pjb.172.2023.09.15.02.01.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 02:01:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id C362782F96BE; Fri, 15 Sep 2023 01:56:05 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233533AbjIOIzs (ORCPT + 99 others); Fri, 15 Sep 2023 04:55:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233384AbjIOIyi (ORCPT ); Fri, 15 Sep 2023 04:54:38 -0400 Received: from andre.telenet-ops.be (andre.telenet-ops.be [IPv6:2a02:1800:120:4::f00:15]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFF74271D for ; Fri, 15 Sep 2023 01:54:19 -0700 (PDT) Received: from ramsan.of.borg ([84.195.187.55]) by andre.telenet-ops.be with bizsmtp id m8uF2A00Z1C8whw018uFew; Fri, 15 Sep 2023 10:54:16 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1qh4aK-003lIW-9l; Fri, 15 Sep 2023 10:54:15 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1qh4ad-00Gddo-AT; Fri, 15 Sep 2023 10:54:15 +0200 From: Geert Uytterhoeven To: Laurent Pinchart , Kieran Bingham , David Airlie , Daniel Vetter , Thomas Zimmermann , Magnus Damm Cc: dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , Laurent Pinchart Subject: [PATCH v4 40/41] drm: renesas: shmobile: Atomic conversion part 3 Date: Fri, 15 Sep 2023 10:53:55 +0200 Message-Id: <042f9ff076c4b1c87235c74c8b76c9d161e126ec.1694767209.git.geert+renesas@glider.be> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Fri, 15 Sep 2023 01:56:05 -0700 (PDT) Complete the conversion to atomic mode setting by converting the connector, and setting the DRIVER_ATOMIC flag. Signed-off-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart --- v4: - No changes, v3: - No changes, v2: - Add Reviewed-by. --- drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c | 5 +---- drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c | 2 +- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c index e4d176b1f47654a8..729028a15efae00c 100644 --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c @@ -501,7 +501,6 @@ static void shmob_drm_connector_destroy(struct drm_connector *connector) } static const struct drm_connector_funcs connector_funcs = { - .dpms = drm_helper_connector_dpms, .reset = drm_atomic_helper_connector_reset, .fill_modes = drm_helper_probe_single_connector_modes, .destroy = shmob_drm_connector_destroy, @@ -581,9 +580,7 @@ int shmob_drm_connector_create(struct shmob_drm_device *sdev, if (ret < 0) goto error; - drm_helper_connector_dpms(connector, DRM_MODE_DPMS_OFF); - drm_object_property_set_value(&connector->base, - sdev->ddev.mode_config.dpms_property, DRM_MODE_DPMS_OFF); + connector->dpms = DRM_MODE_DPMS_OFF; sdev->connector = connector; diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c index 283e953e21d34bc2..c498d0d9b4fc4fc5 100644 --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c @@ -98,7 +98,7 @@ static irqreturn_t shmob_drm_irq(int irq, void *arg) DEFINE_DRM_GEM_DMA_FOPS(shmob_drm_fops); static const struct drm_driver shmob_drm_driver = { - .driver_features = DRIVER_GEM | DRIVER_MODESET, + .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC, DRM_GEM_DMA_DRIVER_OPS, .fops = &shmob_drm_fops, .name = "shmob-drm", -- 2.34.1