Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp4444126rdb; Fri, 15 Sep 2023 02:18:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEBKEXwUXMh1HIOqC79qdGVBg7QDUSwjETsIrCyLwOzeve8HUVR82PEVsnr0GKHFkHd3jkP X-Received: by 2002:a05:6a00:24c8:b0:68f:b5a3:5ec6 with SMTP id d8-20020a056a0024c800b0068fb5a35ec6mr1562754pfv.0.1694769499139; Fri, 15 Sep 2023 02:18:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694769499; cv=none; d=google.com; s=arc-20160816; b=fb4IU3teMcfiA8zdYrN1GYcTGv07FEa5RyxBlEYVYq7kWJj5HSgY/WhIoP+uFxohkq Ts7c4JdAjkU+hNFTqYxnR5Z+LWdOntUv97I1ZfG7jNXXwePkIw4KVsdkdDytDF38pAGl QRRErpMOkaixvUbGXUiPujJSsuwZvXkcffyoTYuuxB5AYM4o+sHy+h9Cwxprl2ndGsO9 UGVWDXpE+F2C7UkL4Q6l/pV6xIP0atjPejW1xiMKogsxQ/83kdrjDb4mByanetbSDsq5 GY3DwsJZPOROc/uxMZDfULsbYknZRZJKpg6BrcN6FRU0/GfLBNu/4/v4ocLzSA3ZUNbE bNdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from :dkim-signature; bh=dyCc/9M/AflBfZ+eCHDv8VnAouJWJfOcaUnGoqvP9AE=; fh=THKl7HF3FoEIld4ZelNFyIWrL7YhGAyvNGucV8X4sec=; b=QNrM0xCfc7VOKpO5jwKXNl+XccgqM92PpG81luRcngN5zouqbeQ5XFWVmJIovoqu3R 3zzB90sHFmbIV4GkZpQbvF1FCqatP4iRQUcl4+QB+ZshmMPrnP9SB+mNKh9vaqCLLIOX Dfs5jynTf3+wPKCbrsRpyFX4oMcPqXBeE6wJPdmVjCUbqmDKr0S5G/eilohzZ1d8nxTW dsycvkqQ8BN2Ro8oDAu70+ncKgfp25hS6MAlufvdwY3RokcV7DosiO7mDhE2Cfsce0Ro jqHKXgcImhopCbeiOYQdtF6TT8JXnvU01rMj+IVMU/LMfngVuCvY4UGpaoXAk3KB+E0i Oatw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=LAmseET0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id cu12-20020a056a00448c00b0068a6f6d9f85si3071657pfb.140.2023.09.15.02.18.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 02:18:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=LAmseET0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 070B48381607; Thu, 14 Sep 2023 21:55:38 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231979AbjIOEzh (ORCPT + 99 others); Fri, 15 Sep 2023 00:55:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231986AbjIOEze (ORCPT ); Fri, 15 Sep 2023 00:55:34 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CE54271B for ; Thu, 14 Sep 2023 21:55:17 -0700 (PDT) Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38F4I63w005247; Fri, 15 Sep 2023 04:55:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : mime-version : content-type; s=qcppdkim1; bh=dyCc/9M/AflBfZ+eCHDv8VnAouJWJfOcaUnGoqvP9AE=; b=LAmseET0+frBWx3ZmjRkOgdOs/F2bCaX3JSQiUDA5qxOe8wj5dVSkYwGUOVUMydBaTAh 4jLfqwcv2v1z9dKVLjagWsf4foWduSY6LGUw2EC9Kf/YCQwtGyCXT2/Qk5CW/mnr1Hqt IUyH2tQqyA+h/dzx058c5mkH8FnNxhiSukbxzMnOsX78J2g8PWMl8shGSDJWH7RtpY8N QdKRTt7gLXH4iMfydxnVFkchaWwJRY2IE/kJX9bbzZhJAD6Isd49E/mde/TZejL+dIdQ ZKjQ0x5dOg7p/gVv8MFSMJTG1oqCaq1YDuRr9afQu+Gtg6ioMkEcaI8wdrHkqq/qrxmm GQ== Received: from nasanppmta03.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3t4g3n82ht-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 15 Sep 2023 04:55:08 +0000 Received: from nasanex01a.na.qualcomm.com (nasanex01a.na.qualcomm.com [10.52.223.231]) by NASANPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 38F4t8lc032521 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 15 Sep 2023 04:55:08 GMT Received: from hu-rsr-hyd.qualcomm.com (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.36; Thu, 14 Sep 2023 21:55:04 -0700 From: Ramya SR To: David Airlie , Daniel Vetter , "Lyude Paul" , Wayne Lin , Jani Nikula , Imre Deak , Alex Deucher , Jeff Layton , , CC: Ramya SR Subject: [PATCH v1] drm/dp/mst: fix missing modeset unlock for MST port detect Date: Fri, 15 Sep 2023 10:24:49 +0530 Message-ID: <1694753689-29782-1-git-send-email-quic_rsr@quicinc.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: ewsIXJlLnhdgJujr-Mv-x7OR1t87masr X-Proofpoint-ORIG-GUID: ewsIXJlLnhdgJujr-Mv-x7OR1t87masr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-09-15_04,2023-09-14_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 malwarescore=0 phishscore=0 spamscore=0 impostorscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1011 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000 definitions=main-2309150043 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 14 Sep 2023 21:55:39 -0700 (PDT) Modeset mutex unlock is missing in drm_dp_mst_detect_port function. This will lead to deadlock if calling the function multiple times in an atomic operation, for example, getting imultiple MST ports status for a DP MST bonding scenario. Signed-off-by: Ramya SR --- drivers/gpu/drm/display/drm_dp_mst_topology.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c b/drivers/gpu/drm/display/drm_dp_mst_topology.c index ed96cfc..d6512c4 100644 --- a/drivers/gpu/drm/display/drm_dp_mst_topology.c +++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c @@ -4154,7 +4154,7 @@ drm_dp_mst_detect_port(struct drm_connector *connector, ret = drm_modeset_lock(&mgr->base.lock, ctx); if (ret) - goto out; + goto fail; ret = connector_status_disconnected; @@ -4181,6 +4181,8 @@ drm_dp_mst_detect_port(struct drm_connector *connector, break; } out: + drm_modeset_unlock(&mgr->base.lock); +fail: drm_dp_mst_topology_put_port(port); return ret; } -- 2.7.4