Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
From:   Javier Carrasco <javier.carrasco@wolfvision.net>
Date:   Fri, 15 Sep 2023 08:50:52 +0200
Subject: [PATCH 1/2] usb: typec: tps6598x: add reset gpio support
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <20230912-topic-tps6598x_reset-v1-1-78dc0bf61790@wolfvision.net>
References: <20230912-topic-tps6598x_reset-v1-0-78dc0bf61790@wolfvision.net>
In-Reply-To: <20230912-topic-tps6598x_reset-v1-0-78dc0bf61790@wolfvision.net>
To:     Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc:     linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org,
        Javier Carrasco <javier.carrasco@wolfvision.net>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S1BiUkpmSC9WSExnWkZ5c241ZDU0Q1p6QUE2WXpRaWZCaGJTY3E0NVRaYTlW?=
 =?utf-8?B?cnl4Z0pObWxqcFRldEhoVnRaRS9LTk5pVzVWYTFsNkpWOHF2VVY1OW1vUzAz?=
 =?utf-8?B?ZExGU1JNRmxNRERlZDd2R1RCK0xNYmtjdGxoNjBKODVSUXlQNkJHMXBtTzhm?=
 =?utf-8?B?eFdPZDU0U0hqb2kwTnpQay9pNVhVV2dYQjE0dTFOUlRXMjRNajU4ZGxnWXA2?=
 =?utf-8?B?LzNKRTlHZVM0SUNMMXpuUlVoNjVCN0gvYnB1R0EyaC96dWFQSHZ1RWdnL3Rx?=
 =?utf-8?B?L0NHMllFTW5paTVqMmROUGRtazBLT1c5WnBoaXNWOTVvR0gyb1E3UGtGQ0hJ?=
 =?utf-8?B?ZGl6NE1UaFlBWWQrM2xpNEVqc1paZy80Mzc0cUlIVVRWK1VIM1NiZkt3TVNO?=
 =?utf-8?B?aHZrWFF4c3RleHpZMHRZR0l3dnNRYS9jSStVL0htamZROXJTWlFRekpOREdr?=
 =?utf-8?B?bkdYaG11NFBaYnpiWUdKMWtsVTgyMGdCL3pCYy9GUzU4Qk40dm1la3NtNDUz?=
 =?utf-8?B?WmpjS3lOQ1l4T0ozVjF5cUNmMzVLNEJ3MU9DSHNmTU1EcWhINEwrSEppQjVR?=
 =?utf-8?B?K0p0RTR5UXV1K3dCMndYeXYyeFVhek1YVXBNS25XMzNzSHU5dlIrNlVER0to?=
 =?utf-8?B?NktLRDVoVlczbFZtcnpDQ3pRdzRUT1hvSk03WUdpMkk5WUJnWUxRRUs2VTlO?=
 =?utf-8?B?OXVZdzhTWkZmalJEMTI4S20yV2dLaGhBYTNIM3FhVWMreTlLQkRTajJkaWxE?=
 =?utf-8?B?dExxQWJiMDVhWDFDZWUwZ0FMdTlrZnVqTkJFbTBaak11WnNOMnRJRE9WZUJN?=
 =?utf-8?B?c2JjUEY1dUZLcnd3Z1BKZ2hkQ2FXallmZTl4M0xtZ3hRcmtqU2Uxd2dFdTJo?=
 =?utf-8?B?RUgvTnJwQTdDWnFTeFROYm1wblQ3VHJMK1A3bDZNb3FlbzJqOUVNdzlPaG0w?=
 =?utf-8?B?NkgvK1JKVU9qRTdrSDRmeVlUNWFmbHhMTm80RnQvNVR4MG5sUEtvOGhMdjVa?=
 =?utf-8?B?eVNMeXVNVTBGSHpYTzZlblZKbU93RXM1RE5aOVA0WTJ5M1lHTGVTZzMvOGx5?=
 =?utf-8?B?Tkp6RWMwamtwMktXM2gzYnRsTitwM3BsQWVZSnZZWFlqdERlZk9wTHQwaEtz?=
 =?utf-8?B?NU04UWpDa2drcmVDdGwvdWI5eFdjZnZsWENyMGU3d011akZEQlR5dXJYVjVr?=
 =?utf-8?B?cnFtd2tWZzJCUUhScnEvdld0UExqSWdrZ3NBbk00SUdiTFNhdDJZSFFhR0ty?=
 =?utf-8?B?YUxlSXprdDF2TUpTVmtzWlh4b1JUQURxaDRvR1ZCS1JWMWJUS3QrTzJ5dVQ2?=
 =?utf-8?B?Vll0eklQZS9DS21ZT0xPYjkvNGVqeEYzOXY1dFBsQjdXZ2tWcjZNMTg1MDNO?=
 =?utf-8?B?MWdwT3lmZ21FZ2Q5VFJrZmNpSkRiVkxjbWdVdnc2algra3d2YVE3U1lWS1Bo?=
 =?utf-8?B?ajZLRXRWYURkUkk0bUxzQ3ovTktMOU82UCtKQnNBR05Bc0JQMDRwaDhXaE4r?=
 =?utf-8?B?UEVNRlVBbjdkc3luZ01PYi9ENzdJTXFmQjJya0FMSEpXZGJmTGRaZkxNNjZK?=
 =?utf-8?B?WEdrTmlZTFJMYTNqVDhwMlVseUoxQUM0SEZ2WFNYaHBQY0tNMVdXSTFiRkVv?=
 =?utf-8?B?Y2hpOU9lOExVdzRIWnBidHFpdVhiRlRCOUJwWEp1Y1N2aVBSb2VodHFiRFZz?=
 =?utf-8?B?eXpYNUZ2THZmUDQ2c1NOTGlObDRNUEFZRnlWRDN6cll3N0xTZ3dsZ0graXVk?=
 =?utf-8?B?UkY3ZERpNEFWd0xHcjZaUDRrcUVFNU9TT3NkTXV4ZlRIN0VOTFBSU2ZVNUc4?=
 =?utf-8?B?R2l5bVBRVU1FaS9CUlZCbWhONG5DMzdnVFlJNVNyam1CTzA0R3diSmJ5VVpF?=
 =?utf-8?B?SVVCNWVsSlZLUE9GVjZCMWdwSUZBclVJaUlEMFNyVHF2ZVBsamV6REl2UTBT?=
 =?utf-8?B?OGZQc2RFeHYvOHJURFNyRUtEeDRScDZIVm1YYzFsaW5UZU9uWWRmbkhNMGNU?=
 =?utf-8?B?dUhYVnJ3Mmx0MUE4UUJhMHZ6WkFveWVDK29XRkcwL2lDMGNIVTEyd0pvSlBL?=
 =?utf-8?B?YmFmWHB2S3RrVzZGeTNEdmtXcmtZVHNMTk9uc3M1RmcrVUE4N3gwTjNicnJB?=
 =?utf-8?B?cHM1OHduNE92VThYQzZpWnI3cGZXRVZTQmVXTzVtY0Vhb1dKaThYSkpZVGkz?=
 =?utf-8?Q?m7GB3iSYQfrqBoyTdYTrjNU=3D?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 40a7b4bf-0bf1-4a5a-3cd5-08dbb5b8252c
X-MS-Exchange-CrossTenant-AuthSource: VE1PR08MB4974.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2023 06:51:10.6706
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 63arxPl/sUn2qCkSU2V/IkFQ7xSl62F1tE2vYm4HoqebaxdKRiokQhLr/YuQr5poJutKXZqRt1/9psTrcqOBVsQmDlraX/z2hlT1OUmhWvU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9322
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 14 Sep 2023 23:52:25 -0700 (PDT)

The TPS6598x PD controller provides an active-high hardware reset input
that reinitializes all device settings. If it is not grounded by
design, the driver must be able to de-assert it in order to initialize
the device.

The PD controller is not ready for registration right after the reset
de-assertion and a delay must be introduced in that case. According to
TI, the delay can reach up to 1000 ms [1], which is in line with the
experimental results obtained with a TPS65987D.

Add a GPIO descriptor for the reset signal and basic reset management
for initialization and suspend/resume.

[1] https://e2e.ti.com/support/power-management-group/power-management/
f/power-management-forum/1269856/tps65987d-tps65987d-reset-de-assert-
to-normal-operation/4809389#4809389

Signed-off-by: Javier Carrasco <javier.carrasco@wolfvision.net>
---
 drivers/usb/typec/tipd/core.c | 21 ++++++++++++++++++++-
 1 file changed, 20 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
index 37b56ce75f39..550f5913e985 100644
--- a/drivers/usb/typec/tipd/core.c
+++ b/drivers/usb/typec/tipd/core.c
@@ -8,6 +8,7 @@
 
 #include <linux/i2c.h>
 #include <linux/acpi.h>
+#include <linux/gpio/consumer.h>
 #include <linux/module.h>
 #include <linux/of.h>
 #include <linux/power_supply.h>
@@ -43,6 +44,9 @@
 /* TPS_REG_SYSTEM_CONF bits */
 #define TPS_SYSCONF_PORTINFO(c)		((c) & 7)
 
+/* reset de-assertion to ready for operation */
+#define SETUP_MS			1000
+
 enum {
 	TPS_PORTINFO_SINK,
 	TPS_PORTINFO_SINK_ACCESSORY,
@@ -86,6 +90,7 @@ struct tps6598x {
 	struct mutex lock; /* device lock */
 	u8 i2c_protocol:1;
 
+	struct gpio_desc *reset;
 	struct typec_port *port;
 	struct typec_partner *partner;
 	struct usb_pd_identity partner_identity;
@@ -717,6 +722,13 @@ static int tps6598x_probe(struct i2c_client *client)
 	mutex_init(&tps->lock);
 	tps->dev = &client->dev;
 
+	tps->reset = devm_gpiod_get_optional(tps->dev, "reset", GPIOD_OUT_LOW);
+	if (IS_ERR(tps->reset))
+		return dev_err_probe(tps->dev, PTR_ERR(tps->reset),
+				     "failed to get reset GPIO\n");
+	if (tps->reset)
+		msleep(SETUP_MS);
+
 	tps->regmap = devm_regmap_init_i2c(client, &tps6598x_regmap_config);
 	if (IS_ERR(tps->regmap))
 		return PTR_ERR(tps->regmap);
@@ -892,6 +904,9 @@ static void tps6598x_remove(struct i2c_client *client)
 	tps6598x_disconnect(tps, 0);
 	typec_unregister_port(tps->port);
 	usb_role_switch_put(tps->role_sw);
+
+	if (tps->reset)
+		gpiod_set_value_cansleep(tps->reset, 1);
 }
 
 static int __maybe_unused tps6598x_suspend(struct device *dev)
@@ -902,7 +917,8 @@ static int __maybe_unused tps6598x_suspend(struct device *dev)
 	if (tps->wakeup) {
 		disable_irq(client->irq);
 		enable_irq_wake(client->irq);
-	}
+	} else if (tps->reset)
+		gpiod_set_value_cansleep(tps->reset, 1);
 
 	if (!client->irq)
 		cancel_delayed_work_sync(&tps->wq_poll);
@@ -918,6 +934,9 @@ static int __maybe_unused tps6598x_resume(struct device *dev)
 	if (tps->wakeup) {
 		disable_irq_wake(client->irq);
 		enable_irq(client->irq);
+	} else if (tps->reset) {
+		gpiod_set_value_cansleep(tps->reset, 0);
+		msleep(SETUP_MS);
 	}
 
 	if (!client->irq)

-- 
2.39.2