Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <05121c7e-b7ad-e5f7-e42c-12e30369e559@intel.com>
Date:   Fri, 15 Sep 2023 09:52:15 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.0
Subject: Re: [PATCH v6 05/25] x86/fpu/xstate: Remove kernel dynamic xfeatures
 from kernel default_features
To:     Dave Hansen <dave.hansen@intel.com>, <seanjc@google.com>,
        <pbonzini@redhat.com>, <kvm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     <peterz@infradead.org>, <chao.gao@intel.com>,
        <rick.p.edgecombe@intel.com>, <john.allen@amd.com>
References: <20230914063325.85503-1-weijiang.yang@intel.com>
 <20230914063325.85503-6-weijiang.yang@intel.com>
 <d8c3888c-4266-d781-5d0a-381a57a9c35c@intel.com>
Content-Language: en-US
From:   "Yang, Weijiang" <weijiang.yang@intel.com>
In-Reply-To: <d8c3888c-4266-d781-5d0a-381a57a9c35c@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c3dlTEx2Q0F6YWRHcjdoYmtmaG0xMk5vT3pmUDJBcWhlUUM5NTl5L3pUdG1i?=
 =?utf-8?B?aG8vd2xvM2hhOFBDT1JKL1pyRWtBTW5Jblpha2kyYXQ4N3F2U1hQOVhIRWtP?=
 =?utf-8?B?Wi9IeStYc25rOHV2Z2JpWWJHeVNyV0xPdkxpMGpjMS9sU2hUN0JmMzhvOTQ4?=
 =?utf-8?B?VWN4KzUvRHlzZERZdVNNSk9aTWNqK0d4eWZRbm9SNFdsREg1US9QMlhOYXAx?=
 =?utf-8?B?a0JTeEVDR0U3Z0EvWFE1bWZhMXNBS1FTbWtjN3FmRjRBeGRKNVBrdkNLaEg0?=
 =?utf-8?B?WHVIbjJudkxlazdDSkJaTzg4VlFvZGpXMVJWYWxhbzV0K0VxbVo2aGlETGU3?=
 =?utf-8?B?K2lPalZCeHZBempYbkQwakJiczliWFZKUEJSaHp1aGw0OXI0c0pZVkl3RzRM?=
 =?utf-8?B?ZmpzYS84VTlQZm5vdFRnNEZrQkVyd0ZaeWlEOTlVRmpXVzdKUEs1azhPOTV3?=
 =?utf-8?B?a2grTS91cGlOei9LZ2pJVTZoNTNjUXQ0cEFsQmZvQXM0cDVhb3pXMEhCRWhZ?=
 =?utf-8?B?NDRwMU84OWFzV3JHUDIraGN3NUJXcnhXM0o1UjFGd3U5TW9UZnNHSHZxYnRy?=
 =?utf-8?B?RFBRVEw5WUxsdDIxSEJQUlJQVlYzdklBMTUwd2xsVVRsQXE1T1NqRXM4bXhl?=
 =?utf-8?B?MjNwSm0zMUJBWDJ0a0VpM3JYWE8ydXBYTmZOeHN5aDB3czJIb01MK3BjMVFG?=
 =?utf-8?B?ZXk5a2NwWmpXeGxCbXFUekJBZTYzOWVFL0pQaGpLVjRLQ1dWUkYyL3N1TDBD?=
 =?utf-8?B?SU5zNHpYYUlBRm91YlRGNGp2eC9SNzVDYzJtZk4rMXMzWTFrUGdadkptUWdp?=
 =?utf-8?B?bVJaWUFSd2lFOTYzdVNaWXJYZEpybFUxMWdWTGFnK3FPS3puc1JFdXdNYWNM?=
 =?utf-8?B?R0ttMTVXYUpLeWpPaXhxTlNTMXJWZHhKUlNoaUxFYm9DenlYcWQrdGlUaWpK?=
 =?utf-8?B?RENQa0hSRUF6YTZIdHJ0dlU1Q0hJazA0emo0bkI0L3NTbldpamNweEhVTDlY?=
 =?utf-8?B?aEc3NmIyaDN2Wm9YYSt3ZXJWTW1nWU5ibWFWeEJhV01TQ0Uxb2tWWURndkky?=
 =?utf-8?B?dy9vbzA1OTRGZkFWSE5RZVl6UWFva1h2K1pXU0Q4dVVHMHZmK0FNV1Noc3Fq?=
 =?utf-8?B?VktrcGxOSnI0Ym5ZeDh1UkdIU3UxUDhrYldzcnZ5OTVFcllyampNMWZkbTdQ?=
 =?utf-8?B?alY5NzFHT3h6dkw0THVqNHRyZ2FBMVVHQWs1TU4wM0FMQlpaTmFjSmhMcC9v?=
 =?utf-8?B?UnZmc3ZPRmtPQXdndjJLd3hWdXpTNlZ6UkhycU45QlNvbHV3MG1PTjZhZEs3?=
 =?utf-8?B?eFBkMGpvdjhLK2xGSHVreWJHaTVJRk1xc0pxK0ZnV3ZkS2dPRlVjbDVZN3JW?=
 =?utf-8?B?UEliUStzRnRnenBFUGlVVHBzY0tUZzBNT2s4OEladGJqVHN2VUdoZjFqM0N1?=
 =?utf-8?B?UUpXZkdtekUvUjlYZ0g3V3RGM0tNUFVXZ0ZGVit0dXJFUHBJZS9nSUU4Z1JK?=
 =?utf-8?B?VGlvRE56RWZ3aSsrUlpNWTYycjBYQ0pxQW90M1pYdkFrZG04eDdCZTE4bkU3?=
 =?utf-8?B?Q1lkbDU3dkUxYnVweGV4YjlSZzJpYldkcDZpV2p3dHNualpVaUpzS290WWp6?=
 =?utf-8?B?SThlMC9tZ0hyTGNMdUpEN281cjFnSG5Ld3RFWER5YzJoQlVPMnd5dnh4R2J1?=
 =?utf-8?B?MDRmeHpveUZNaUxPaEdHU0ptNWpMeWdQclN6dWlObTk2a2RvZXdJMWhNSklP?=
 =?utf-8?B?NzBxVFNqSmdVK2lvMEpaNGFwdEhyRXQ3cnZKNGFUZXBGOFJlV2NXQktHeGhB?=
 =?utf-8?B?eWRZbk9MOVZuYmJqVG14NWlNbllkSEZkMnAxR3dIL2s3VFNHUVdnYXlpU0pS?=
 =?utf-8?B?ZlNDTWk5QXhFdkkxYXV4Ui9IYUZDMVFoRXFVT2s4U1RjZldDckNzSkV3Qmdj?=
 =?utf-8?B?MjhMSE0vMUNIOTh5YkhPaU9IN2x3Umt0WkVUa2VoWnVkNGNYN3lieTlVNWMx?=
 =?utf-8?B?NjVQQ2lMR0ZzcnN3bDh0WGxMUkt2OWZvNDg1QUR3dkJwS1ppU1VFb2plYXZ2?=
 =?utf-8?B?cEFXSVhuM09Ba2ZocmZBcGpwUWFzM2l1U0NJaUFMSjh5Skl3MzVOUXZ4cmsx?=
 =?utf-8?B?VUk3WE04Qi9CNEFUckZtdGpaMFdFRnlwWkRaUnpBTGlkMEhORERkOHFseGw0?=
 =?utf-8?B?Snc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6c443302-6be2-4fed-0ec7-08dbb58e693e
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2023 01:52:25.9706
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5o4frl+vgheLlSJxug36HYSEvqi6vBevS7eP6r4BGLE6upxLx7/Hqy58l8l1M5QGHkMgGFIJaWskF++8UKOXKg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5054
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 14 Sep 2023 18:55:35 -0700 (PDT)
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email

On 9/15/2023 12:22 AM, Dave Hansen wrote:
> On 9/13/23 23:33, Yang Weijiang wrote:
>> --- a/arch/x86/kernel/fpu/xstate.c
>> +++ b/arch/x86/kernel/fpu/xstate.c
>> @@ -845,6 +845,7 @@ void __init fpu__init_system_xstate(unsigned int legacy_size)
>>   	/* Clean out dynamic features from default */
>>   	fpu_kernel_cfg.default_features = fpu_kernel_cfg.max_features;
>>   	fpu_kernel_cfg.default_features &= ~XFEATURE_MASK_USER_DYNAMIC;
>> +	fpu_kernel_cfg.default_features &= ~fpu_kernel_dynamic_xfeatures;
> I'd much rather that this be a closer analog to XFEATURE_MASK_USER_DYNAMIC.
>
> Please define a XFEATURE_MASK_KERNEL_DYNAMIC value and use it here.
> Don't use a dynamically generated one.

OK,  I will change it, thanks!