From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Olof Johansson <olof@lixom.net>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fat: silence warning for 64KB PAGE_SIZE builds
References: <20071107051540.GB24266@lixom.net>
Date: Wed, 07 Nov 2007 23:39:01 +0900
In-Reply-To: <20071107051540.GB24266@lixom.net> (Olof Johansson's message of
	"Tue, 6 Nov 2007 23:15:40 -0600")
Message-ID: <87prymqfwa.fsf@duaron.myhome.or.jp>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1046
Lines: 25

Olof Johansson <olof@lixom.net> writes:

> logical_sector_size can never be more than 16 bits worth, but switching
> it to an int silences gcc. It's a sanity check that can never fail with
> 64KB PAGE_SIZE but it seems like it'd still be useful for other page
> sizes, so it's worth keeping:
>
>         if (!is_power_of_2(logical_sector_size)
>             || (logical_sector_size < 512)
>             || (PAGE_CACHE_SIZE < logical_sector_size)) {
>                 if (!silent)
>                         printk(KERN_ERR "FAT: bogus logical sector size %u\n",
>                                logical_sector_size);
>                 brelse(bh);
>                 goto out_invalid;
>         }

Please use 4096 instead of allowing it, at least for now.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/