Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <1c887615-0e59-8556-e2ab-b985033519d7@linux.intel.com>
Date:   Fri, 15 Sep 2023 11:16:57 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH] ASoC: hdaudio.c: Add missing check for devm_kstrdup
Content-Language: en-US
To:     Chen Ni <nichen@iscas.ac.cn>, cezary.rojewski@intel.com,
        pierre-louis.bossart@linux.intel.com,
        liam.r.girdwood@linux.intel.com, peter.ujfalusi@linux.intel.com,
        yung-chuan.liao@linux.intel.com, ranjani.sridharan@linux.intel.com,
        kai.vehmanen@linux.intel.com, broonie@kernel.org, perex@perex.cz,
        tiwai@suse.com, kuninori.morimoto.gx@renesas.com,
        brent.lu@intel.com
Cc:     alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
References: <20230915021344.3078-1-nichen@iscas.ac.cn>
From:   =?UTF-8?Q?Amadeusz_S=c5=82awi=c5=84ski?= 
        <amadeuszx.slawinski@linux.intel.com>
In-Reply-To: <20230915021344.3078-1-nichen@iscas.ac.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 9/15/2023 4:13 AM, Chen Ni wrote:
> Because of the potential failure of the devm_kstrdup(), the
> dl[i].codecs->name could be NULL.
> Therefore, we need to check it and return -ENOMEM in order to transfer
> the error.
> 
> Fixes: 97030a43371e ("ASoC: Intel: avs: Add HDAudio machine board")
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
>   sound/soc/intel/avs/boards/hdaudio.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/sound/soc/intel/avs/boards/hdaudio.c b/sound/soc/intel/avs/boards/hdaudio.c
> index cb00bc86ac94..8876558f19a1 100644
> --- a/sound/soc/intel/avs/boards/hdaudio.c
> +++ b/sound/soc/intel/avs/boards/hdaudio.c
> @@ -55,6 +55,9 @@ static int avs_create_dai_links(struct device *dev, struct hda_codec *codec, int
>   			return -ENOMEM;
>   
>   		dl[i].codecs->name = devm_kstrdup(dev, cname, GFP_KERNEL);
> +		if (!dl[i].codecs->name)
> +			return -ENOMEM;
> +
>   		dl[i].codecs->dai_name = pcm->name;
>   		dl[i].num_codecs = 1;
>   		dl[i].num_cpus = 1;

Good catch

Reviewed-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>