Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
MIME-Version: 1.0
References: <20230913101634.553699-1-john.ogness@linutronix.de>
In-Reply-To: <20230913101634.553699-1-john.ogness@linutronix.de>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Fri, 15 Sep 2023 13:24:25 +0200
Message-ID: <CAMuHMdWts9NKU=DfPujTKAQNU6T3uawVtejwiTkp=usMu0rH-A@mail.gmail.com>
Subject: Re: [PATCH] workqueue: fix duplicate wq_update_pod_attrs_buf allocation
To:     John Ogness <john.ogness@linutronix.de>
Cc:     Tejun Heo <tj@kernel.org>, Lai Jiangshan <jiangshanlai@gmail.com>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Wed, Sep 13, 2023 at 8:05 PM John Ogness <john.ogness@linutronix.de> wrote:
> One of the hunks for the patch resulting in
> commit 84193c07105c ("workqueue: Generalize unbound CPU pods") was
> applied incorrectly. This resulted in @wq_update_pod_attrs_buf
> being allocated twice.
>
> From the kmemleak detector:
>
> unreferenced object 0xc0000000040074c0 (size 64):
>   comm "swapper/0", pid 0, jiffies 4294937296 (age 1936.580s)
>   hex dump (first 32 bytes):
>     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 03  ................
>     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
>   backtrace:
>     [<0000000076b83a6e>] .kmalloc_trace+0x54/0x190
>     [<00000000898f2356>] .alloc_workqueue_attrs+0x2c/0x60
>     [<0000000063365e1f>] .workqueue_init_early+0xe4/0x4b8
>     [<00000000ca97ff39>] .start_kernel+0x8d0/0xba4
>     [<000000002ee12080>] start_here_common+0x1c/0x20
>
> Remove the redundant allocation.
>
> Signed-off-by: John Ogness <john.ogness@linutronix.de>

Stephen posted a similar patch before:
https://lore.kernel.org/all/20230905174935.2d75feab@gandalf.local.home

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds