Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <9b0dde15-12e3-713e-a2f9-9b2534691476@collabora.com>
Date:   Fri, 15 Sep 2023 11:02:22 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.0
Subject: Re: [PATCH] drm/mediatek: dsi: Fix EOTp generation
Content-Language: en-US
To:     Michael Walle <mwalle@kernel.org>
Cc:     Chun-Kuang Hu <chunkuang.hu@kernel.org>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Jitao Shi <jitao.shi@mediatek.com>,
        dri-devel@lists.freedesktop.org,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
References: <20230915075756.263591-1-mwalle@kernel.org>
 <0a184b35-133b-483c-d475-01120fbdc2ca@collabora.com>
 <eb1f4f78be9b2da3ae2d54ec9417f2f7@kernel.org>
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>
In-Reply-To: <eb1f4f78be9b2da3ae2d54ec9417f2f7@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Il 15/09/23 11:01, Michael Walle ha scritto:
> Hi,
> 
> Am 2023-09-15 10:58, schrieb AngeloGioacchino Del Regno:
>> Il 15/09/23 09:57, Michael Walle ha scritto:
>>> The commit c87d1c4b5b9a ("drm/mediatek: dsi: Use symbolized register
>>> definition") inverted the logic of the control bit. Maybe it was because
>>> of the bad naming which was fixed in commit 0f3b68b66a6d ("drm/dsi: Add
>>> _NO_ to MIPI_DSI_* flags disabling features"). In any case, the logic
>>> wrong and there will be no EOTp on the DSI link by default. Fix it.
>>>
>>> Fixes: c87d1c4b5b9a ("drm/mediatek: dsi: Use symbolized register definition")
>>> Signed-off-by: Michael Walle <mwalle@kernel.org>
>>
>> Hello Michael,
>> your commit is missing a small piece! :-)
>>
>> Besides, I've already sent a fix for what you're trying to do here:
>> https://lore.kernel.org/linux-arm-kernel/07c93d61-c5fd-f074-abb2-73fdaa81fd65@collabora.com/T/
> 
> Ahh thanks, didn't noticed this. If not already applied, I'll send
> a Tested-by: later.
> 

No worries, it happens.

Cheers,
Angelo

> Please disregard this patch then.
> 
> -michael