Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp4574565rdb;
        Fri, 15 Sep 2023 06:28:46 -0700 (PDT)
X-Google-Smtp-Source: AGHT+IH/zJUEbahHtmWgQLNJvmzLVMhYPthQQYqom9i5nN0OqmTvvKS69apC246Rs4RB6aEZnOy+
X-Received: by 2002:a05:6a20:244e:b0:134:8d7f:f4d9 with SMTP id t14-20020a056a20244e00b001348d7ff4d9mr2062052pzc.52.1694784526539;
        Fri, 15 Sep 2023 06:28:46 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1694784526; cv=none;
        d=google.com; s=arc-20160816;
        b=LJKIkvXuyhta1Nmsfm1WHJ5XiIPLjQhC0X5J0R1BH+blngYwNQxG9ZNPogDZUZCawO
         fE16wfDAV+dwKz8e3oZcVJ1n3tpqge0e8CvzLpfZfoop8sV0sTfuSpQ9BGxxtftnlkuG
         qCUZM2MzIqUZirEXzCbSm4PleKi9FCBJmPIZ9YO9glEbp3I8EM4B4DP+kj2MJdsNl2OO
         ph1bUKXrtpDuT4tG0gH9UpZw9t3CbCgnwaPAXUfGm/wAvwPE0so+GpypI2f7LYTEUJ3t
         jbkOFQJ5BbGUYmYlI5UmCRs5IAeynPDXqNQOmRsoDeTtRwmfiJqt4v34r7HDMS6315vq
         7M7A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:mime-version:user-agent:references:in-reply-to
         :subject:cc:to:from:message-id:date:dkim-signature:dkim-signature;
        bh=q2Beeu5CPtfOOLJTu6GgdOUwpcTJvByrQgKRtH+jqas=;
        fh=ioU4v7Iz2qoS2/+kvYEd2Bw84BRg6F2vLjWVJuhFnx0=;
        b=xnOs1yMpH2UO7qum6TSozv34U674JghBQIxzPKuV9xdoAUbEqJ9jTD3M7dg5vM9kW0
         DHTczgA/MGOxIeD7eFBY9QoEMGSYvwSdJBNr+YAin0suFb4QF1+Vz7ZEoDn4e0/jqrXw
         3jG6RiLFNg/qFq2vQX17jCi7hlOtmYE01G0GlXXNZDro0doCM+SULen7626CDTECHYDk
         PD1NHNEiT7yJq+oaDgqMrea5X7kdRTEz87IcxOH/YrQfNyaXNt285131k0aTslZ689ne
         JSyrcDSZnorhy2jSwLt7KTd6f3r3/DsfJrY9QrYGi7/QJzOXdDNprnfi1ENtxkk92vHP
         F74A==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=rwOdIsx5;
       dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b="TL/0dtrA";
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from groat.vger.email (groat.vger.email. [23.128.96.35])
        by mx.google.com with ESMTPS id x2-20020a056a00188200b0068fd7cb5864si3579184pfh.263.2023.09.15.06.28.32
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Fri, 15 Sep 2023 06:28:46 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=rwOdIsx5;
       dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b="TL/0dtrA";
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de
Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0])
	by groat.vger.email (Postfix) with ESMTP id 925AA836D25B;
	Fri, 15 Sep 2023 03:28:05 -0700 (PDT)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S232796AbjIOK1y (ORCPT <rfc822;benlin170369@gmail.com>
        + 99 others); Fri, 15 Sep 2023 06:27:54 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42684 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S232986AbjIOIcR (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 15 Sep 2023 04:32:17 -0400
Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58A4A2D50
        for <linux-kernel@vger.kernel.org>; Fri, 15 Sep 2023 01:31:23 -0700 (PDT)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
        (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
         key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
        (No client certificate requested)
        by smtp-out1.suse.de (Postfix) with ESMTPS id DC06A2187D;
        Fri, 15 Sep 2023 08:31:21 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
        t=1694766681; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=q2Beeu5CPtfOOLJTu6GgdOUwpcTJvByrQgKRtH+jqas=;
        b=rwOdIsx5ZAji3I0kvtYRyEICeSjZDJV7AVZfAxDjDdpOAcxgxt7gzfFquV4VyKf6b66TSW
        4h0H0MXSuhcNz4Hze9nvbFE7pW+7IwOvh/kzd7vfuTQszdxZBkjTttVSnSQBHeq+C273iJ
        yM+gkJkCViqw3tRNMg3KI78JHlMJXtM=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
        s=susede2_ed25519; t=1694766681;
        h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=q2Beeu5CPtfOOLJTu6GgdOUwpcTJvByrQgKRtH+jqas=;
        b=TL/0dtrAOQ0daQwqQtmkkm+RqbpF2gHaH80OM/UQymRDE9BlRwlq2dFQIFRInUtCGXGzuh
        6JP9BH3KnlKnSiBw==
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
        (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
         key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
        (No client certificate requested)
        by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A05491358A;
        Fri, 15 Sep 2023 08:31:21 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
        by imap2.suse-dmz.suse.de with ESMTPSA
        id GnXmJVkWBGVuQwAAMHmgww
        (envelope-from <tiwai@suse.de>); Fri, 15 Sep 2023 08:31:21 +0000
Date:   Fri, 15 Sep 2023 10:31:21 +0200
Message-ID: <87o7i3x2g6.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Richard Fitzgerald <rf@opensource.cirrus.com>
Cc:     <tiwai@suse.com>, <alsa-devel@alsa-project.org>,
        <patches@opensource.cirrus.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] ALSA: hda: cs35l56: Fix missing RESET GPIO if _SUB is missing
In-Reply-To: <20230914152525.20829-1-rf@opensource.cirrus.com>
References: <20230914152525.20829-1-rf@opensource.cirrus.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Fri, 15 Sep 2023 03:28:05 -0700 (PDT)

On Thu, 14 Sep 2023 17:25:25 +0200,
Richard Fitzgerald wrote:
> 
> In cs35l56_hda_read_acpi() do not return if ACPI _SUB is missing.
> 
> A missing _SUB means that the driver cannot load a system-specific
> firmware, because the firmware is identified by the _SUB. But it can
> fallback to a generic firmware. Unfortunately this was being handled
> by immediately returning 0, which would skip the remaining ACPI
> configuration in cs35l56_hda_read_acpi() and so it would not get the
> RESET GPIO.
> 
> Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
> Fixes: 73cfbfa9caea ("ALSA: hda/cs35l56: Add driver for Cirrus Logic CS35L56 amplifier")

Thanks, applied now.


Takashi