Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <f76e1cc8-fc48-4208-bbe4-9204d9d28363@quicinc.com>
Date:   Fri, 15 Sep 2023 19:18:55 +0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 8/8] arm64: defconfig: enable interconnect and pinctrl
 for SM4450
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        <will@kernel.org>, <robin.murphy@arm.com>, <joro@8bytes.org>,
        <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <conor+dt@kernel.org>, <agross@kernel.org>, <andersson@kernel.org>,
        <konrad.dybcio@linaro.org>, <catalin.marinas@arm.com>
CC:     <geert+renesas@glider.be>, <arnd@arndb.de>,
        <neil.armstrong@linaro.org>, <nfraprado@collabora.com>,
        <rafal@milecki.pl>, <peng.fan@nxp.com>,
        <linux-arm-kernel@lists.infradead.org>, <iommu@lists.linux.dev>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-msm@vger.kernel.org>, <quic_tsoni@quicinc.com>,
        <quic_shashim@quicinc.com>, <quic_kaushalk@quicinc.com>,
        <quic_tdas@quicinc.com>, <quic_tingweiz@quicinc.com>,
        <quic_aiquny@quicinc.com>, <kernel@quicinc.com>
References: <20230915021509.25773-1-quic_tengfan@quicinc.com>
 <20230915021509.25773-10-quic_tengfan@quicinc.com>
 <8f2c9664-a2c8-50dc-8a1c-e50a071ebeb2@linaro.org>
 <e9ff05b3-2742-416e-b417-5e2414036008@quicinc.com>
 <0a34dd35-7aea-4655-4cdd-e7196a1ba52b@linaro.org>
From:   Tengfei Fan <quic_tengfan@quicinc.com>
In-Reply-To: <0a34dd35-7aea-4655-4cdd-e7196a1ba52b@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 9/15/2023 5:16 PM, Krzysztof Kozlowski 写道:
> On 15/09/2023 11:12, Tengfei Fan wrote:
>>
>>
>> 在 9/15/2023 3:21 PM, Krzysztof Kozlowski 写道:
>>> On 15/09/2023 04:15, Tengfei Fan wrote:
>>>> Add the SM4450 interconnect and pinctrl drivers as built-in for
>>>> support the Qualcomm SM4450 platform to boot to uart shell.
>>>>
>>>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>>>> ---
>>>>    arch/arm64/configs/defconfig | 2 ++
>>>>    1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>>>> index ec59174b14db..e91993de865e 100644
>>>> --- a/arch/arm64/configs/defconfig
>>>> +++ b/arch/arm64/configs/defconfig
>>>> @@ -598,6 +598,7 @@ CONFIG_PINCTRL_SC8280XP=y
>>>>    CONFIG_PINCTRL_SDM660=y
>>>>    CONFIG_PINCTRL_SDM670=y
>>>>    CONFIG_PINCTRL_SDM845=y
>>>> +CONFIG_PINCTRL_SM4450=y
>>>>    CONFIG_PINCTRL_SM6115=y
>>>>    CONFIG_PINCTRL_SM6125=y
>>>>    CONFIG_PINCTRL_SM6350=y
>>>> @@ -1500,6 +1501,7 @@ CONFIG_INTERCONNECT_QCOM_SC7280=y
>>>>    CONFIG_INTERCONNECT_QCOM_SC8180X=y
>>>>    CONFIG_INTERCONNECT_QCOM_SC8280XP=y
>>>>    CONFIG_INTERCONNECT_QCOM_SDM845=y
>>>> +CONFIG_INTERCONNECT_QCOM_SM4450=y
>>>
>>> Why it cannot be =m?
>>>
>>> Best regards,
>>> Krzysztof
>>>
>>
>> Hi Krzysztof,
>> Because system haven't capacity of loading ko files at this time on
>> SM4450 platform, so setting to "Y".
> 
> Hm? System has this capability. All systems have. What is so different
> on SM4450 comparing to everything else we have here?
> 
> No, this should be =m and you need to fix your system.
> 
> Best regards,
> Krzysztof
> 
Hi Krzysztof,
Find new way which can load ko files on SM4450 platform, still need use 
"Y", because of some other modules have dependence to these two config, 
like scm, smmu module drivers, uart shell console cannot be got if set 
to "m".

Also do test for setting these two config to "m" on SM8450 platform, get 
uart shell consle failed if so setting.

-- 
Thx and BRs,
Tengfei Fan