Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
From:   "Romanowski, Rafal" <rafal.romanowski@intel.com>
To:     "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        poros <poros@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
CC:     ivecera <ivecera@redhat.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "edumazet@google.com" <edumazet@google.com>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "horms@kernel.org" <horms@kernel.org>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "davem@davemloft.net" <davem@davemloft.net>
Subject: RE: [Intel-wired-lan] [PATCH net v2 2/2] iavf: schedule a request
 immediately after add/delete vlan
Thread-Topic: [Intel-wired-lan] [PATCH net v2 2/2] iavf: schedule a request
 immediately after add/delete vlan
Thread-Index: AQHZ4aKdRNkl6NYnMUmPbKg7+r3ofLARXcQAgAo/X8A=
Date:   Fri, 15 Sep 2023 08:40:11 +0000
Message-ID: <BL0PR11MB3521F2616C7A00C2BA9546BA8FF6A@BL0PR11MB3521.namprd11.prod.outlook.com>
References: <20230907150251.224931-1-poros@redhat.com>
 <20230907150251.224931-2-poros@redhat.com>
 <9a84e07a-d74b-aa8c-3da2-a8fa0838a11e@intel.com>
In-Reply-To: <9a84e07a-d74b-aa8c-3da2-a8fa0838a11e@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zs2O4YMpR2rVbUKMHpADl4mSyH0axlSBufYBvyN70MWFFlkR8G95bwnzw44T?=
 =?us-ascii?Q?bD3daCWaeLvBZFKeTyHVGBMRQo4jhVwzEOnpXoolfDUXBR209R8X78512o9F?=
 =?us-ascii?Q?BaNt/Cq/FzK7mvrjG1gR3wp0mrBuQbn7lRfWIr2t1faOVkpgYTbn54abO8xJ?=
 =?us-ascii?Q?Who+TAg1b8Dk0lWtrn2713gQ5QpdgLHqeAMhvr2FJt2YZHLkYntNN9YWYWzN?=
 =?us-ascii?Q?BFEX8f8orJLNpsm2dumGqVua3JeMR7kDQjW799v8vzjuIKkGNqbsnOQLVC1u?=
 =?us-ascii?Q?NNFfxg2EThPZXllZOaiao6MxYjnccEovn/1Au4qRYgTpgCjvhL+XLnK0R6dP?=
 =?us-ascii?Q?+Pv9ebzho1m/+y4/psHmFDa/anrdk+P3dY1gDKGjInSQL43UcMu5Q+C21wj4?=
 =?us-ascii?Q?ogg23dx/Ko6eiN8x6JTfCng8C72AGohF3Z0XVG7/uY4eqdtekSGzESR8XZXn?=
 =?us-ascii?Q?oUxtZDy2f4lgzqbDmOyQxfdIydeIdTlu6UJB2XMNtdL2Ai0B5A3YMbnz1Tlm?=
 =?us-ascii?Q?BdG76Sgkn9Y75Vdq94ymgqxYBd64w/WZOWSFgNbrOjvFDwLifMaP9zaBmm1q?=
 =?us-ascii?Q?PAqVdMjYuSEo5vOudX3PwnvhEzjiP3qjk+cxWTq2XQjdt/I+ho8f8Smh6Wxe?=
 =?us-ascii?Q?ll+GjBiLTlWjfBrp6mOKOUJidabidyIjxuE9//k71j6YCLMUzQ2DfPQyYncE?=
 =?us-ascii?Q?CYCr1r3FZ/uebRoc7WabMhv8IXiRKw1MIhxNXLr7hpEkNE3+4yjidHGmxSUQ?=
 =?us-ascii?Q?UHB7ZZz7bWvU5KCfrR/mMh4nUNC2an6VdulJgCJ3iB+kqeJa25Gbfm2DwWca?=
 =?us-ascii?Q?1DyWCS1ITRV9AQlm2nh4vaFpZe3/Dfco4nUA5uikouT/6aLEnb7Sv/GDUjxv?=
 =?us-ascii?Q?FFPtkxdNBQeELGl3iGIXFjL9q5OTAAx5A+2TkjbqopPpQzkeIrugZ/CLtIWd?=
 =?us-ascii?Q?ck1OAlB6Qte3Pqk0LeOx9tyh98BFwmuFOr9riRrwfRMBL3dCeIV7pJGs6ERO?=
 =?us-ascii?Q?rvqSfBKnAhIABSIpkLl1BulMu/iVXEf4eKCPvTOj6btJD04T2vkKgxkkV8kI?=
 =?us-ascii?Q?ToX7gQ9r4qErogtpU7+ytEMfnWNNluGjGpgk95p89Tb3Z7qfec4FqSnYNIlP?=
 =?us-ascii?Q?Pn80PLtX6gLLEVJxHViS0PRHmvKR+8r+9e5s6dphJA+kxvvaj7s70AJQWr59?=
 =?us-ascii?Q?6h6qN3g3nZtMFgj+VPM4R9x+c5ofSq5WQ4tRtNeRclo9z0yGq9IVwg5ekMm6?=
 =?us-ascii?Q?1MifaSyK2puN6oSQEfxryG5F4BKBFKZBSFaOoGpqsO+P0ga7t+yH0BLEpKSb?=
 =?us-ascii?Q?PJsJj5h09p3IPYuvAB7B+polaqxavMr2zX+H6cevPZrkqOX5phTPCt7/5SlY?=
 =?us-ascii?Q?mqOgmlpeIbm+aMxWgrs7fUoKfl1ZKyUD/G1YvxP3ZzMyuvxG/0GmItDs9wuM?=
 =?us-ascii?Q?5mxX8lMwTX5L0CtCFZgvSOisARKmyGb4gGKZpiSrT4V/Uw8dQ75fezCjrzT/?=
 =?us-ascii?Q?cxBo+XSD10gWCCeBtgjvwcCr2dPuw6ZIO5FaP/iY6nirsSR9L9h0jynqgIfv?=
 =?us-ascii?Q?zBe5kh1rkLpQblUbxqIGz/f53PCpNlm0d08FISCWJTF4yPl232d9mB5UGUNr?=
 =?us-ascii?Q?9g=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3521.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: da2229c3-a022-425f-af17-08dbb5c76029
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Sep 2023 08:40:11.8957
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: STzkIiIfNP+4XIibPBMxz9OdP841tduOokGTzOp4qIrjE+oPhhQmlcLoS3tcCQMNb0s84rm4D2rM9GruIIs0fw1wGJPW9YF0/yEe6Bt860o=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6941
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 15 Sep 2023 01:41:22 -0700 (PDT)

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Tony Nguyen
> Sent: Friday, September 8, 2023 10:11 PM
> To: poros <poros@redhat.com>; netdev@vger.kernel.org
> Cc: ivecera <ivecera@redhat.com>; Brandeburg, Jesse
> <jesse.brandeburg@intel.com>; linux-kernel@vger.kernel.org;
> edumazet@google.com; intel-wired-lan@lists.osuosl.org; horms@kernel.org;
> kuba@kernel.org; pabeni@redhat.com; davem@davemloft.net
> Subject: Re: [Intel-wired-lan] [PATCH net v2 2/2] iavf: schedule a reques=
t
> immediately after add/delete vlan
>=20
>=20
>=20
> On 9/7/2023 8:02 AM, Petr Oros wrote:
> > When the iavf driver wants to reconfigure the VLAN filters
> > (iavf_add_vlan, iavf_del_vlan), it sets a flag in
> > aq_required:
> >    adapter->aq_required |=3D IAVF_FLAG_AQ_ADD_VLAN_FILTER;
> > or:
> >    adapter->aq_required |=3D IAVF_FLAG_AQ_DEL_VLAN_FILTER;
> >
> > This is later processed by the watchdog_task, but it runs periodically
> > every 2 seconds, so it can be a long time before it processes the reque=
st.
> >
> > In the worst case, the interface is unable to receive traffic for more
> > than 2 seconds for no objective reason.
> >
>=20
> Changes look ok, however, can you supply or add a Fixes:?
>=20
> > Signed-off-by: Petr Oros <poros@redhat.com>
> > Co-developed-by: Michal Schmidt <mschmidt@redhat.com>
> > Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
> > Co-developed-by: Ivan Vecera <ivecera@redhat.com>
> > Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> > Reviewed-by: Ahmed Zaki <ahmed.zaki@intel.com>
> > ---
> >   drivers/net/ethernet/intel/iavf/iavf_main.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c
> > b/drivers/net/ethernet/intel/iavf/iavf_main.c
> > index 86d472dfdbc10c..d9f8ac1d57fd62 100644
> > --- a/drivers/net/ethernet/intel/iavf/iavf_main.c
> > +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
> > @@ -821,7 +821,7 @@ iavf_vlan_filter *iavf_add_vlan(struct iavf_adapter


Tested-by: Rafal Romanowski <rafal.romanowski@intel.com>