Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
MIME-Version: 1.0
References: <20230915062926.2460502-1-Delphine_CC_Chiu@wiwynn.com>
 <20230915062926.2460502-3-Delphine_CC_Chiu@wiwynn.com> <20230915-quench-left-8fbc1ca3b1da@spud>
In-Reply-To: <20230915-quench-left-8fbc1ca3b1da@spud>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Fri, 15 Sep 2023 10:20:54 -0500
Message-ID: <CAL_JsqKWRfT71k56uMUJtU_abzFuicW01OBo-iScYash4Jrd2w@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] dt-bindings: hwmon: add MAX31790
To:     Conor Dooley <conor@kernel.org>
Cc:     Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>, patrick@stwcx.xyz,
        Jean Delvare <jdelvare@suse.com>,
        Guenter Roeck <linux@roeck-us.net>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Sep 15, 2023 at 9:50=E2=80=AFAM Conor Dooley <conor@kernel.org> wro=
te:
>
> Yo,
>
> On Fri, Sep 15, 2023 at 02:29:24PM +0800, Delphine CC Chiu wrote:
> > Add dt-bindings for the MAXIM MAX31790.
> >
> > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>
> > ---
> > Changelog:
> > v2 - Add dt-bindings for the MAXIM MAX31790.
> > ---
> >  .../bindings/hwmon/maxim,max31790.yaml        | 59 +++++++++++++++++++
> >  MAINTAINERS                                   |  6 ++
> >  2 files changed, 65 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max31=
790.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/hwmon/maxim,max31790.yam=
l b/Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml
> > new file mode 100644
> > index 000000000000..2bd455b36b3f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml
> > @@ -0,0 +1,59 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +
> > +$id: http://devicetree.org/schemas/hwmon/maxim,max31790.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Maxim max31790
> > +
> > +maintainers:
> > +  - Delphine CC Chiu  <Delphine_CC_Chiu@wiwynn.com>
> > +
> > +description: |
> > +  The MAX31790 controls the speeds of up to six fans using
> > +  six independent PWM outputs. The desired fan speeds (or PWM duty cyc=
les)
> > +  are written through the I2C        interface.
> > +  The outputs drive =E2=80=9C4-wire=E2=80=9D fans directly, or can be =
used to modulate
> > +  the fan=E2=80=99s power terminals using an external pass transistor.
> > +
> > +  Datasheets:
> > +    https://datasheets.maximintegrated.com/en/ds/MAX31790.pdf
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - maxim,max31790
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  pwm-as-tach:
>
> I don't see any other users of this in-tree, so you'd need a vendor
> prefix. That said, I'm once bitten, twice shy about fan related
> properties in hwmon, so I would definitely like Rob to comment on this
> whole binding.

Please see this[1] and comment on it to ensure it meets your needs.
Otherwise, omit any fan related properties for now.

Rob

[1] https://lore.kernel.org/all/20230830123202.3408318-2-billy_tsai@aspeedt=
ech.com/